From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=fail (p=quarantine dis=none) header.from=redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 00D875A0269 for ; Wed, 14 Oct 2026 13:28:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791977307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ICpdxTTE2VBaDG6pXvoT525ToVlGMGddcQHCxbJtbaU=; b=AMuuSlPcsDRCLQAVxOX1AQ2fFGV+bVm7RmQf+GeX+cecX0WYgXoVV5pyC1A7RyocjYOwG4 TgkuYooCZO75bwns0q2ORmkMuKoCNncsrIiPQZk9X3jrpHfxNAqgwGaM5DUbywW8CJARmE 9T7a0Ugc95NPS2YoXu0YvHoKBQUoWnQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-235-i202srzWMSaZSiN-bbGAqA-1; Wed, 14 Oct 2026 11:28:26 +0000 X-MC-Unique: i202srzWMSaZSiN-bbGAqA-1 X-Mimecast-MFC-AGG-ID: i202srzWMSaZSiN-bbGAqA_1791977306 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-47f2de3ba47so233178f8f.1 for ; Wed, 14 Oct 2026 04:28:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791977306; x=1792582106; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=ICpdxTTE2VBaDG6pXvoT525ToVlGMGddcQHCxbJtbaU=; b=ikDfSoZbAeKBZY0Z2b2031czb3dkUnPOhh1eN9kHtBK5owoRvhh1O0fd7mwW4bpBI6 MurlwdRAU2Zdr0nJOnzV60rIA7FD2SwLtzHJHVRHwARZssXDhEaa2cR9Yg3/vt8q+4/r beKs1amyxj3HCwvknT9TZ3lKV23VpIS9N/+8xgWvAd4Ejy9HNM6lzbshe/ZtRYAOYVoZ eSAz5lmJeJyOiFIMnjTkCy4s+MSekWSwoPldUElOLB17NbWDr4Ji/RXtil2Fo+oMhc4M hzyfXsjAwzm3h0cQpu5mmDWSsmGMrJhMLMQfBCJNFQ/rXWLB8PpT8Mw1AEkZM6qihMQe U5ng== X-Gm-Message-State: AFq9FYJGwV+iRE2EGJSI/XUm6KjOPS7+KpZAISMMgStGng+gxszo9HNC Gj/RM2tx7xukvbfpQRomi6WABkVhY8x819wPgbejL+pwJwmOfKUYVvnUPHj6arMum3axsf/MZjA TATDQ4xYBD8EOtErzf4RgsKxRsUeU9agEOBeOnA3JbfcHZW604F1/aXi5tlkY6bahvxHzgpcrK9 pVXvD7wrjSKAjJ+cZKZtTZkLlFKOCW87TrVsHi X-Gm-Gg: AYBFou3wiIVyz1uW+Cp0ZJ9fHoZw5UAP1mDa+ZYpP+irOl2uDx5sZk9skJ/Eo9NwLJ/ 5FakzrSG7zzBcnzy/oqU/JDPBuc4QCVBXr7m6sfiNE8KmFdSfZ0d4NDId2UWIExGlcyRstDY6nK KenI7sm9azZNeRnvWyp0wZpf5wgyB4mL0TE2N23tM7vusJEkNYzEuP1PEaGBU7XS9QRKPuXtO5U cjNI7StSjPtW8rvYJZLatF93NKxgON2nF92JxI4dpUxUoRUNPVLBPaWKPBVfDr5kNOlHn0Ksu6A sJKM3nyDdtzeNLcw2XfYSebzFUfVUuIxlZFI3Axf8wHpvTy/6+dmUnzrJRt2Or9k7M+niqLK6Av 1bJqmCVy//g== X-Received: by 2002:a05:6000:46d6:b0:48d:c20c:cc4d with SMTP id ffacd0b85a97d-48dc20cccd2mr15734504f8f.23.1791977305458; Wed, 14 Oct 2026 04:28:25 -0700 (PDT) X-Received: by 2002:a05:6000:46d6:b0:48d:c20c:cc4d with SMTP id ffacd0b85a97d-48dc20cccd2mr15734473f8f.23.1791977304846; Wed, 14 Oct 2026 04:28:24 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48de0967acasm9246133f8f.2.2026.10.14.04.28.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 04:28:23 -0700 (PDT) From: Stefano Brivio To: "Bernhard M. Wiedemann" Subject: Re: [PATCH] tcp_splice: avoid delay on certain transfers Message-ID: <20261014132822.075de7bd@elisabeth> In-Reply-To: <20261002163925.1338988-1-bwiedemann@suse.de> References: <20261002163925.1338988-1-bwiedemann@suse.de> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 14 Oct 2026 13:28:23 +0200 (CEST) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5KcRuHnA6C1PaFMafch7PZU2cZicxisjNxLqv-P4j7U_1791977306 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: ZE5FXQ2XEJCGS35VRGE53WDM3D5HGGDQ X-Message-ID-Hash: ZE5FXQ2XEJCGS35VRGE53WDM3D5HGGDQ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 2 Oct 2026 18:39:25 +0200 "Bernhard M. Wiedemann" wrote: > without this patch, sending buffers of certain sizes > caused a delay of 200ms because tcp_splice_forward() > passes SPLICE_F_MORE to the writer > when a read filled at least 90% of the pipe. > > This is easy to hit when pipes are small: once a user exceeds > fs.pipe-user-pages-soft (64 MiB by default, which a few long-running > pasta instances with large pipes reach on their own), > tcp_set_pipe_size() settles on the 8 KiB minimum, and every message > whose length is 7372 to 8192 bytes (90% of the pipe and more) past a > multiple of 8 KiB stalls. > > This change leaves bulk throughput unchanged. > > Assisted-by: Claude:claude-opus-5-5 > Signed-off-by: Bernhard M. Wiedemann > --- Applied, thanks, sorry for the delay, and welcome to the git log! > Notes: > The change was slightly tested and benchmarked. Results look decent. I also played a bit with it and the scripts you supplied in different setups, and couldn't find any relevant issue either. It might be worth having them (with license, usage and all) under, say, doc/performance/ or something like that. I don't have a big preference either way, though, because after all we already have the same tests using iperf3 and tcp_rr. > Not sure if we actually need the flow_trace for error handling there. I think yes, that's actually useful should it ever happen. -- Stefano