From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=fail (p=quarantine dis=none) header.from=redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id D133D5A0265 for ; Wed, 11 Nov 2026 02:47:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794361639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fi6ieaPrJUFhlrDN/MO01D+87/OOU2acgzbyg+7bnVU=; b=TtTh5s/OkYLgBu78pl8uQELdryHqmkuGZ1hx8ZV0jeX2iKwuzj/BCExIKLo/jEmDK3xNub iV3MEkfN/mZOM7sP4+4/deBOViq2CD8+UpfjHwGhm522uG+SqrL+m501KCO9v/T8ysZKRw VqOWAvY/up/rUxrirD1csnUoJL7sz/Q= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-5Vg1PJFpOkajQCmieIyhHg-1; Tue, 10 Nov 2026 20:47:18 -0500 X-MC-Unique: 5Vg1PJFpOkajQCmieIyhHg-1 X-Mimecast-MFC-AGG-ID: 5Vg1PJFpOkajQCmieIyhHg_1794361637 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4994d67d0e3so15979525e9.2 for ; Tue, 10 Nov 2026 17:47:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794361637; x=1794966437; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=fi6ieaPrJUFhlrDN/MO01D+87/OOU2acgzbyg+7bnVU=; b=LMEJh0uIvDer43/qdQwMUUdVRHCyvxwgAUVay9qxhjKTv+J+qS4rrCoggrDrTzMB7e nUOVzpGg8R59yFBXiWAx0GhORv7+U9pTXXZ12YadjWlxiDHsCDaHMywdw01ukEsYAD2Z Sl69NoyzuY4BTboenri9eY1+w1IHadGfgKfZ+uR1TTZcu5fMoToY7xMLKoORHWs/flAV /th8VUikOXKoMBByrL5SAANUDGD+dT3urZ2m0tzYKVx4O/kSYYG6PINnSf1UYLBtgw4s g+L1yKfQ5yU9PQHRO+KEnc/Fkg+zZ2Rzcv+XXH2K5Tn3xClrlO6MrydT2OxGrZeQAExY mXeQ== X-Gm-Message-State: APuU4Z8m2Eb2dybk2tugsTv+dp5/+WnfeHWdrquZqbPCdJ4bM/qaNFQq pR4+pFg9v/UrvXdQ9adlP1LFbNfNcdZ69bPUDRA2CpmQN1BuwvyK2cnw/2NEnTyfBrl9yrmiOuO iYgG8Dneg7C0+FQiGP4hhAzb4q9IDWEpUNDZGUuRjdMdG/7xk00A5Jw== X-Gm-Gg: AYBFou0SmBGXfVRdwLHSffNJvUA31hcV+m0tpJ70P63957jmSx7Co8aRInyPo5l/cK7 iiw6RfsFPykyTEjihOoSnQjtYrvInuWbXRi/Cmf8d1nG5p69cyTidfaz5BnQITmHaMTwCLyRvYs m+LPNx2jTXz6/MyfE8wBZeNvFW90IXqJuFC5+gtr7ozKYIujwLtCLgbFcbOnN1j6qwuYCeYUA0S N6qIrtlAtOHexx2KVAN96dtyk+NzzJZpM51nFvXEljU/YykX5KDdBH4K+in5lHlZnMA/H6QL2c2 HrOoBENNX/lCaYeQ92dwr+/phjDUFRpZvrCfHwMSPvGzxn7aK55CSybL1R4g56LedPSA3jc+xxr e6TRHuKagQuS4RlOlbOOIxWUUsOJNLJAvc7fV88ar3YVjfQGzVhE8A9KbYTFAvc8n50g= X-Received: by 2002:a05:600c:3f16:b0:4aa:2339:a375 with SMTP id 5b1f17b1804b1-4ba09375b00mr12556225e9.13.1794361636379; Tue, 10 Nov 2026 17:47:16 -0800 (PST) X-Received: by 2002:a05:600c:3f16:b0:4aa:2339:a375 with SMTP id 5b1f17b1804b1-4ba09375b00mr12555815e9.13.1794361635552; Tue, 10 Nov 2026 17:47:15 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4ba01fe63e6sm155174835e9.7.2026.11.10.17.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 17:47:12 -0800 (PST) From: Stefano Brivio To: Martin Schitter Subject: Re: [PATCH] netlink: Fix nl_route_dup by 3-step processing Message-ID: <20261111024709.223fabdc@elisabeth> In-Reply-To: <20261107114621.804266-1-ms+git@mur.at> References: <20261107114621.804266-1-ms+git@mur.at> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 11 Nov 2026 02:47:10 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: sNKyQ7KHanDiwxirGLxwpoCQp9V_rzG-7GngeE3ET4s_1794361637 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: RG46UZ2H2UW2X4ONZJE5ILJ54GAFQQME X-Message-ID-Hash: RG46UZ2H2UW2X4ONZJE5ILJ54GAFQQME X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 7 Nov 2026 12:46:21 +0100 Martin Schitter wrote: > Eliminate the route entries capacity limitations of nl_route_dup > by copying them to the destination namespace in three successive > steps to bypass dependency issues. This approach is inspired by > the code design used in the restore subcommand of iproute2. > > [...] Sorry, I'm not sure why, but this breaks Podman tests on my setup, which has (for IPv4) a single /27 address, and a default, single route via the gateway. If I do: ./pasta -a 192.0.2.1 I get EINVAL on the second route insertion in nl_route_dup(). If the address is configured as /32 it works, if it's anything else (/31 or shorter mask), it doesn't. Isolated one-line reproducer (which should be independent from the network setup): $ ./pasta -Ix -- sh -c 'ip l set dev x up && ip a a 198.50.100.2/31 dev x && ./pasta -4 --config-net -a 192.0.2.1' Couldn't set IPv4 route(s) in guest: Invalid argument I didn't debug further than that. -- Stefano