From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=fail (p=quarantine dis=none) header.from=redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 937BB5A0274 for ; Wed, 11 Nov 2026 08:03:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794380630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qO1ZCx2983LeSefufwy/QpsgXAhUUwyHaUj6yGEnBMk=; b=JJYK8Vaz/jduqNqykoAfL6J3YO39ZpcPrCW3BGOJfn6GhqWAdT/jYXMGDD2R0zmYiSvPnJ HCN16i6ApSuKOWV2GslJKBwvLwy3HdHsauPUQY3yJSzSVhQeRX3W5+oRlU4nhHl/TJ2ewY dIzk0QSyZyamuXr1DgbcfDr1D4vKFA4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-Vaq-U1psOcOg67H8rHFqng-1; Wed, 11 Nov 2026 02:03:48 -0500 X-MC-Unique: Vaq-U1psOcOg67H8rHFqng-1 X-Mimecast-MFC-AGG-ID: Vaq-U1psOcOg67H8rHFqng_1794380627 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4902ce85f72so2205979f8f.2 for ; Tue, 10 Nov 2026 23:03:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794380627; x=1794985427; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=qO1ZCx2983LeSefufwy/QpsgXAhUUwyHaUj6yGEnBMk=; b=aTvd88uV2B6SZFf0HlDNTg6KSUKy+B2BZjZ2LCSmL8o+15iPciephaoswsde9CMf89 beR5eGlaug0VubpcIO+2ZS2ZXUf3VX8TBxwDTTyqXJj5H7T+a924LrxEIortqxYSzHX0 OSeWeQtNMfE1qBpGfwdEDqkFNAyNQBhGpAdiTJSS9Be2Dpy2kZ0LBN3wyBs4qygvDucA +cIrGZbq9QSvWYlKnFTy5IBq5/hSx14GoHZt1ttr/j5dCUjz/NC/NF5FtlZbZLaefcBV yCxiEfoKg4xrjaC28W0ToHCRVUyCG2wjXvUdJQQ3DgrYRz+KS5ZOUoE6Q4Av13Bs5NH9 TZ5Q== X-Forwarded-Encrypted: i=1; AL+hErGM4/G2T/WiriACUgmB4FolJJIU8ErbWYmlydM3pMMB7a4CsVuVECnAXfcTGE78McPnnCMQbGHmnyQ=@passt.top X-Gm-Message-State: APuU4Z8a7lpxZ3QZ2pDmyaiCfsQ18xftebV26fx9VSHgKfri8e162V5L d4ZQe8HIabunujMQMTe3PhP7itNrek+4pCfidLIra4kKUlAn/B6AClDouejdVzAVavB1+StngUH tk8RjkDE0KyWIvA2Bygz3hqkZLxAa4XmC5GpKVxaRvN9+HxM5PGO51m1w8QZpng== X-Gm-Gg: AYBFou0ScLqOVP4bRpqequngRQ2sa2iYhWilwJXcReojgD4e1bH5Ae+NrZQFS8blNKC ARgfHlXMv/O0GoKHTwa78FBOmQ7Hm6uFI6hb6w31F2B9uR+G6VMFMGNdiYdPOrOJ9ZP0OQTHCY7 rcmdqzGoNVhG4diTe5Wh87F8AF4yAyqehjZ0kqBZ42DwU0NsbapX9L7KXIP9GAuODNoin6Xhaal AhXXVy6b79F4vIAAGhitHfbJljxHGDlxzMLhIsMd9iyeiCxRQiDfIgfZYgt3JR1rrnzX/FkjZII aDWkxwguO0CKHA38ll92sqsEY0AESX3Tx3kqGVcx7L532wyYwKS30ufNRF0gAaLQwUWqYkOn2je fOKcmvLWHRGKiD5sxRtlf0K1g3V1lpvOcO/QjxEPv4nFUaY6QT2Vy3cg8HZY+UicP8A8= X-Received: by 2002:a05:600c:3b98:b0:4a6:7d6:821f with SMTP id 5b1f17b1804b1-4ba0938a529mr24482815e9.29.1794380626496; Tue, 10 Nov 2026 23:03:46 -0800 (PST) X-Received: by 2002:a05:600c:3b98:b0:4a6:7d6:821f with SMTP id 5b1f17b1804b1-4ba0938a529mr24482295e9.29.1794380626080; Tue, 10 Nov 2026 23:03:46 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4ba02005946sm134724625e9.1.2026.11.10.23.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2026 23:03:42 -0800 (PST) From: Stefano Brivio To: Jon Maloy Subject: Re: [PATCH v16] passt, pasta: Introduce unified multi-address data structures Message-ID: <20261111080340.61db3b60@elisabeth> In-Reply-To: <20261105001112.2495089-1-jmaloy@redhat.com> References: <20261105001112.2495089-1-jmaloy@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Wed, 11 Nov 2026 08:03:41 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OuMG3z_H07z0gjdEqVR56eftzQYmhgFxAYlzwb6u1fY_1794380627 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: OTV2BCA7NQFNZOD2VX2WXSD7TERMSAWA X-Message-ID-Hash: OTV2BCA7NQFNZOD2VX2WXSD7TERMSAWA X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: david@gibson.dropbear.id.au, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 4 Nov 2026 19:11:12 -0500 Jon Maloy wrote: > As preparation for supporting multiple addresses per interface, > we replace the single addr/prefix_len fields with an array. The > array consists of a new struct inany_addr_entry containing an > address and prefix length, both in inany_addr format. > > Despite some code refactoring, there are only two real functional > changes: > - The indicated IPv6 prefix length is now properly stored, instead > of being ignored and overridden with the hardcoded value 64, as > has been the case until now. > - Since even IPv4 addresses now are stored in IPv6 format, we > also store the corresponding prefix length in that format, > i.e. using the range [96,128] instead of [0,32]. > > In conf_ip6(), the explicit IN6_IS_ADDR_UNSPECIFIED() check on the > address at the end of the function is no longer needed: for > host-discovered addresses, it is now checked inside the if (!a) block > before calling fwd_set_addr(); for user-provided addresses (via -a), > validation already rejects unspecified addresses at parse time. > > Signed-off-by: Jon Maloy Applied, finally! Sorry for the delay. -- Stefano