From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: Doug Baggett <doug.baggett@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH] flow: Handle NULL (unknown) flows in flow logging functions
Date: Sun, 15 Nov 2026 23:37:28 +0100 [thread overview]
Message-ID: <20261115223728.1400901-1-sbrivio@redhat.com> (raw)
Starting from commit edeb2a26c663 ("udp: Improve messages for errors
getting errors"), we might call flow logging functions with a NULL
flow, for example via udp_sock_fwd() -> udp_sock_errs().
As reported by Doug, that will make us dereference a NULL flow in
flow_dbg(). This happens occasionally with a specific pattern in
outbound UDP traffic, where we contact a large number of endpoints
that might be occasionally unreachable.
We want to print socket errors even if we couldn't find an associated
flow. For simplicity, instead of adding conditionals in all the
possible callers, just handle NULL flows in flow logging functions,
and tell the user that we couldn't find a flow for the error.
Reported-by: Doug Baggett <doug.baggett@gmail.com>
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2529245
Fixes: edeb2a26c663 ("udp: Improve messages for errors getting errors")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
flow.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/flow.c b/flow.c
index 71918b7..27a24a4 100644
--- a/flow.c
+++ b/flow.c
@@ -295,14 +295,19 @@ void flow_log__(const struct flow_common *f, int pri, bool perror, bool details,
(void)vsnprintf(msg, sizeof(msg), fmt, args);
va_end(args);
- /* Show type if it's set, otherwise the state */
- if (f->state < FLOW_STATE_TYPED)
- type_or_state = FLOW_STATE(f);
- else
- type_or_state = FLOW_TYPE(f);
+ if (!f) {
+ logmsg(!perror, false, pri, "Flow: not found, error: %s", msg);
+ details = false;
+ } else {
+ /* Show type if it's set, otherwise the state */
+ if (f->state < FLOW_STATE_TYPED)
+ type_or_state = FLOW_STATE(f);
+ else
+ type_or_state = FLOW_TYPE(f);
- logmsg(!perror, false, pri,
- "Flow %u (%s): %s", flow_idx(f), type_or_state, msg);
+ logmsg(!perror, false, pri,
+ "Flow %u (%s): %s", flow_idx(f), type_or_state, msg);
+ }
if (perror)
logmsg(true, true, pri, ": %s", strerror_(errno_));
--
2.43.0
reply other threads:[~2026-11-15 22:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115223728.1400901-1-sbrivio@redhat.com \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=doug.baggett@gmail.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).