From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: Frajo Haider <frajo@frajo.fi>,
Sean McGinnis <sean.mcginnis@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH] fwd_rule: Restore forwarding of ephemeral ports for -t auto, -u auto
Date: Sun, 15 Nov 2026 23:40:44 +0100 [thread overview]
Message-ID: <20261115224044.1405061-1-sbrivio@redhat.com> (raw)
From: Frajo Haider <frajo@frajo.fi>
From an original patch by Frajo: commit 4e09ddf03443 ("conf: Allow
user-specified auto-scanned port forwarding ranges") made automatic
port forwarding exclude ephemeral ports, consistently with -t all and
-u all, and I thought this should actually be desirable, because those
ports are ephemeral, after all, and no services should be bound to
them.
On the other hand, services that can already be contacted on some
other port might want to expose additional (ephemeral indeed) ports.
So perhaps we should really expose them.
Now, Sean reports that this "feature" actually breaks things for the
kind (Kubernetes-in-Docker) project, because Docker relies on the
rootlesskit integration of pasta, which uses automatic port forwarding
instead of explicit configuration.
So, feature or not (and I'm fairly convinced it's a bug by now), it
causes a regression, so restore the previous behaviour: if ports are
automatically forwarded, don't exclude ephemeral ports.
Reported-by: Frajo Haider <frajo@frajo.fi>
Reported-by: Sean McGinnis <sean.mcginnis@gmail.com>
Link: https://bugs.passt.top/show_bug.cgi?id=219
Link: https://github.com/kubernetes-sigs/kind/issues/4293
Fixes: 4e09ddf03443 ("conf: Allow user-specified auto-scanned port forwarding ranges")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
fwd_rule.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fwd_rule.c b/fwd_rule.c
index 312bc60..a1294d6 100644
--- a/fwd_rule.c
+++ b/fwd_rule.c
@@ -694,7 +694,8 @@ static void fwd_rule_parse_ports(struct fwd_table *fwd, bool del, uint8_t proto,
/* Finally handle "all" and exclude only cases */
if (exclude_only) {
- fwd_port_map_ephemeral(exclude);
+ if (!(flags & FWD_SCAN))
+ fwd_port_map_ephemeral(exclude);
fwd_rule_range_except(fwd, del, proto, addr, ifname,
1, NUM_PORTS - 1, exclude,
--
2.43.0
reply other threads:[~2026-11-15 22:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115224044.1405061-1-sbrivio@redhat.com \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=frajo@frajo.fi \
--cc=passt-dev@passt.top \
--cc=sean.mcginnis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).