From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=fail (p=quarantine dis=none) header.from=redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 400965A0265 for ; Mon, 16 Nov 2026 14:21:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794835287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DUXaXU49Ce9mbQvuSRsGZR86YEaIIyFqj1Uorv9Ax/w=; b=GaepxG7FENaBrPPvdj3NP4tvxS4leD+we4lvUAswPmR273D7iEeyR//UhcwrUPLFVTEAbT BPEzmDCQd2T7O8iyoXe98851MvG05kitlK7QlU/y+PuAYGMyhiGQBU6N03XObLJD5swqrG 0UD33/WPdLKASbqhwHpEJwe2pNMgQLY= X-MC-Rep: binary re single Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37-ePTD_WfmP7Gea9pIq7sEqA-1; Mon, 16 Nov 2026 08:21:22 -0500 X-MC-Unique: ePTD_WfmP7Gea9pIq7sEqA-1 X-Mimecast-MFC-AGG-ID: ePTD_WfmP7Gea9pIq7sEqA_1794835282 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ECAA719560B4; Mon, 16 Nov 2026 13:21:21 +0000 (UTC) Received: from lvivier-thinkpadp1gen8.rmtfr.csb (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7B6C91956088; Mon, 16 Nov 2026 13:21:20 +0000 (UTC) From: Laurent Vivier To: passt-dev@passt.top Subject: [PATCH] Fix assert() in tcp_vu_sock_recv() Date: Mon, 16 Nov 2026 14:21:19 +0100 Message-ID: <20261116132119.1545654-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -B3eaQHN0xsklVXqv7MdxQwPmZipUeSkDfWNTPOUwqk_1794835282 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: QMBJ7GKYNZ2UD7Y66UEPCIDJY45M5OHB X-Message-ID-Hash: QMBJ7GKYNZ2UD7Y66UEPCIDJY45M5OHB X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Johannes Bartunek , Jon Maloy , Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In tcp_vu_sock_recv(), iov_tail_clone() can copy up to ARRAY_SIZE(iov_msg) - j entries so the assert must allow ARRAY_SIZE(iov_msg) - j as valid a value. Reported-by: Johannes Bartunek Signed-off-by: Laurent Vivier --- tcp_vu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcp_vu.c b/tcp_vu.c index 868a35b968e1..c83abd69d3d7 100644 --- a/tcp_vu.c +++ b/tcp_vu.c @@ -291,7 +291,7 @@ static ssize_t tcp_vu_sock_recv(const struct ctx *c, struct vu_virtq *vq, cnt = iov_tail_clone(&iov_msg[j], ARRAY_SIZE(iov_msg) - j, &data); - assert(cnt < ARRAY_SIZE(iov_msg) - j); + assert(cnt <= ARRAY_SIZE(iov_msg) - j); if (cnt < 0) die("Missing entries in iov_msg"); -- 2.56.0