From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=fail (p=quarantine dis=none) header.from=redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 2EAC85A0619 for ; Tue, 17 Nov 2026 12:04:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794913459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qh3hsloPchAqNGhl+K6KYEOjrnH5JuUWIjOhbezvIBg=; b=hCN8d48PwuRUxR0sl++msDTrG+wcjLUcKfuT2MVQ3lqHWMiUokz2EXh1yl0uhq5bTj9BkN vMNdgA/hK5xCDS/4s/IEAxq02j+HKGY7jR5nVje2oMLmktnLba2QLCeONL+MvCKLu6hxjX 1KvytgR0azL4KGz3x1VOiAUjxR2APbo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-drJQIO_GOOGtYwjnxT73gA-1; Tue, 17 Nov 2026 06:04:17 -0500 X-MC-Unique: drJQIO_GOOGtYwjnxT73gA-1 X-Mimecast-MFC-AGG-ID: drJQIO_GOOGtYwjnxT73gA_1794913457 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4b764ffc014so34197685e9.0 for ; Tue, 17 Nov 2026 03:04:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794913456; x=1795518256; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Qh3hsloPchAqNGhl+K6KYEOjrnH5JuUWIjOhbezvIBg=; b=QSNb5+YPf9zcPJWWe0ziF4mHdyNqaSKwulIl91QLU97IDdDTt88Rq6pmveif4EyKwl W3vbXFq7vUi5RrwefRxvMxoEEo3lwC/B0XZEDwjv+dXI9iGWOpFsE6MZUdiUfti0cIFH jSRGmKyt5ayVYPz2jIny0uB28KBcahL0uPLLGoKaP2vGTcDXanjaLpgxMRnExsT9jOaA WKKL29EpwD+yx3kmlYHBN/qW8TtrY75Z4R1vNyUJR6CHk81wZ7tCRn9U0QFkInI/e+qP zjpXDrMevvsCTRyZFFWopgWD9/yD7OazZUzvuLI5bEkgBYwavui9mqqwaZBx6lTaLBVG 43Ig== X-Gm-Message-State: APuU4Z/broZizALIW50SA/KQ8YT9fX+IMhU3gEED2AE/BDypIHuF0nF/ QkvNbBba2omM5wL69I4z621R7jj3X0oeLk0VVFxK5kyWVV8Ng4xLM+32/KgJ70clpHFgigcoj8H D3q1V5/EYqBkDhZpYTFR4YK4R7XN69zI1IJtXbGAGx9lzSQ3dbg6wMsZjh3wB3g== X-Gm-Gg: AYBFou0p7DrqydHr1pJP9eJCbnxRLIKCbc3TzWpnxg+KiVmMa4xsO3FyjcnZFeUVvuH xJjVVtJb1LuzIRaAE6IabvBTfHuEozd+LcAit7ksqotAtZXEgxA9iFObEwk7/33nFWfIy5AYKF4 mWml9LNCW8KH7p0yTgrEChQI4nrih22hdz5zwdTZxUssWFvWRPIt6dF99RthEpuyVj0cIIQOLYO qGvANCPhXeEfvqHltCoeZb+SlMtnf6X/5FJyMqeTUF1YaeIVZh33jOvkc1d+TZJVkfnYmsYGraO QW9vBoo7/k92IYczR2SwLO3bwbGAVQ/NQIkgbKi22IkeVbWB4xlolL+DwXfap8DPWkHZzHwSSBo E8p3z++NK2YApdDp3cxHiFz/odbtAZ9DxfG6JneYUhNiNCdLPqT7oJKOhrzj+ZzmcqQdhGlt6Ug lkqubwgvHF X-Received: by 2002:a05:600c:c4a3:b0:4a1:6992:f861 with SMTP id 5b1f17b1804b1-4bb55a02932mr270741115e9.1.1794913456390; Tue, 17 Nov 2026 03:04:16 -0800 (PST) X-Received: by 2002:a05:600c:c4a3:b0:4a1:6992:f861 with SMTP id 5b1f17b1804b1-4bb55a02932mr270740435e9.1.1794913455833; Tue, 17 Nov 2026 03:04:15 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb783854cesm94066885e9.1.2026.11.17.03.04.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 03:04:15 -0800 (PST) From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH] Fix assert() in tcp_vu_sock_recv() Message-ID: <20261117120413.64f7a15b@elisabeth> In-Reply-To: <20261116132119.1545654-1-lvivier@redhat.com> References: <20261116132119.1545654-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Tue, 17 Nov 2026 12:04:14 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SIkT9KnOQcarYiJUxFHQgLbfO3gOg-WleZ5mDY-YCoI_1794913457 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: UFYH2UJ6227BWW7XJW5WWYEWJS5ARAQE X-Message-ID-Hash: UFYH2UJ6227BWW7XJW5WWYEWJS5ARAQE X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Johannes Bartunek , Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 16 Nov 2026 14:21:19 +0100 Laurent Vivier wrote: > In tcp_vu_sock_recv(), iov_tail_clone() can copy up to > ARRAY_SIZE(iov_msg) - j entries so the assert must allow > ARRAY_SIZE(iov_msg) - j as valid a value. > > Reported-by: Johannes Bartunek > Signed-off-by: Laurent Vivier > --- > tcp_vu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tcp_vu.c b/tcp_vu.c > index 868a35b968e1..c83abd69d3d7 100644 > --- a/tcp_vu.c > +++ b/tcp_vu.c > @@ -291,7 +291,7 @@ static ssize_t tcp_vu_sock_recv(const struct ctx *c, struct vu_virtq *vq, > > cnt = iov_tail_clone(&iov_msg[j], ARRAY_SIZE(iov_msg) - j, > &data); > - assert(cnt < ARRAY_SIZE(iov_msg) - j); > + assert(cnt <= ARRAY_SIZE(iov_msg) - j); > if (cnt < 0) > die("Missing entries in iov_msg"); > Applied. -- Stefano