From: Stefano Brivio <sbrivio@redhat.com>
To: Aditya Merchant <adityamerchant08@gmail.com>
Cc: passt-dev@passt.top, David Gibson <david@gibson.dropbear.id.au>,
Paul Holzinger <pholzing@redhat.com>,
Laurent Vivier <lvivier@redhat.com>
Subject: Re: [PATCH v2 0/2] Follow changes to the host nameserver for DNS forwarding
Date: Thu, 19 Nov 2026 01:21:40 +0100 (CET) [thread overview]
Message-ID: <20261119012139.5772ae34@elisabeth> (raw)
In-Reply-To: <20261113112114.38764-1-adityamerchant08@gmail.com>
On Fri, 13 Nov 2026 16:51:12 +0530
Aditya Merchant <adityamerchant08@gmail.com> wrote:
> Patch 1/2 is v2 of "conf: Follow changes to the host nameserver used for
> DNS forwarding", reworked after Stefano's review. Patch 2/2 terminates
> the inotify buffer in pasta_netns_quit_inotify_handler() as well, as
> also pointed out there.
>
> v2:
> - Only follow a file called resolv.conf, or a link to one, and never
> open anything else through the copy of its directory: the name is now
> fixed, not kept in struct ctx (Stefano)
> - Don't follow changes if we can't make the copy read-only, which needs
> Linux 5.12, instead of going on with a writable copy (Stefano)
> - Never copy the root directory, if resolv.conf turns out to be there
> - Terminate the inotify buffer, and stop at the first relevant event or
> at an overflow (Stefano)
> - SELinux: allow watching /etc, and the directories NetworkManager and
> systemd-resolved use under /run (Stefano)
> - AppArmor: a single rule for the locations under /run, as we don't
> follow stub-resolv.conf anymore
> - Add test/pasta_options/dns_host_follow (Stefano)
> - Rebase on current master
Thanks for following up Aditya, the whole series looks great to me as
well.
I just need to try out things with SELinux, and I'd also like to test a
couple of possible corner cases with Podman that came to my mind, then
we can finally merge this.
--
Stefano
prev parent reply other threads:[~2026-11-19 0:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 11:21 Aditya Merchant
2026-11-13 11:21 ` [PATCH v2 1/2] conf: Follow changes to the host nameserver used " Aditya Merchant
2026-11-17 16:35 ` Laurent Vivier
2026-11-13 11:21 ` [PATCH v2 2/2] pasta: Terminate inotify buffer, skip nameless events in netns watch Aditya Merchant
2026-11-17 13:15 ` Laurent Vivier
2026-11-19 0:21 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119012139.5772ae34@elisabeth \
--to=sbrivio@redhat.com \
--cc=adityamerchant08@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
--cc=pholzing@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).