public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Jon Maloy <jmaloy@redhat.com>
To: sbrivio@redhat.com, david@gibson.dropbear.id.au,
	jmaloy@redhat.com, passt-dev@passt.top
Subject: [PATCH 1/3] clang-tidy: Also disable bugprone-signed-bitwise
Date: Thu, 19 Nov 2026 20:32:46 -0500	[thread overview]
Message-ID: <20261120013248.1472649-2-jmaloy@redhat.com> (raw)
In-Reply-To: <20261120013248.1472649-1-jmaloy@redhat.com>

The hicpp-signed-bitwise check is disabled in .clang-tidy, as we need
bitwise operations on signed values for syscalls, epoll_wait() flags,
etc.

clang-tidy 23 removed the hicpp module, moving its checks to other
modules, and hicpp-signed-bitwise became bugprone-signed-bitwise. The
existing exclusion therefore no longer applies, and as we enable all
checks and treat warnings as errors, 'make clang-tidy' fails with
clang-tidy 23.1.5, e.g.:

  arp.c:139:37: error: use of a signed integer operand with a binary
  bitwise operator [bugprone-signed-bitwise,-warnings-as-errors]
    139 |         a = fwd_get_addr(c, AF_INET, true, CONF_ADDR_ANY);

where CONF_ADDR_ANY is built from BIT(n), that is, (1UL << (n)), and
the shift count is a signed int.

Disable the check under its new name as well, keeping the old one for
older clang-tidy versions.

Signed-off-by: Jon Maloy <jmaloy@redhat.com>
---
 .clang-tidy | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.clang-tidy b/.clang-tidy
index 9ba43bf0..ec570f2d 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -26,8 +26,10 @@ Checks:
     #	TODO: this is Linux-only for the moment, nice to fix eventually
     - "-llvmlibc-restrict-system-libc-headers"
 
-    #	Those are needed for syscalls, epoll_wait flags, etc.
+    #	Those are needed for syscalls, epoll_wait flags, etc.  Moved
+    #	from hicpp to bugprone as clang-tidy 23 dropped the hicpp module
     - "-hicpp-signed-bitwise"
+    - "-bugprone-signed-bitwise"
 
     #	Probably not doable to impement this without plain memcpy(), memset()
     - "-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling"
-- 
2.56.1


  reply	other threads:[~2026-11-20  1:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  1:32 [PATCH 0/3] Fix 'make clang-tidy' with clang-tidy 23 Jon Maloy
2026-11-20  1:32 ` Jon Maloy [this message]
2026-11-20  1:32 ` [PATCH 2/3] clang-tidy: Disable checks new in " Jon Maloy
2026-11-20  1:32 ` [PATCH 3/3] passt-repair: Drop redundant parentheses around stat() calls Jon Maloy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120013248.1472649-2-jmaloy@redhat.com \
    --to=jmaloy@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).