From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=fail (p=quarantine dis=none) header.from=redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 489195A0269 for ; Fri, 20 Nov 2026 18:38:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1795196286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tRVyMQoQeG5XlD90gcXDdFHKrSO/O2eySIj5oXonuZI=; b=Ona1jB7T+b4nfrtWmUoUcSGLtIEbw6Hb3okmiKpsoQDJcKK5lFBggVRUKf7cbzI5Td0OhS A6WxZW7olzV4O4giySBsCQ/vOYu0B7Mcaw8s/GjFzMYHGoFoMXpfWb0ltQhOvc9W61FRwE u6ntWf2+yG6TCckKYIBgPxLXtyUJlmo= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-GEJS8i0_OdqOMjbfJQm_hQ-1; Fri, 20 Nov 2026 17:38:02 +0000 X-MC-Unique: GEJS8i0_OdqOMjbfJQm_hQ-1 X-Mimecast-MFC-AGG-ID: GEJS8i0_OdqOMjbfJQm_hQ_1795196281 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4291718005B2; Fri, 20 Nov 2026 17:38:01 +0000 (UTC) Received: from anskuma-thinkpadp1gen7.redhat.corp (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0DE481956049; Fri, 20 Nov 2026 17:37:58 +0000 (UTC) From: Anshu Kumari To: passt-dev@passt.top, sbrivio@redhat.com, ada.urbaniec+bugzilla@gmail.com Subject: [PATCH v3] tcp: Limit fast retransmit to one per loss event Date: Fri, 20 Nov 2026 23:07:56 +0530 Message-ID: <20261120173756.2000624-1-anskuma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: li_NBaZx9qyHmapGXWWDk_0xkgCQnBXlOUZNw_1Cros_1795196281 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: HM6XHUSFXBCBPISXJG4RTICKILLVUSJB X-Message-ID-Hash: HM6XHUSFXBCBPISXJG4RTICKILLVUSJB X-MailFrom: anskuma@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: anskuma@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Every duplicate ACK unconditionally triggered a fast retransmit, even when the ACK sequence hadn't advanced. Guard fast retransmit on !conn->retries, and increment retries after the first retransmit. This is a quick fix to stop the amplification storm. Full compliance with RFC 5681 Section 3.2 (three duplicate ACKs) is left to a later patch. Link: https://bugs.passt.top/show_bug.cgi?id=224 Signed-off-by: Anshu Kumari --- tcp.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tcp.c b/tcp.c index 95f4f3e1..d3d65f76 100644 --- a/tcp.c +++ b/tcp.c @@ -2082,7 +2082,9 @@ static int tcp_data_from_tap(const struct ctx *c, struct tcp_tap_conn *conn, tcp_tap_window_update(c, conn, max_ack_seq_wnd, now); - if (retr) { + if (retr && !conn->retries) { + conn->retries++; + flow_trace(conn, "fast re-transmit, ACK: %u, previous sequence: %u", conn->seq_ack_from_tap, conn->seq_to_tap); @@ -2443,7 +2445,9 @@ int tcp_tap_handler(const struct ctx *c, uint8_t pif, sa_family_t af, tcp_update_seqack_from_tap(c, conn, ntohl(th->ack_seq), now); - if (retr) { + if (retr && !conn->retries) { + conn->retries++; + flow_trace(conn, "fast re-transmit, ACK: %u, previous sequence: %u", ntohl(th->ack_seq), conn->seq_to_tap); -- 2.55.0