public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Jon Maloy <jmaloy@redhat.com>
To: sbrivio@redhat.com, david@gibson.dropbear.id.au,
	jmaloy@redhat.com, passt-dev@passt.top
Subject: [PATCH v9 3/5] arp: Check all configured addresses in ARP filtering
Date: Fri, 20 Nov 2026 14:24:35 -0500	[thread overview]
Message-ID: <20261120192437.1860855-4-jmaloy@redhat.com> (raw)
In-Reply-To: <20261120192437.1860855-1-jmaloy@redhat.com>

As a preparation for handling multiple addresses, we update ignore_arp()
to check against all addresses in the unified addrs[] array using the
for_each_addr() macro.

Signed-off-by: Jon Maloy <jmaloy@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

---
v3: -Adapted to single-array changes earlier in this series
v6: -Made loop in ignore_arp() a little more palatable,
     but not entirely as suggested by David.
v7: -Curly brackets in ignore_arp(), as suggested by Stefano.
    -I did not modify the for_each_addr(), macro, as Stefano suggested,
     since it also would require us to add an extra parameter indicating
     the array length.
v9: Adapted to changes due to rebase and earlier changes in series
---
 arp.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/arp.c b/arp.c
index 08d5a9f9..74167e44 100644
--- a/arp.c
+++ b/arp.c
@@ -42,7 +42,7 @@ static bool ignore_arp(const struct ctx *c,
 		       const struct arphdr *ah, const struct arpmsg *am)
 {
 	const struct guest_addr *a;
-	const struct in_addr *a4;
+	union inany_addr addr;
 
 	if (ah->ar_hrd != htons(ARPHRD_ETHER)	||
 	    ah->ar_pro != htons(ETH_P_IP)	||
@@ -56,14 +56,12 @@ static bool ignore_arp(const struct ctx *c,
 	    !memcmp(am->sip, am->tip, sizeof(am->sip)))
 		return true;
 
-	/* Don't resolve the guest's assigned address, either. */
-	a = fwd_get_addr(c, AF_INET, true, CONF_ADDR_ANY);
-	if (!a)
-		return false;
-	a4 = inany_v4(&a->addr);
-	if (a4 && !memcmp(am->tip, a4, sizeof(am->tip)))
-		return true;
-
+	/* Don't resolve any of the guest's addresses */
+	inany_from_af(&addr, AF_INET, am->tip);
+	for_each_addr(a, c->addrs, c->addr_count, AF_INET) {
+		if (inany_equals(&addr, &a->addr))
+			return true;
+	}
 	return false;
 }
 
-- 
2.56.1


  parent reply	other threads:[~2026-11-20 19:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 19:24 [PATCH v9 0/5] Introduce multiple addresses Jon Maloy
2026-11-20 19:24 ` [PATCH v9 1/5] tap, conf: Replace addr_fixed with CONF_ADDR_USER flag check Jon Maloy
2026-11-20 19:24 ` [PATCH v9 2/5] fwd: Unify guest accessibility checks with unified address array Jon Maloy
2026-11-20 19:24 ` Jon Maloy [this message]
2026-11-20 19:24 ` [PATCH v9 4/5] conf: Allow multiple -a/--address options per address family Jon Maloy
2026-11-20 19:24 ` [PATCH v9 5/5] netlink, conf: Read all addresses from template interface at startup Jon Maloy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120192437.1860855-4-jmaloy@redhat.com \
    --to=jmaloy@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).