From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=fail (p=quarantine dis=none) header.from=redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 496015A0269 for ; Fri, 20 Nov 2026 21:18:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1795205919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l2PyZ0g3oOlgnFka4p1mHMF9FWfwYjFNa9KwmVrZFlw=; b=Vj41Ueqxxn7dHINLOoz2HwKqg1Ln3/E7sbk29unw/WaiSNXBK4Xlsk3QnfcZ3rSTqJ7Geb LF8/qfsH4BtrdxJcP7Q6nHerad28eeTrh1bEit/obVAy8UGzALQxhmQasQbbRngN1foGLM NdnVyqkQkjvO1GCo2upBWiMWbZ1uObg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-552-pdUiz661Pe2oHSi1pnaFdg-1; Fri, 20 Nov 2026 20:18:37 +0000 X-MC-Unique: pdUiz661Pe2oHSi1pnaFdg-1 X-Mimecast-MFC-AGG-ID: pdUiz661Pe2oHSi1pnaFdg_1795205916 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4a70b42bab0so11444945e9.1 for ; Fri, 20 Nov 2026 12:18:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795205916; x=1795810716; h=date:content-transfer-encoding:content-type:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=l2PyZ0g3oOlgnFka4p1mHMF9FWfwYjFNa9KwmVrZFlw=; b=Tff6RqbNAMW+5n0lJHHeykta7m1ja3UcGAPG+2BnuCsJ+A2vbqTVjkHNqoWdjeVNCY uk5XK38tv7umtd6cVyszWnWPNZ6k1Z1VJVedF4aRMdw01MG77X6gUbQXtl77R3k2O07x Z7ZXN9e8FpmJTlwauEOHkn6AAESa9NJbSJv2fQ94Wy+6XLB/naQSfgzeH5LpJZcKoKCr 8IBCvamghv+QibiAvDvuq6thaP9lQ3DtIWgUIFlJW81BAaBoLpltvlu0eozHnVsjEXOn Rsga0FId0OZRWI/+iIdDfpw4w2dWSWyY4cgGdZjmaq417oZzYFxJIWRJYSO8k6jfh0+q XHwQ== X-Forwarded-Encrypted: i=1; AL+hErGc3sLnyKTam+t4oAR0xHFt43J+vB9lWnDSE/dCX9RkTbLq3TpBx5PVw1YDKjkLv6UTJfa5IaxDouo=@passt.top X-Gm-Message-State: APuU4Z/Q9GJxPT9p/b+NMT7M8AefMHe8+ohQvwtEqyx9UD+TXI98kE7E h6QxcOM7hIJ0tgWBjK7SDgGr3j/Xv1WGfPD1UM8Xw3xiiJ5JV5U0lnEbft1Dgpnxes3Ezv+9cVN V3linx0nC2YGyhoSlrZ4iWt17pPQZfS4D5VO6UyrDvL3qI2JQeTRmcg== X-Gm-Gg: AYBFou3FGUollaYGKTIDX/MJsgxEmyBhUMqgzYtdo3DLnIl6/WMZ7oj/4OIBS/jF0lN Mc4500vLDcW3YHiM9mzyq/ObQ6zyW5TY4uLYbd15lLTs5ebSRSW1vpMJEUVU/QxsNOTBz0H+8Ny 2gCsCZOT0QgJSA2nm+JWUYwk2nwf0Hl4r58Cy1/7ZpUiEZsSTx1+D0uLS0nunZniG2lxaE587ah KGsw/frQrZC/G24WGuOU6d9QeZA/0tz5gz/AXNjRm+/KNVbWn2KgKbZqpMVG7qZD0nDtKWKqVnS 8cmAp+AwjIaKlThoKg4kSjIEkn+cuMTB5OseNTq3fGt/H5tVvuNjbaIM5z9HsebLS35N5xjx4Ab yXJ2qpA7tHboO60tgNfBh6AGJ60iulfMj8m2n4dVoJedQx0PLvF3zqTb2srrKzHbC4VQ= X-Received: by 2002:a05:600c:1d09:b0:4bb:66fd:ad68 with SMTP id 5b1f17b1804b1-4bb888160cdmr99913165e9.14.1795205915847; Fri, 20 Nov 2026 12:18:35 -0800 (PST) X-Received: by 2002:a05:600c:1d09:b0:4bb:66fd:ad68 with SMTP id 5b1f17b1804b1-4bb888160cdmr99912725e9.14.1795205915389; Fri, 20 Nov 2026 12:18:35 -0800 (PST) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb90655f5asm10325565e9.1.2026.11.20.12.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2026 12:18:34 -0800 (PST) From: Stefano Brivio To: ada.urbaniec+bugzilla@gmail.com Subject: Re: [PATCH v3] tcp: Limit fast retransmit to one per loss event Message-ID: <20261120211833.656426f0@elisabeth> In-Reply-To: <20261120173756.2000624-1-anskuma@redhat.com> References: <20261120173756.2000624-1-anskuma@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 Date: Fri, 20 Nov 2026 21:18:34 +0100 (CET) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZYGwt42r22mzMnVlytUu4vSHy2ezwqjYYqM-WWJseXY_1795205916 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 3XIWRX2OYX6SAA4ZIOIPZFX3I4IIG2L7 X-Message-ID-Hash: 3XIWRX2OYX6SAA4ZIOIPZFX3I4IIG2L7 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Anshu Kumari , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Nov 2026 23:07:56 +0530 Anshu Kumari wrote: > Every duplicate ACK unconditionally triggered a fast retransmit, > even when the ACK sequence hadn't advanced. > > Guard fast retransmit on !conn->retries, and increment retries > after the first retransmit. This is a quick fix to stop the > amplification storm. Full compliance with RFC 5681 Section 3.2 > (three duplicate ACKs) is left to a later patch. Ada, would you have a chance to try this patch out? Would you like to be credited with a Reported-by: tag? -- Stefano