public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
20da1f72ebaa1343c920da90cf1a087cbcade9b4 blob 12134 bytes (raw)

  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
 
// SPDX-License-Identifier: GPL-2.0-or-later

/* PASST - Plug A Simple Socket Transport
 *  for qemu/UNIX domain socket mode
 *
 * PASTA - Pack A Subtle Tap Abstraction
 *  for network namespace/tap device mode
 *
 * migrate.c - Migration sections, layout, and routines
 *
 * Copyright (c) 2025 Red Hat GmbH
 * Author: Stefano Brivio <sbrivio@redhat.com>
 */

#include <errno.h>
#include <sys/uio.h>

#include "util.h"
#include "ip.h"
#include "passt.h"
#include "inany.h"
#include "flow.h"
#include "flow_table.h"

#include "migrate.h"
#include "repair.h"

/* Magic identifier for migration data */
#define MIGRATE_MAGIC		0xB1BB1D1B0BB1D1B0

/**
 * struct migrate_seen_addrs_v2 - Migratable observed guest addresses
 * @addr6:	Observed guest IPv6 address
 * @addr6_ll:	Observed guest IPv6 link-local address
 * @addr4:	Observed guest IPv4 address
 * @mac:	Observed guest MAC address
 */
struct migrate_seen_addrs_v2 {
	struct in6_addr addr6;
	struct in6_addr addr6_ll;
	struct in_addr addr4;
	unsigned char mac[ETH_ALEN];
} __attribute__((packed));

/**
 * struct migrate_seen_addrs_v3 - Migratable observed guest addresses
 * @addr_count:	Number of address entries
 * @addrs:	Array of observed address entries
 * @mac:	Observed guest MAC address
 */
struct migrate_seen_addrs_v3 {
	uint8_t addr_count;
	struct inany_addr_entry addrs[INANY_MAX_ADDRS];
	unsigned char mac[ETH_ALEN];
} __packed;

/**
 * seen_addrs_source_v2() - Send observed addresses from source
 * @c:		Execution context
 * @stage:	Migration stage, unused
 * @fd:		File descriptor for state transfer
 *
 * Return: 0 on success, positive error code on failure
 */
/* cppcheck-suppress [constParameterCallback, unmatchedSuppression] */
static int seen_addrs_source_v2(struct ctx *c,
				const struct migrate_stage *stage, int fd)
{
	struct migrate_seen_addrs_v2 addrs = { 0 };
	const struct inany_addr_entry *e;

	(void)stage;

	/* Find first observed IPv4 address */
	for_each_addr(c, e, AF_INET) {
		if (e->flags & INANY_ADDR_OBSERVED) {
			addrs.addr4 = *inany_v4(&e->addr);
			break;
		}
	}

	/* Find first observed IPv6 addresses (global and link-local) */
	for_each_addr(c, e, AF_INET6) {
		struct in6_addr tmp;

		if (!(e->flags & INANY_ADDR_OBSERVED))
			continue;
		if (e->flags & INANY_ADDR_LINKLOCAL) {
			tmp = addrs.addr6_ll;
			if (IN6_IS_ADDR_UNSPECIFIED(&tmp))
				addrs.addr6_ll = e->addr.a6;
		} else {
			tmp = addrs.addr6;
			if (IN6_IS_ADDR_UNSPECIFIED(&tmp))
				addrs.addr6 = e->addr.a6;
		}
	}

	memcpy(addrs.mac, c->guest_mac, sizeof(addrs.mac));

	if (write_all_buf(fd, &addrs, sizeof(addrs)))
		return errno;

	return 0;
}

/**
 * migrate_observed_addr4() - Add observed IPv4 address to address array
 * @c:		Execution context
 * @addr:	IPv4 address to add
 */
static void migrate_observed_addr4(struct ctx *c, const struct in_addr *addr)
{
	struct inany_addr_entry *e;

	if (IN4_IS_ADDR_UNSPECIFIED(addr))
		return;

	for_each_addr(c, e, AF_INET) {
		if (IN4_ARE_ADDR_EQUAL(addr, inany_v4(&e->addr))) {
			e->flags |= INANY_ADDR_OBSERVED;
			return;
		}
	}

	if (c->addr_count < INANY_MAX_ADDRS) {
		c->addrs[c->addr_count].addr = inany_from_v4(*addr);
		c->addrs[c->addr_count].prefix_len = 0;
		c->addrs[c->addr_count].flags = INANY_ADDR_OBSERVED;
		c->addr_count++;
	}
}

/**
 * migrate_observed_addr6() - Add observed IPv6 address to address array
 * @c:		Execution context
 * @addr:	IPv6 address to add
 */
static void migrate_observed_addr6(struct ctx *c, const struct in6_addr *addr)
{
	uint8_t flags = INANY_ADDR_OBSERVED;
	struct inany_addr_entry *e;

	if (IN6_IS_ADDR_UNSPECIFIED(addr))
		return;

	if (IN6_IS_ADDR_LINKLOCAL(addr))
		flags |= INANY_ADDR_LINKLOCAL;

	for_each_addr(c, e, AF_INET6) {
		if (IN6_ARE_ADDR_EQUAL(addr, &e->addr.a6)) {
			e->flags |= flags;
			return;
		}
	}

	if (c->addr_count < INANY_MAX_ADDRS) {
		c->addrs[c->addr_count].addr.a6 = *addr;
		c->addrs[c->addr_count].prefix_len = 0;
		c->addrs[c->addr_count].flags = flags;
		c->addr_count++;
	}
}

/**
 * seen_addrs_target_v2() - Receive observed addresses on target
 * @c:		Execution context
 * @stage:	Migration stage, unused
 * @fd:		File descriptor for state transfer
 *
 * Return: 0 on success, positive error code on failure
 */
static int seen_addrs_target_v2(struct ctx *c,
				const struct migrate_stage *stage, int fd)
{
	struct migrate_seen_addrs_v2 addrs;
	struct in6_addr addr6, addr6_ll;
	struct in_addr addr4;

	(void)stage;

	if (read_all_buf(fd, &addrs, sizeof(addrs)))
		return errno;

	/* Copy from packed struct to avoid alignment issues */
	addr4 = addrs.addr4;
	addr6 = addrs.addr6;
	addr6_ll = addrs.addr6_ll;

	migrate_observed_addr4(c, &addr4);
	migrate_observed_addr6(c, &addr6);
	migrate_observed_addr6(c, &addr6_ll);

	memcpy(c->guest_mac, addrs.mac, sizeof(c->guest_mac));

	return 0;
}

/**
 * seen_addrs_source_v3() - Send observed addresses from source
 * @c:		Execution context
 * @stage:	Migration stage, unused
 * @fd:		File descriptor for state transfer
 *
 * Return: 0 on success, positive error code on failure
 */
/* cppcheck-suppress [constParameterCallback, unmatchedSuppression] */
static int seen_addrs_source_v3(struct ctx *c,
				const struct migrate_stage *stage, int fd)
{
	struct migrate_seen_addrs_v3 addrs = { .addr_count = 0 };
	const struct inany_addr_entry *e;

	(void)stage;

	/* Copy only observed address entries */
	for_each_addr(c, e, 0) {
		if ((e->flags & INANY_ADDR_OBSERVED) &&
		    addrs.addr_count < INANY_MAX_ADDRS)
			addrs.addrs[addrs.addr_count++] = *e;
	}

	memcpy(addrs.mac, c->guest_mac, sizeof(addrs.mac));

	if (write_all_buf(fd, &addrs, sizeof(addrs)))
		return errno;

	return 0;
}

/**
 * migrate_observed_addr() - Add observed address to address array
 * @c:		Execution context
 * @addr:	Address entry to add
 */
static void migrate_observed_addr(struct ctx *c,
				  const struct inany_addr_entry *addr)
{
	struct inany_addr_entry *e;

	if (inany_is_unspecified(&addr->addr))
		return;

	/* Check if address already exists, just mark it observed */
	for_each_addr(c, e, 0) {
		if (inany_equals(&e->addr, &addr->addr)) {
			e->flags |= INANY_ADDR_OBSERVED;
			return;
		}
	}

	/* Add new entry if there's room */
	if (c->addr_count < INANY_MAX_ADDRS)
		c->addrs[c->addr_count++] = *addr;
}

/**
 * seen_addrs_target_v3() - Receive observed addresses on target
 * @c:		Execution context
 * @stage:	Migration stage, unused
 * @fd:		File descriptor for state transfer
 *
 * Return: 0 on success, positive error code on failure
 */
static int seen_addrs_target_v3(struct ctx *c,
				const struct migrate_stage *stage, int fd)
{
	struct migrate_seen_addrs_v3 addrs;
	uint8_t i;

	(void)stage;

	if (read_all_buf(fd, &addrs, sizeof(addrs)))
		return errno;

	/* Merge observed addresses into existing array */
	for (i = 0; i < addrs.addr_count && i < INANY_MAX_ADDRS; i++) {
		struct inany_addr_entry e = addrs.addrs[i];

		migrate_observed_addr(c, &e);
	}

	memcpy(c->guest_mac, addrs.mac, sizeof(c->guest_mac));

	return 0;
}

/* Stages for version 2 */
static const struct migrate_stage stages_v2[] = {
	{
		.name = "observed addresses",
		.source = seen_addrs_source_v2,
		.target = seen_addrs_target_v2,
	},
	{
		.name = "prepare flows",
		.source = flow_migrate_source_pre,
		.target = NULL,
	},
	{
		.name = "transfer flows",
		.source = flow_migrate_source,
		.target = flow_migrate_target,
	},
	{ 0 },
};

/* Stages for version 3 (multiple observed IPv4 addresses) */
static const struct migrate_stage stages_v3[] = {
	{
		.name = "observed addresses",
		.source = seen_addrs_source_v3,
		.target = seen_addrs_target_v3,
	},
	{
		.name = "prepare flows",
		.source = flow_migrate_source_pre,
		.target = NULL,
	},
	{
		.name = "transfer flows",
		.source = flow_migrate_source,
		.target = flow_migrate_target,
	},
	{ 0 },
};

/* Supported encoding versions, from latest (most preferred) to oldest */
static const struct migrate_version versions[] = {
	{ 3,	stages_v3, },
	{ 2,	stages_v2, },
	/* v1 was released, but not widely used.  It had bad endianness for the
	 * MSS and omitted timestamps, which meant it usually wouldn't work.
	 * Therefore we don't attempt to support compatibility with it.
	 */
	{ 0 },
};

/* Current encoding version */
#define CURRENT_VERSION		(&versions[0])

/**
 * migrate_source() - Migration as source, send state to hypervisor
 * @c:		Execution context
 * @fd:		File descriptor for state transfer
 *
 * Return: 0 on success, positive error code on failure
 */
static int migrate_source(struct ctx *c, int fd)
{
	const struct migrate_version *v = CURRENT_VERSION;
	const struct migrate_header header = {
		.magic		= htonll_constant(MIGRATE_MAGIC),
		.version	= htonl(v->id),
		.compat_version	= htonl(v->id),
	};
	const struct migrate_stage *s;
	int ret;

	if (write_all_buf(fd, &header, sizeof(header))) {
		ret = errno;
		err("Can't send migration header: %s, abort", strerror_(ret));
		return ret;
	}

	for (s = v->s; s->name; s++) {
		if (!s->source)
			continue;

		debug("Source side migration stage: %s", s->name);

		if ((ret = s->source(c, s, fd))) {
			err("Source migration stage: %s: %s, abort", s->name,
			    strerror_(ret));
			return ret;
		}
	}

	return 0;
}

/**
 * migrate_target_read_header() - Read header in target
 * @fd:		Descriptor for state transfer
 *
 * Return: version structure on success, NULL on failure with errno set
 */
static const struct migrate_version *migrate_target_read_header(int fd)
{
	const struct migrate_version *v;
	struct migrate_header h;
	uint32_t id, compat_id;

	if (read_all_buf(fd, &h, sizeof(h)))
		return NULL;

	id = ntohl(h.version);
	compat_id = ntohl(h.compat_version);

	debug("Source magic: 0x%016" PRIx64 ", version: %u, compat: %u",
	      ntohll(h.magic), id, compat_id);

	if (ntohll(h.magic) != MIGRATE_MAGIC || !id || !compat_id) {
		err("Invalid incoming device state");
		errno = EINVAL;
		return NULL;
	}

	for (v = versions; v->id; v++)
		if (v->id <= id && v->id >= compat_id)
			return v;

	errno = ENOTSUP;
	err("Unsupported device state version: %u", id);
	return NULL;
}

/**
 * migrate_target() - Migration as target, receive state from hypervisor
 * @c:		Execution context
 * @fd:		File descriptor for state transfer
 *
 * Return: 0 on success, positive error code on failure
 */
static int migrate_target(struct ctx *c, int fd)
{
	const struct migrate_version *v;
	const struct migrate_stage *s;
	int ret;

	if (!(v = migrate_target_read_header(fd)))
		return errno;

	for (s = v->s; s->name; s++) {
		if (!s->target)
			continue;

		debug("Target side migration stage: %s", s->name);

		if ((ret = s->target(c, s, fd))) {
			err("Target migration stage: %s: %s, abort", s->name,
			    strerror_(ret));
			return ret;
		}
	}

	return 0;
}

/**
 * migrate_init() - Set up things necessary for migration
 * @c:		Execution context
 */
void migrate_init(struct ctx *c)
{
	c->device_state_result = -1;
}

/**
 * migrate_close() - Close migration channel and connection to passt-repair
 * @c:		Execution context
 */
void migrate_close(struct ctx *c)
{
	if (c->device_state_fd != -1) {
		debug("Closing migration channel, fd: %d", c->device_state_fd);
		close(c->device_state_fd);
		c->device_state_fd = -1;
		c->device_state_result = -1;
	}

	repair_close(c);
}

/**
 * migrate_request() - Request a migration of device state
 * @c:		Execution context
 * @fd:		fd to transfer state
 * @target:	Are we the target of the migration?
 */
void migrate_request(struct ctx *c, int fd, bool target)
{
	debug("Migration requested, fd: %d (was %d)", fd, c->device_state_fd);

	if (c->device_state_fd != -1)
		migrate_close(c);

	c->device_state_fd = fd;
	c->migrate_target = target;
}

/**
 * migrate_handler() - Send/receive passt internal state to/from hypervisor
 * @c:		Execution context
 */
void migrate_handler(struct ctx *c)
{
	int rc;

	if (c->device_state_fd < 0)
		return;

	debug("Handling migration request from fd: %d, target: %d",
	      c->device_state_fd, c->migrate_target);

	if (c->migrate_target)
		rc = migrate_target(c, c->device_state_fd);
	else
		rc = migrate_source(c, c->device_state_fd);

	migrate_close(c);

	c->device_state_result = rc;
}
debug log:

solving 20da1f7 ...
found 20da1f7 in https://archives.passt.top/passt-dev/20260130214447.2540791-11-jmaloy@redhat.com/
found a84af1c in https://archives.passt.top/passt-dev/20260130214447.2540791-10-jmaloy@redhat.com/
found 7398d26 in https://archives.passt.top/passt-dev/20260130214447.2540791-9-jmaloy@redhat.com/
found 48d63a0 in https://passt.top/passt
preparing index
index prepared:
100644 48d63a07e45953d83647155919e46b99e29e5d29	migrate.c

applying [1/3] https://archives.passt.top/passt-dev/20260130214447.2540791-9-jmaloy@redhat.com/
diff --git a/migrate.c b/migrate.c
index 48d63a0..7398d26 100644


applying [2/3] https://archives.passt.top/passt-dev/20260130214447.2540791-10-jmaloy@redhat.com/
diff --git a/migrate.c b/migrate.c
index 7398d26..a84af1c 100644


applying [3/3] https://archives.passt.top/passt-dev/20260130214447.2540791-11-jmaloy@redhat.com/
diff --git a/migrate.c b/migrate.c
index a84af1c..20da1f7 100644

Checking patch migrate.c...
Applied patch migrate.c cleanly.
Checking patch migrate.c...
Applied patch migrate.c cleanly.
Checking patch migrate.c...
Applied patch migrate.c cleanly.

index at:
100644 20da1f72ebaa1343c920da90cf1a087cbcade9b4	migrate.c

Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).