From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZvoVtGrQ; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id C930B5A0269 for ; Mon, 11 May 2026 15:27:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778506049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dqN1glfq6eHOesYYypsLT45XQ7ltZYaLkF1elE9B8hU=; b=ZvoVtGrQ6jlaHAHz7yXM4cKo4l0gaLLFXiCyOrJrXF8iw0MzUt2Z3QGEYeD37kIFuvgMj/ El+JqKJ1b458uum+PQ7YTyGeVzVFOFT5A2gSo0acbpiVMfjmrTQaofpKExSYIiNtkUZToh WeJ+Di0dJPAD3yTdtb0PEeAsSrE2lcQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-YSKxakV1N6acCB56kLVZJQ-1; Mon, 11 May 2026 09:27:27 -0400 X-MC-Unique: YSKxakV1N6acCB56kLVZJQ-1 X-Mimecast-MFC-AGG-ID: YSKxakV1N6acCB56kLVZJQ_1778506046 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48e51dc35a3so34052355e9.1 for ; Mon, 11 May 2026 06:27:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778506046; x=1779110846; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dqN1glfq6eHOesYYypsLT45XQ7ltZYaLkF1elE9B8hU=; b=m+vuDrXkyrZ/7V3BnB2XiZF5yhPVIcx71JX+pODKG20wNBS9FhhcnQQJdfGxA/VJq3 zSNpOyQhKhtWFAy27UfP1Jl76i/ZAUIkMHKRMgbfkvfC4WFY9eYdP4U/EYOoIpIzKORI v/DSme15m4V9I1O+dnhLerovKUIkpC/M8zxSE36CVrASWp8T16DMu7xp7HMMPGzB/6WO pgL+qlmc4NfOpaQLJTtPVijGayfpsONfG1PBlFWxGXLwndlkwb8oI0icpGpyepsvMvQa 2++rp4U9sdbI5w669w6FIR/m8RrsII/nSDq+8FoZ44y0eGyjF8kCmehziWDHUAI/RLP0 hlzg== X-Forwarded-Encrypted: i=1; AFNElJ/2ctQRtvCHYzP95S4zAwnrhnkopf0nbwTUKajKWU0ZseX9jk0eno7Kvz9ACroQG3H+r9RP2zjSgHc=@passt.top X-Gm-Message-State: AOJu0YzxmdXBneb21dzkuosCbKG2ZFNKL63Pl8gzR57LtYagv1/mlTaM Ahcjmy90FjA9A0brPbKdAVIH6U/6/SzrgvCGH0ic43me29N73KWq3/56QOfPZwW7wrpDJRSU/WO y2ycuNvu4d5dQYIABq92yjW88Zgj5jsqJ24MsRiCQtSfOFRKGN8wYkg== X-Gm-Gg: Acq92OGtkeRFyHLxBB9/kOwI/elAFHDax9Orvb7M1rt/osSWQi6OSzbaCvWYP3BagLM h80UI6RG44dI1DtTEI3ZivpEKXTpYTT28a/y9RfJdu8mZWQ7UdcLacFr/Zc9RN50SzGRckwpoBE luhPx4MElvajwV5TLFH+57eh2J2P3fzUCoWe7LoxUn7N0dvmuDIHeQa9KnjmMD5AhF5maTXu7d4 Xq6u6Yq5h3pFGFSGyh9LngwL00ek2SZtrJDpisgc9B9vJF4hj9zfd+vY7HUvugFv//zk7n+PQsl fu8+ATN+DqYpLiCey7riSIfqsOV1qjhL6ZV5oRMAilBX8zPRC1VXUd8x9OMOyeXgsi05QmLZbAE 7Di9snxDh+Q+6t9UVYvO6wrWlWwo9hWgv+Xhi4Irg2zPQImg+35knvNPOD4FfMxWEaA== X-Received: by 2002:a05:600c:c11c:b0:489:1e8a:90b4 with SMTP id 5b1f17b1804b1-48e51f37212mr282940305e9.21.1778506046396; Mon, 11 May 2026 06:27:26 -0700 (PDT) X-Received: by 2002:a05:600c:c11c:b0:489:1e8a:90b4 with SMTP id 5b1f17b1804b1-48e51f37212mr282939805e9.21.1778506045834; Mon, 11 May 2026 06:27:25 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e7041067dsm173844215e9.13.2026.05.11.06.27.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2026 06:27:25 -0700 (PDT) Message-ID: <25be90fc-dcc0-4c6e-ae5d-529b1265277a@redhat.com> Date: Mon, 11 May 2026 15:27:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] packet, clang-tidy: Packet pool buffers are not NULL To: David Gibson , passt-dev@passt.top, Stefano Brivio References: <20260511100322.1016757-1-david@gibson.dropbear.id.au> <20260511100322.1016757-7-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260511100322.1016757-7-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: arNnV0qrgdW1x14nYjPoWk_XOS_q4b3gWTnzq47OJN8_1778506046 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: R4LNAYU6CE76BLJAKQRL6ETNEZGZVBLT X-Message-ID-Hash: R4LNAYU6CE76BLJAKQRL6ETNEZGZVBLT X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/11/26 12:03, David Gibson wrote: > struct pool always needs a non-NULL buf field: it points either to the > actual memory used to store packets, or for vhost-user to the vhost user > memory structure which will contain the packets. We set this pointer > when we initialise the pool. However, clang-tidy (as of 22.1.4, at least) > doesn't realise this in packet_check_range(), causing UB warnings due to > the subtraction of ptr and p->buf. > > Clue it in with an assert(). > > Signed-off-by: David Gibson Reviewed-by: Laurent Vivier > --- > packet.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/packet.c b/packet.c > index 1cb74b74..7a347be6 100644 > --- a/packet.c > +++ b/packet.c > @@ -51,6 +51,8 @@ static int packet_check_range(const struct pool *p, const char *ptr, size_t len, > { > struct vdev_memory *memory; > > + assert(p->buf); > + > if (len > PACKET_MAX_LEN) { > debug("packet range length %zu (max %zu), %s:%i", > len, PACKET_MAX_LEN, func, line);