From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WDyOQaT0; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id CF6D35A061E for ; Mon, 23 Mar 2026 13:18:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774268317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0wzYbD5FGLC6bn0YzI90RFjfXSdpOrfzjnYhDDoSixc=; b=WDyOQaT0Np+cCcw9Qx2cRhHwoLdTgN2kW0U7PaM3qlbMpmzzdsTN7tPtOWjaCZnAkzBGHW jvKyFiXk6nWIi0qCnMqyF/MtONUFRMWHclknWMvtW9wvt6LxBDn3wJb+bAHJxqAQ/z+i/4 rMd4YthsQGWMX5fUr5jSPqBcSh0nct0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-Pe57cwArN3mPNXLd6Muncg-1; Mon, 23 Mar 2026 08:18:34 -0400 X-MC-Unique: Pe57cwArN3mPNXLd6Muncg-1 X-Mimecast-MFC-AGG-ID: Pe57cwArN3mPNXLd6Muncg_1774268313 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48553fdd03dso364925e9.0 for ; Mon, 23 Mar 2026 05:18:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774268313; x=1774873113; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0wzYbD5FGLC6bn0YzI90RFjfXSdpOrfzjnYhDDoSixc=; b=OEonETeOoaGzQKSvXXtq3my303T4vIvFy20YlH04yy2/hUF9r542kwW4ZQN1xElmpJ WvMmaneN6bBPUlVsee5LZTEW4vLYAIBI03SOz6G+LRopFz9vWBKICsfbG7AFYyXYuVCt l2eXHmbh+WnlHLKAPy3uwtiMJAiUok18v91xgWQpsztZ/hWawmO6xp1t4ZFqLysR4ugx 2BwI1xBnXEeofNpw3G/UZmUxzTWwVfTKD59+/HZm68gMeYfyxnwUt+TNMcgQiG640q3f L8sk/kkDLlkktaL26U+naNLtrZ2gpzRl4iQdj5hJMSRZrApDIPHne6VDisvoiNZpiexg jRNw== X-Forwarded-Encrypted: i=1; AJvYcCUCglKfv1zvWIoKekV2Ee6Z7+YQutGgG7ghYblCcaH7T5NIRfUcjIZ/D+48VZyLCcgM2/Z5AMJ20xE=@passt.top X-Gm-Message-State: AOJu0YwCnPwTjJTHlNeTaGn49KfIg1yF2jf7Wps937l/4OFeyPWcLX/n RUCC0bruSoWGp+kKRy2AL9tPStDyUg/0I7achXXdkMk5wciM6DS1m7YMIWgs44UNjHSRf2/owgo g8ezDxDmEHoL8ICC/Ik8rww2okWvWVfbqwA77Xr+C2YCg5topChXRuw== X-Gm-Gg: ATEYQzzQpPdh8gUwnSxERN552xDX3Avmw2/gdPV4AhzmzRYXZdlE8oFpMQS9+Z7dDeV /KRi9Qu65V5KtfWB+6ETslQiH2XwfH/r4FN6yplJMQDemCNpk2r4laBVpzV2EOZ/gboP2BHRKKf lXRxBWKgPWSwzJuyqXT6+18bT37cobpeSktVQ9TS33HZtu72rntSasa1rsjjLyskLxvAYyNklgL tbiuYEBuVZsV4cBLdUxr3ssUqc8qX1MTWMm2bE/8pyuvFin1nCL667DJ/1nmHQ5bi9nvOUvbv+g ql0vKBcFhbY3UBPv5jm/zwpYwlRb2YUiNEce29gVohNQiqhVZA0a28R0OQHOn4zNa4gGdbb6CH3 8b6RX9OQZHdmx9x4engRcY6MgEWsV9Q76HNnyDghi2N69JsMXVKvPYQ8YGxoyocdiwQ== X-Received: by 2002:a05:600c:a31c:b0:485:2a4b:7bc3 with SMTP id 5b1f17b1804b1-486fede723dmr139113765e9.4.1774268312977; Mon, 23 Mar 2026 05:18:32 -0700 (PDT) X-Received: by 2002:a05:600c:a31c:b0:485:2a4b:7bc3 with SMTP id 5b1f17b1804b1-486fede723dmr139113335e9.4.1774268312420; Mon, 23 Mar 2026 05:18:32 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4326:a36e:a7cb:624b? ([2a01:e0a:e10:ef90:4326:a36e:a7cb:624b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644bd0dcsm28058009f8f.11.2026.03.23.05.18.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 05:18:31 -0700 (PDT) Message-ID: <26136561-fc90-4f74-9984-aa5fd4e5ca97@redhat.com> Date: Mon, 23 Mar 2026 13:18:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Bug 134: message rate limiting https://bugs.passt.top/show_bug.cgi?id=134 To: Anshu Kumari , passt-dev@passt.top References: <20260323090305.319573-3-anskuma@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260323090305.319573-3-anskuma@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: VENLUvEgDvaEKCZvB2d4gJK3f1QpiQlOrZT9Umoa_1g_1774268313 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: SYMHPLOYRZK4IHM5RCEU4APDY7UKZL7V X-Message-ID-Hash: SYMHPLOYRZK4IHM5RCEU4APDY7UKZL7V X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, dgibson@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/23/26 10:03, Anshu Kumari wrote: > Hi Everyone, Hi Anshu, > Please review patch for Bug 134. > > Description:- Inorder to rate limit the messages, each logging function uses per-call-site static variables, so each macro expansion tracks its own rate independently. Allows up to LOG_RATELIMIT_BURST messages per window. When a new window starts after suppression, a summary of suppressed messages is logged. This should be a message describing the patch, not an email text. This will be commited and part of the change log of passt. If you want to introduce your patch with a message you can write a cover letter (you can put " Hi Everyone, Please review patch for Bug 134" in it) Put the bug link in the message body with Link: tag Link: https://bugs.passt.top/show_bug.cgi?id=134 Something like: "log: Add rate-limiting macros for log messages In order to rate limit the messages, each logging function uses per-call-site static variables, so each macro expansion tracks its own rate independently. Allows up to LOG_RATELIMIT_BURST messages per window. When a new window starts after suppression, a summary of suppressed messages is logged. Link: https://bugs.passt.top/show_bug.cgi?id=134 Signed-off-by: Anshu Kumari " > > Signed-off-by: Anshu Kumari > --- > log.h | 41 +++++++++++++++++++++++++++++++++++++++++ > tap.c | 19 ++++++------------- > 2 files changed, 47 insertions(+), 13 deletions(-) > > diff --git a/log.h b/log.h > index 6ceb686..e989760 100644 > --- a/log.h > +++ b/log.h > @@ -48,6 +48,47 @@ void logmsg_perror(int pri, const char *format, ...) > passt_exit(EXIT_FAILURE); \ > } while (0) > > +#define LOG_RATELIMIT_BURST 5 /* Max messages per window per call site */ > +#define LOG_RATELIMIT_INTERVAL 1 /* Default rate limit window in seconds */ > + > +/** > + * logmsg_ratelimit() - Rate-limited log message > + * @fn: Logging function > + * @now: current timestamp > + * @intv: Minimum interval in seconds between allowed messages > + */ > +#define logmsg_ratelimit(fn, now, intv, ...) \ > + do { \ > + static time_t _rl_last; \ > + static unsigned int _rl_printed; \ > + static unsigned int _rl_suppressed; \ > + \ > + if ((now)->tv_sec - _rl_last > (intv)) { \ > + if (_rl_suppressed) \ > + fn("(suppressed %u similar messages)", \ > + _rl_suppressed); \ > + _rl_last = (now)->tv_sec; \ > + _rl_printed = 0; \ > + _rl_suppressed = 0; \ > + } \ > + \ > + if (_rl_printed < LOG_RATELIMIT_BURST) { \ > + fn(__VA_ARGS__); \ > + _rl_printed++; \ > + } else { \ > + _rl_suppressed++; \ > + } \ > + } while (0) > + > +#define err_ratelimit(now, intv, ...) \ > + logmsg_ratelimit(err, now, intv, __VA_ARGS__) > +#define warn_ratelimit(now, intv, ...) \ > + logmsg_ratelimit(warn, now, intv, __VA_ARGS__) > +#define info_ratelimit(now, intv, ...) \ > + logmsg_ratelimit(info, now, intv, __VA_ARGS__) > +#define debug_ratelimit(now, intv, ...) \ > + logmsg_ratelimit(debug, now, intv, __VA_ARGS__) > + > extern int log_file; > extern int log_trace; > extern bool log_conf_parsed; > diff --git a/tap.c b/tap.c > index 1049e02..0812a8a 100644 > --- a/tap.c > +++ b/tap.c > @@ -686,17 +686,8 @@ static bool tap4_is_fragment(const struct iphdr *iph, > const struct timespec *now) > { > if (ntohs(iph->frag_off) & ~IP_DF) { > - /* Ratelimit messages */ > - static time_t last_message; > - static unsigned num_dropped; > - > - num_dropped++; > - if (now->tv_sec - last_message > FRAGMENT_MSG_RATE) { I think you could remove FRAGMENT_MSG_RATE and use LOG_RATELIMIT_INTERVAL, or better remove the intv parameter and use LOG_RATELIMIT_INTERVAL internally. > - warn("Can't process IPv4 fragments (%u dropped)", > - num_dropped); > - last_message = now->tv_sec; > - num_dropped = 0; > - } > + warn_ratelimit(now, FRAGMENT_MSG_RATE, > + "Can't process IPv4 fragment"); > return true; > } > return false; > @@ -1115,8 +1106,10 @@ void tap_add_packet(struct ctx *c, struct iov_tail *data, > char bufmac[ETH_ADDRSTRLEN]; > > memcpy(c->guest_mac, eh->h_source, ETH_ALEN); > - debug("New guest MAC address observed: %s", > - eth_ntop(c->guest_mac, bufmac, sizeof(bufmac))); > + info_ratelimit(now, LOG_RATELIMIT_INTERVAL, You changed "debug" to "info". Is this intentional? > + "New guest MAC address observed: %s", > + eth_ntop(c->guest_mac, bufmac, > + sizeof(bufmac))); > proto_update_l2_buf(c->guest_mac); > } > Thanks, Laurent