From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RXC9f6Wx; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 1AF375A0265 for ; Wed, 06 May 2026 13:21:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778066506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Jcyq5uBO6pwyLUUIqQufcH2lVqwdGtDnV5oRsVATBjw=; b=RXC9f6WxMZM8mtcjMjgwdjTmPlYDlkaV2K2DauCUDkJbJ7Md1Jva4ZMAFheUqo2Zy3jFSZ 43MlS4LMDvo8Hi5Yb8ZPialwgD0k95whFAEBKlcDN1F1J44aOgtyvZXcY0cQyfMV4mDfjC PPkYv7Mfe76zMhcE4OYnnuFnbP6SXqU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-UuoVLKtBM7uetV5jHyIKeA-1; Wed, 06 May 2026 07:21:44 -0400 X-MC-Unique: UuoVLKtBM7uetV5jHyIKeA-1 X-Mimecast-MFC-AGG-ID: UuoVLKtBM7uetV5jHyIKeA_1778066504 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48d0677b5f7so21694345e9.1 for ; Wed, 06 May 2026 04:21:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778066504; x=1778671304; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Jcyq5uBO6pwyLUUIqQufcH2lVqwdGtDnV5oRsVATBjw=; b=igyLcoUmsdCtseCHtYiVzHy1EVvvcoNcQnvUFqP8M4HE5KivCYg71a8XjQhcAbj5ZQ E/XJx/gMHr3XGaSAxdGLnHy4deRqDrcD1avvLpO6uq7yoqbNJ1IW0A6FtJdlh2nCi59Q JB3av8pNrSA8icfipcrtuqwSjF2OZJwOKIyfzFE9G3VlA6KkEc0xZq01VAO9DKGNi1zM k1Hup9jVVdDWyQtjBNYaccCKM7CosBF7AfiE7obnFn8qv19QRTjrq83KfIo1jAWFJdCn OEvGmLNRxiHWbW6aY2u1HXx7sMh10E3hKQMPau9f3+r8fxoXjKiarIY9YpKF6FS1QvxT JqBw== X-Forwarded-Encrypted: i=1; AFNElJ/qN4VO7WX7YOAFD7puknQN5cBuZClDLfmnKKoYQDPqBGzIu2jhiNz2NGyepBZ3FlXyCQFTCD4PFyI=@passt.top X-Gm-Message-State: AOJu0YyibaMlWQ+fRrA+npThmMRXV2QMizRMD+6Na9l2yWwTyP0P/6K2 EjjhdurT4f/ExWKmuq1JS15a2muMi9kV65n1oqR8nvmrfJtxBx897CY4F1PR4m4PYSnEoqiEPU/ 7BudKWh1naZjB6OgmpA4zFFFmSqjmTs7wE2hOKUad9/7HGSjGwm/rRg== X-Gm-Gg: AeBDieuQbYmJRURek5xiYEpqSQdWIFrxvK4OZzr3Hq+UrsbeUINqg2CkTegeQhtapTH cqMVnewg78M+gBsRjE3Y7bGf4+hYrvyRUcodt3jTKgyoQnyhtcOHMDaKLQmqLJAw2aDLArZrqzj nRW5DIvKJQAnLrE4tfeIeG4A3BM+o9Dbzq1s32aY8ADflX+wt4vnFpn5IMC5yfcFztXKDa/HhqM vIwgbYV9fgL6R/+8Ie70m7GJhr+pF67Q+6AzkX839tFGfEwiha4b8fb1cjcwi+FaqoMI8gMhL11 1pkoKDOns4S5hP2/MXhx9RKGODswSr1PAhtIqHxOGRUG+dxMLrs5gtuYnzYCN6XcYfxFOXEUgYN l5h2lW2dG7rwgCJnIlFfiypJis7L3w+taomns7fYQXoa9//nrv/j4rW4dWypMAvIAAw== X-Received: by 2002:a05:600c:15d3:b0:488:c80c:c236 with SMTP id 5b1f17b1804b1-48e51e0977fmr28833685e9.5.1778066503744; Wed, 06 May 2026 04:21:43 -0700 (PDT) X-Received: by 2002:a05:600c:15d3:b0:488:c80c:c236 with SMTP id 5b1f17b1804b1-48e51e0977fmr28833365e9.5.1778066503298; Wed, 06 May 2026 04:21:43 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e538d222esm50821455e9.14.2026.05.06.04.21.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 04:21:42 -0700 (PDT) Message-ID: <28a4d00e-dd0b-4d92-a10d-acf8f6c9dd45@redhat.com> Date: Wed, 6 May 2026 13:21:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 18/23] fwd_rule: Fix static checkers warnings in fwd_rule_add() To: Stefano Brivio , passt-dev@passt.top References: <20260506092241.1607480-1-sbrivio@redhat.com> <20260506092241.1607480-19-sbrivio@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260506092241.1607480-19-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MprRccxPuIhR7PrJXcVn-HUfUAGx-zcAs7qyU3hL_r4_1778066504 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: PI4CCEBGMN46MFYSAFZZ2NNC4KAERCZ6 X-Message-ID-Hash: PI4CCEBGMN46MFYSAFZZ2NNC4KAERCZ6 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jon Maloy , David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/6/26 11:22, Stefano Brivio wrote: > The new checks are actually sufficient but not enough for Coverity > Scan. Now that fwd->sock_count and new->last are affected or supplied > by clients, we need explicit (albeit redundant) checks on them. > > Signed-off-by: Stefano Brivio Reviewed-by: Laurent Vivier > --- > fwd_rule.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/fwd_rule.c b/fwd_rule.c > index b55e4df..200f4b5 100644 > --- a/fwd_rule.c > +++ b/fwd_rule.c > @@ -271,13 +271,24 @@ int fwd_rule_add(struct fwd_table *fwd, const struct fwd_rule *new) > warn("Too many rules (maximum %d)", ARRAY_SIZE(fwd->rules)); > return -ENOSPC; > } > + > if ((fwd->sock_count + num) > ARRAY_SIZE(fwd->socks)) { > warn("Rules require too many listening sockets (maximum %d)", > ARRAY_SIZE(fwd->socks)); > return -ENOSPC; > } > + /* Redundant (see check just above), to make static checkers happy */ > + if (fwd->sock_count > ARRAY_SIZE(fwd->socks)) > + return -ENOSPC; > > fwd->rulesocks[fwd->count] = &fwd->socks[fwd->sock_count]; > + > + /* Redundant, but not for static checkers, that might be missing that > + * due to the check on 'num' above against ARRAY_SIZE(fwd->socks), we > + * have a proper upper bound for new->last in the loop below. > + */ > + if (new->last > ARRAY_SIZE(fwd->socks) + new->first) > + return -ENOSPC; > for (port = new->first; port <= new->last; port++) > fwd->rulesocks[fwd->count][port - new->first] = -1; >