From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=P0mldwhw; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 2318E5A0279 for ; Fri, 08 Aug 2025 15:59:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754661598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IHysvH4mLCEprhDzkyrhYK839J70WrO3T3Fp0FtpONU=; b=P0mldwhwtpMep9dbW0kGT9pXDK1gGIX+yJB+lxokqST11LqKU/bpGQkopJk1gKUSEVOD6j attw9hPmciFMZnl1f23CmYgLb2BIJ5npcEWW8enphpoMNqOfTxxlfioDE5PxQwFjUsZLTw mgPLBTJgUPHJaUjjQghxVjI7vSQFDBY= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-111--scPJdz-PXGHWTFt6fL2qg-1; Fri, 08 Aug 2025 09:59:54 -0400 X-MC-Unique: -scPJdz-PXGHWTFt6fL2qg-1 X-Mimecast-MFC-AGG-ID: -scPJdz-PXGHWTFt6fL2qg_1754661594 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7e6857795eeso555318185a.3 for ; Fri, 08 Aug 2025 06:59:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754661594; x=1755266394; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IHysvH4mLCEprhDzkyrhYK839J70WrO3T3Fp0FtpONU=; b=BKO9WqxwoXsYZi9tJfM4TbsjQVXlL0ZviHbFGaVf2GXPL/OL/O/gM66LcdwkqAG9b7 AQMi8NP0Z3KoFc/48HgQQ0Z0zzzcZUJd2DQJmzpp9tKJ+Wi3u4Xa6UYE1JPDxWLjEGYT 7kRzUrBYI8/jIfE3L0sG0jFZbaSIoDYG1E0Q+7KelESvBgkLsFNM7EIc3t/uEE4azcFp oNhfUxuVJY7cuYzeeR+pfBZI2S6O5oBWyrLLCspJgKXKgaSCVQp34GAvLcHiqUUS4zur P56/rKijD5kYICpcZf0LsAZGZ051ZL6zil5D0CFtCKt5ZPExXK296olLvQXnKEVle0/l nATQ== X-Gm-Message-State: AOJu0YzOJsbexzIk6a3nYMXqw3O2UYLdjul5rRiy22pnzqgQTVmjRxDc 2EkmmhNlvhYTCFD/QyXY22Z84EEFUrgpVnuWFlPyYch1LiWamRGgmLMGbujjcyVi3yR0s1eQ+OJ jU4MfsPZYY87NqWh569JHTca5IQ+qU6ngoq+dPmA4zu+U28zIPgPC4A== X-Gm-Gg: ASbGncs9SaPye/kcA94H2FzTSK9I/XCWLuDv2v7/hCNs4HqDOZIerZaUWAh1u2Rb/Zm wCufOOsAZ77PeQ/zlY+F96pqDuiz8nsnU3AnmCMXP05jBAVkbvUSyCYbqoY/rGbTqod5qeADbbt ogYAyxy4lkZeSY/8wFsz18TNkQfkXhAFcQi7n2ds/4WTY+TzyD1LguVND3UDUpyoKsKE/b37ZkQ T+65RrnQobHAWDw6DdktQt9zE22G6+LZ59hzciNRCt/iVZ4oGK8MCXSfGMi6MLpmKJVmydyCH9q tjaE5MqmYkfiR+3x/mouCY4m/1bnhgR9KH38Mone0SdkRr34FfepC7PkAs+PuqLC6N/MBbQS+iU ksR/lxVWg X-Received: by 2002:a05:620a:1132:b0:7e6:98be:ee33 with SMTP id af79cd13be357-7e82c67d5ddmr330312785a.14.1754661594095; Fri, 08 Aug 2025 06:59:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEML0OV/FAcjR1ZOxr0ndUG4Ve+zziYv58Wte6BueXAp40dBjAaECU/e3JBWSPF0jQ8sfaUFw== X-Received: by 2002:a05:620a:1132:b0:7e6:98be:ee33 with SMTP id af79cd13be357-7e82c67d5ddmr330308085a.14.1754661593263; Fri, 08 Aug 2025 06:59:53 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e826870838sm216008985a.31.2025.08.08.06.59.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Aug 2025 06:59:52 -0700 (PDT) Message-ID: <29eeceb3-87a8-42d7-a95d-5be6b8d97478@redhat.com> Date: Fri, 8 Aug 2025 15:59:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 16/30] dhcpv6: Use iov_tail in dhcpv6_opt() To: David Gibson References: <20250805154628.301343-1-lvivier@redhat.com> <20250805154628.301343-17-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JM4DHMc71Xcds53LJFVFB5HpCKtL8w-3FLWkx-HcMO0_1754661594 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: W5SMRJLZIGID4EFNMNHXLUM3DGUSQJ5P X-Message-ID-Hash: W5SMRJLZIGID4EFNMNHXLUM3DGUSQJ5P X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 06/08/2025 06:14, David Gibson wrote: > On Tue, Aug 05, 2025 at 05:46:14PM +0200, Laurent Vivier wrote: >> dhcpv6_opt() and its callers are refactored for iov_tail option parsing, >> replacing direct offset management for improved robustness. >> >> Its signature is now `bool dhcpv6_opt(iov_tail *data, type)`. `*data` (in/out) >> points to a found option on `true` return or is restored on `false`. >> The main dhcpv6() function uses IOV_REMOVE_HEADER for the msg_hdr, then >> passes the iov_tail (now at options start) to the new dhcpv6_opt(). >> >> Signed-off-by: Laurent Vivier > > Hmm. I'm not sure this is a great use case for iov_tail - the code is > repeatedly scanning the same options, so there's a whole bunch of > rewinding. It works, but it seems awkward. > > DHCP is a slow path, anyway, so maybe we'd be better off just > linearizing the entire packet and using plain old pointers to scan > through the options. > Well, I'd like to avoid to rewrite this patch as it has a lot of changes. But if you think it's really needed I will do in a new version of the series. Thanks, LAurent