From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QkkO6M4W; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 2200E5A004E for ; Mon, 26 Jan 2026 13:13:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769429616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7bxbDiXE7aJstJGhBu6HYzE7kbQ9hprTW9KE74xy9Ns=; b=QkkO6M4WFZVDW4QdwKSczjYNC8balgOVp1wp6r22dFa4Q7UpxD3LeVMmus8kK9K8/qSopj slvP/jh2O31WQJXPZ82+XBd2rCWw1oqdNpE80nOoxAqsmznhcOfMDJZn4eqMpaoDfdVHsT 6ygPu2ioHe0PH+DlP0ZWgdxrVjPs3e0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-300-Ea8XHLUUOFaYoloJnpddTQ-1; Mon, 26 Jan 2026 07:13:34 -0500 X-MC-Unique: Ea8XHLUUOFaYoloJnpddTQ-1 X-Mimecast-MFC-AGG-ID: Ea8XHLUUOFaYoloJnpddTQ_1769429613 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4803a72daaeso33695845e9.0 for ; Mon, 26 Jan 2026 04:13:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769429613; x=1770034413; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7bxbDiXE7aJstJGhBu6HYzE7kbQ9hprTW9KE74xy9Ns=; b=H0YFuMeGC9Ax05EoojrFCuFYOlCfFbIIXberXGIXiUu1XgazRTMKPJfqvy8bnjO/z8 J5oEbGjVKi5SLD75kW6i03jotfGEPzOU5mtVLzG/8i8QupztdqLgQiWWT9Vtkd2n8FBF D0DBlnNnF9u2SQdeG3VxChhZL2ZVvApJeQDIlyB8QizSM5QOrvximrRHPG0fFj5WbRdD rIOsM1DZ14WSY2D9ieavc8QqNGHUMgil4oaLGZEqcsL4fFeqZNLhhBKdAD+7pZWfXub1 tc0hdLdl7mQxBZqOqP3egPDKV4U7IQQkYF5ETFlfYFbI05zRDV7z0Pi5xAus2z1aMl5r wKrg== X-Forwarded-Encrypted: i=1; AJvYcCVw7aaICuAhjVTU/2vizELrmN869jcrLiXVG2BqdgI/brIbcLsStrUZ6u0AyJY/+HDohQVkjraxEy8=@passt.top X-Gm-Message-State: AOJu0YyOcIROHxNrg5H2d71m6B/utmIVi61HEJMKGvu9v76zizMgZJYP uU7wrNMfnjtUyDyijTfWJJcumFL31UC/x142SCPjlAZKgnt/rSdBwBnjy+MFxRYCKOg8MqqXixm wNFpE+ENKItpQEbnoe+/Fuw7jobIS+PsQAISztIuLA6/Kqjj00WHSRg== X-Gm-Gg: AZuq6aLryGI70cTj/6iQkX5EX+vahdRm2OnIm5sFqM4d6FF+IaiVeiaY5M+7VkpEFQQ lPZ4Q+osi2N04EItCrSIsHLtk85fr+dxRCUTbMA3P4kw0cVigNQaceBM91sZzHC/KmR8+3ATudA fAVzLMb2wy9pzEs0jVUyivA2ZCgQ2Uve9t4A9yFQq+IK5oyv8OZ/4glcYewa5ZUODAepXxD3S4q QnPDBPxp6LyAKwCk/6tFuPIHr2uj1VYFf+Q3lxHh/EcRgz9VoWtwLYTcmB5rlV6hf+ik8xzXuAj oJUUsq/mo0fs5Crxwu3j5D0pYzzViqFvmGKEedxlqMGrlv3Sf7JFQsqnduOzg/tFTA98E3a5YZv S/C0O2CXr3c1Orxwf4PiAmtXjdmNMfMkohURh4VBD8oZQNWAT X-Received: by 2002:a05:600c:364b:b0:477:9a61:fd06 with SMTP id 5b1f17b1804b1-4805cd1c1c0mr54218575e9.8.1769429613423; Mon, 26 Jan 2026 04:13:33 -0800 (PST) X-Received: by 2002:a05:600c:364b:b0:477:9a61:fd06 with SMTP id 5b1f17b1804b1-4805cd1c1c0mr54218405e9.8.1769429612925; Mon, 26 Jan 2026 04:13:32 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1c24f15sm30245966f8f.18.2026.01.26.04.13.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 04:13:32 -0800 (PST) Message-ID: <2c2f35f3-1cd4-4c1a-a39a-487bd1732679@redhat.com> Date: Mon, 26 Jan 2026 13:13:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tcp: Add error checking for flow_epoll_set() in tcp_flow_migrate_target() To: Stefano Brivio , passt-dev@passt.top References: <20260122141319.3054301-1-sbrivio@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260122141319.3054301-1-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vYiBqzAhK1IsDml-4DClcfnsSqbrmGNi7cP40E4U4dw_1769429613 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: WJVL5PQW4GWEIVCCMPDZRC65HMG3M36H X-Message-ID-Hash: WJVL5PQW4GWEIVCCMPDZRC65HMG3M36H X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 1/22/26 15:13, Stefano Brivio wrote: > Commit 90287c2a774e ("tcp: Register fds with epoll at flow creation") > added a call to flow_epoll_set() in tcp_flow_migrate_target() without > checking for the error code. > > As Laurent explains, that's harmless, as tcp_flow_migrate_target_ext() > will clean up the flow anyway, and we'll just uselessly call > flow_hash_insert() before removing it again. > > But Coverity Scan complains about the unchecked return code, so check > it, skip flow_hash_insert() in that case, and explain in comments why > we don't have to do anything else. > > Signed-off-by: Stefano Brivio > --- > tcp.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/tcp.c b/tcp.c > index 6a26826..0a6b7ff 100644 > --- a/tcp.c > +++ b/tcp.c > @@ -3684,17 +3684,19 @@ int tcp_flow_migrate_target(struct ctx *c, int fd) > > if ((rc = tcp_flow_repair_socket(c, conn))) { > flow_err(flow, "Can't set up socket: %s, drop", strerror_(-rc)); > - /* Can't leave the flow in an incomplete state */ > - FLOW_ACTIVATE(conn); > - return 0; > + goto out; > } > > flow_epollid_set(&conn->f, EPOLLFD_ID_DEFAULT); > - flow_epoll_set(&conn->f, EPOLL_CTL_ADD, 0, conn->sock, !TAPSIDE(conn)); > + if (flow_epoll_set(&conn->f, EPOLL_CTL_ADD, 0, conn->sock, > + !TAPSIDE(conn))) > + goto out; /* tcp_flow_migrate_target_ext() will clean this up */ > > flow_hash_insert(c, TAP_SIDX(conn)); > - FLOW_ACTIVATE(conn); > > +out: > + /* Never leave the flow in an incomplete state */ > + FLOW_ACTIVATE(conn); > return 0; > } > Reviewed-by: Laurent Vivier