From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OXc9Mke1; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 9CA8F5A0652 for ; Tue, 06 Jan 2026 15:07:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767708451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XDrs9YSDXkuT+85jjPcDBbaNf0jWNkucfR+4NkjtBK4=; b=OXc9Mke1K83V4VAdNDT+mS2kzn2mqdpIrQSkz+Zyj1cE8YPhbO66ON6vrKH3Cx+ZSSifen bJP10VNRABxl1RXiypuPZmKChFmJBSvBdqvnrbkmNeqU6vUBV+5VuQUwyX/49f/GQ5ypDA FzDBpeyLgVIAk7I36gU/0b88akwWAb0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-l-5KzfIRMcC-wFVoFOTiuQ-1; Tue, 06 Jan 2026 09:07:28 -0500 X-MC-Unique: l-5KzfIRMcC-wFVoFOTiuQ-1 X-Mimecast-MFC-AGG-ID: l-5KzfIRMcC-wFVoFOTiuQ_1767708448 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-432c05971c6so323748f8f.1 for ; Tue, 06 Jan 2026 06:07:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767708447; x=1768313247; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XDrs9YSDXkuT+85jjPcDBbaNf0jWNkucfR+4NkjtBK4=; b=YUMd5RmaYc3N34GjJE4VGGkX4AFQNfat7p0Ct1e0zJWASEnHcdZOQel98PiUQAFWhX uAjfOqkN+BdhnQftDn9cc/Nh18dIIb5e62k6fhqHRDUHPVz9WcnPBUifO/cteeW4bJ0/ LOansVe6c3IK6fwVhsZlH7/dLK+wVOhh4+xIcxZ0HxVicmY4xmpKCWTHAWsHAGLY8UIb FgK/KqIjn5G1h2uv6db48xATtXFz+FFwTOFbZWS/ec7Tw2joeApR9frEfzNTE/TV4q6c PuruDRp3nB0uk11U5O43E1UMNGxeTvf8KLm8p/wUMDYRIOVibsI3tkYCYLm2s3Da034h w4sQ== X-Forwarded-Encrypted: i=1; AJvYcCUg9Bit1sXfkF9jSEh7tLeSsHOULeeJ49z57cVUm/DwH/c8iuTT5E3eCnsrXMy88qllPc7iRaTzOsU=@passt.top X-Gm-Message-State: AOJu0Ywv7i3xjMMpnMMOcg3o8qCK3vwVuX/cQM2r+SdxQh2KfuOSRk89 WIwyPjy8PAs/ruX7VPLOWVZ8qiSBezIqhFuLLgWfcPhGtyrdSPXl+bVvCZQFCyPX55BFRdQ3EgB H13NtpbL/A9b2fZtEWt2qgmJUUEY2zgENkhUXmg3m0VvV9+wXloGjMw== X-Gm-Gg: AY/fxX5RTW5p1tUKlPDSlwgVZMA+fkrMrmmqxIPYGuOWsZKZYWMWHDoIKigjgu1gflB Z5p66oWmx9PGUl5Z82A2v3AtDeowvpaZxCk7sMsRGS/fbOFDok517h3DJj6LV+dxartr7DlXy+b cP8f3MYgX3QNFO86i2kyvfVbpJH7U01fB5lUPpWQoUZWrIDWiDMaLhWYRsFNBo0OmqZrxFo9eU6 bmX8xGetlbWRs1HZIO/rQu4bmuDynLVCZg/b4qRMeVpVStBQzTv/btsJZ+Zf51qQnG961mBu/np smCT5fZLEq41vlyHgHoqYEDnlvEqm0jeRhx0Iexux2GTVfc3/NrRWqdWg9MUorJu1EdiTOWBI0u bOXjBo0hZ/tg/53slJE4i5Ljv9huhraFA/TgYfSDCzlTRSi9f X-Received: by 2002:a05:6000:40dd:b0:431:771:a50c with SMTP id ffacd0b85a97d-432bcf99f09mr3394894f8f.1.1767708447564; Tue, 06 Jan 2026 06:07:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IFT0yRcKdRVLDQeqdDGhmI3oRBeD5aoLklcBzEu2vhYqyIjHAMWhHNQG9WkPace3jlfRJ7vmA== X-Received: by 2002:a05:6000:40dd:b0:431:771:a50c with SMTP id ffacd0b85a97d-432bcf99f09mr3394858f8f.1.1767708447176; Tue, 06 Jan 2026 06:07:27 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0dad8bsm4687288f8f.8.2026.01.06.06.07.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 06:07:26 -0800 (PST) Message-ID: <3004f23d-6075-4fed-9ec1-35cd5a0a1a40@redhat.com> Date: Tue, 6 Jan 2026 15:07:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] test: Handle Operating System Command escapes in terminal output To: David Gibson , passt-dev@passt.top, Stefano Brivio References: <20260105075337.1724962-1-david@gibson.dropbear.id.au> <20260105075337.1724962-5-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260105075337.1724962-5-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AP7H9iRDA0ODMUa4MCT3Z0F7SGj12Z7Ubln7V9orwAU_1767708448 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 5WRPJEF7ZJPM4SXW4UUUKLEAAFJDZELK X-Message-ID-Hash: 5WRPJEF7ZJPM4SXW4UUUKLEAAFJDZELK X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 1/5/26 08:53, David Gibson wrote: > Our "old style" test script stuff uses raw terminal output scraped from > tmux. This might include terminal escape sequences from the shell, or > whatever we run in it: they think they're talking to a terminal emulator > not a script, and they're not entirely incorrect. > > In several places we filter out ANSI ESC-[ sequences to make this work. > However, this doesn't include ESC-] "Operating System Command" sequences. > Something I've updated in Fedora 43 generates heaps of these, which break > everything. > > Add more hairy regexps to filter these out as well. > > Signed-off-by: David Gibson > --- > test/lib/term | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/test/lib/term b/test/lib/term > index f596364c..89e4fdbe 100755 > --- a/test/lib/term > +++ b/test/lib/term > @@ -203,7 +203,7 @@ pane_wait() { > > __done=0 > while > - __l="$(tail -1 ${LOGDIR}/pane_${__lc}.log | sed 's/[[][^a-zA-Z]*[a-zA-Z]//g')" > + __l="$(tail -1 ${LOGDIR}/pane_${__lc}.log | sed 's/[[][^a-zA-Z]*[a-zA-Z]//g;s/[]][^]*[\]//g')" > case ${__l} in > *"$ " | *"# ") return ;; > esac > @@ -215,7 +215,7 @@ pane_wait() { > pane_parse() { > __pane_lc="$(echo "${1}" | tr [A-Z] [a-z])" > > - __buf="$(tail -n2 ${LOGDIR}/pane_${__pane_lc}.log | head -n1 | sed 's/^[^\r]*\r\([^\r]\)/\1/' | tr -d '\r\n')" > + __buf="$(tail -n2 ${LOGDIR}/pane_${__pane_lc}.log | head -n1 | sed 's/^[^\r]*\r\([^\r]\)/\1/;s/[]][^]*[\]//g' | tr -d '\r\n')" > > [ "# $(eval printf '%s' \"\$${1}_LAST_CMD\")" != "${__buf}" ] && \ > [ "$ $(eval printf '%s' \"\$${1}_LAST_CMD\")" != "${__buf}" ] && Reviewed-by: Laurent Vivier