From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=InMkf7j5; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 374245A026F for ; Tue, 04 Nov 2025 16:32:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762270322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Bv8n0teWPSbVya8yN1hJDJCHFg/DK9jt0PAqWhJbPDY=; b=InMkf7j5eoeVSkg/Yo2hokYNhFZ4Zy9j1+s6YBdZyp9D3z29vzjnuHVFxPhD6bpGxZG/+O n3luQZMu+VYACzpIbYM3gKizt15pNksv0YQU9D4S4Jzm4MasQ4c3apQgB+Cpw7KEmWoKu0 jkeqeH5ss3F+bcotkGd1u2oZ3mmYZVc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-UgglRgHpMhCF__Zud3BJbQ-1; Tue, 04 Nov 2025 10:32:00 -0500 X-MC-Unique: UgglRgHpMhCF__Zud3BJbQ-1 X-Mimecast-MFC-AGG-ID: UgglRgHpMhCF__Zud3BJbQ_1762270319 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-428567f67c5so2781728f8f.2 for ; Tue, 04 Nov 2025 07:32:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762270319; x=1762875119; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bv8n0teWPSbVya8yN1hJDJCHFg/DK9jt0PAqWhJbPDY=; b=WpiiNXDnl+Dvi9cWjYXg1ZKCXHqxt2MBSy/8TpBlvatTBUK2C7ANF5wCScPCTbBqMc ocgcY0St8ZKOxeiEXi8lTBFWvch8DX9c26Q4S7yL0/Freyk+t7sZwYN3FVXsAjeZp/e/ egae6e0jl+xr4lqRmYjNi6Xm1gLnd75ZufAB2nnZ7xChB97fkvP8aDVzw+YF41fFD4vE GTngxdkHhLpInnwXTFkD7j/rpFAs0aSq8oXnCfOwa0MeUwEbXaOsyh7+zFtfGXK2FWEI BE+fDFHBWOQsAtxg7m9wtGyILYi+hb9cIvsTz0vDnvixZ0MAA3X8pTmeIeImnfmV2Hqx IjPQ== X-Forwarded-Encrypted: i=1; AJvYcCX5kTjaoGyVMygMfNKnatb2n0Jq6pWatujeyHR3k0y3yBgIOyk25lzrtlUp9Ui3QTKrbvZP4ravuA8=@passt.top X-Gm-Message-State: AOJu0YxLJxut3cwHIQM+oHzJlbUqAOjaFkq1pEed0w4nN9sTXZSUKluR hzHyCvnGNCnhFacCRbcMuxjfT/xfPg7h2q9ln+/OpHvBmK0tV3FDZfflQUjQAqrzGHmUWgrCgOA hmiAOxVEAFWZudZfScmzqrQRnPh0V+Onmz5TjKJnzXqKqtjoA/opOi3Rkh2UAeya+ X-Gm-Gg: ASbGncsNMyQCtSJXAmtlmVv/rMTUq+NaFRWWwv3PBP0FdZmEBtwecg2grxIfT7gxbEo 04agmRol0EnNOwIPh9uUxSy7464gULbnVo0/g7mg28RtRupgF0wD7e+vJAE2Zaa3wSaPlnQUJeS FqHEpb+t36drU4NYcEh2qZOd6ji5f2P0/xVsXEo5CL8BhKmezXTJkqstbm2wS2gODMCc3acY7Cr nygQwoTZRbQcyzE8Z2Vm7o/Hst03cA4nQGf2FhwDNHT1j5jX9vkb5F75uHZt5y875/m1snWFKFK vYPe3OWxOeDmHRavs4qf3DpX6d8LqCrcb2EjM1TxrcGqLF2AoceZE38QwIHIJ62001QPcCbeaq5 /YmfRjdx9WHzNyrSJuKE2pQMneoKd20qPT5fpNA== X-Received: by 2002:a05:6000:2207:b0:428:3ef4:9a10 with SMTP id ffacd0b85a97d-429bd6e16a8mr14270965f8f.54.1762270319187; Tue, 04 Nov 2025 07:31:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IGL0zbtfT3WDdNG2OfXhNQ23ERN29sktPmFw3UIJv0R6wTID0WmiIopRxgAnC0JyKaBhAcWFw== X-Received: by 2002:a05:6000:2207:b0:428:3ef4:9a10 with SMTP id ffacd0b85a97d-429bd6e16a8mr14270939f8f.54.1762270318786; Tue, 04 Nov 2025 07:31:58 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429dc1f9c7esm4869190f8f.35.2025.11.04.07.31.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Nov 2025 07:31:58 -0800 (PST) Message-ID: <31409c6c-2fc8-4866-814a-b1539d483a84@redhat.com> Date: Tue, 4 Nov 2025 16:31:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 4/5] tcp, udp: Pad batched frames to 60 bytes (802.3 minimum) in non-vhost-user modes To: Stefano Brivio , passt-dev@passt.top References: <20251103101612.1412079-1-sbrivio@redhat.com> <20251103101612.1412079-5-sbrivio@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20251103101612.1412079-5-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HkNKAg3TGzkoUOBaLqQaFB4ndcZd2PN1RTmbGagWSY0_1762270319 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: J5TKF4Q6FHDJTYAM35N2HSBQ55BSPKCK X-Message-ID-Hash: J5TKF4Q6FHDJTYAM35N2HSBQ55BSPKCK X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/3/25 11:16, Stefano Brivio wrote: > Add a further iovec frame part, TCP_IOV_ETH_PAD for TCP and > UDP_IOV_ETH_PAD for UDP, after the payload, make that point to a > zero-filled buffer, and send out a part of it if needed to reach > the minimum frame length given by 802.3, that is, 60 bytes altogether. > > The frames we might need to pad are IPv4 only (the IPv6 header is > larger), and are typically TCP ACK segments but can also be small > data segments or datagrams. > > Link: https://bugs.passt.top/show_bug.cgi?id=166 > Signed-off-by: Stefano Brivio > --- > tcp_buf.c | 23 +++++++++++++++++++++++ > tcp_internal.h | 2 ++ > udp.c | 21 +++++++++++++++++++++ > util.c | 3 +++ > util.h | 3 +++ > 5 files changed, 52 insertions(+) > Reviewed-by: Laurent Vivier