From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Yc72SX3G; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id ED4225A061C for ; Fri, 17 Jan 2025 13:13:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737116021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hC+/Lq/BjbCPT3by4CnlmrNKEzPCu4LsJOdAH62S63w=; b=Yc72SX3GGbPtHZOmUOh79G0cez2MbwvvH2kfn/d4cJN7USVSoiTE038ODf9k0MHmcN3rsu /Eyu6QcPOpK7Yp5+Di9TLZUc1KRzt6jAuv26GhH7wYC1rnmXQ/veYuvld8SrfYt5POR68A k/165ClIe8TbsEsp7IjhR1VmJF5Ax7Q= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-co6P0pTSOemrGhPP9JalxA-1; Fri, 17 Jan 2025 07:13:40 -0500 X-MC-Unique: co6P0pTSOemrGhPP9JalxA-1 X-Mimecast-MFC-AGG-ID: co6P0pTSOemrGhPP9JalxA Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4361c040ba8so10595895e9.1 for ; Fri, 17 Jan 2025 04:13:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737116018; x=1737720818; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hC+/Lq/BjbCPT3by4CnlmrNKEzPCu4LsJOdAH62S63w=; b=VD52DWLMS4eoEnAS0XGRsvP0oedlUlLsOkVMLaMcwAoXUiW29Fa1SzDVGrGQvYH4he w9QL47ySsLal3MMrq3/l5h4ONLHfm5MdgI1cpjccErIhG8mv2USB4rEnpMklHnrfhlnu ghWE6LVTB7hVymm7CXw++E6l+b1QC0ew5sKUk3kTYTrEYT+LX+QL9/9xKQa3ylWYcjvf sRH18I6v2Y3fRc8SfntQUtHxQ4RZoFV2f9hiaT3DKFZb8xQkiRWfBXPmJXPXlmOHSUo0 8J3UcPFZ3rpeJDKH23FSdS8AHugzhX23nIoWezxAJ+Y/RczsGX1GeCeKHuEIqE3dPSLK Njag== X-Gm-Message-State: AOJu0Yyw8t2VwIfe3NtP4xDoSSH2xfztICrFHg4c5pceU61Ysa3nGBgt DV44V9kHaxi/ouaQR/RcMNvwcTWzZ880QfZgDQmpAfvVAwSOWK9E5m1P1V+Fl32oUOOu6w9u7GL ESPaWixTTmEgUg0OM+E13mo72tanhVJFt0JtghrU/PgT1qsDD8vldaldpMCiFMoczWdEPsC1AFO XSUqjv83KeTSa1XNcF8YGBQ7eyMnG1wwXj X-Gm-Gg: ASbGncts72tMAGOhvDrR6ARvPHzfWTgSBG5Jd7KrASJT772XzLMP5NBNcqDOiI43MRS U525YNg8G2ScI2GG92d+uozXxtBtibds+lQTzF0tubD9YA0giMH9/ooWRDN7t6kwkdLTsA1SFsk Ysl9KIGh8BYOgHzm4fUSB13vkXSdtcdq3V7bMpqEzn6CvthTcVGzZdmpqd41/KFSwBPgTCl0Pz3 XGejG1j3+W15ttkVumO1tQ9CmDwRG8vgKKvQRZjSszxRf8Y5fO7h5u9xz3C2BY6NMDTgw0KV8lb 5kE31fpn4w5kW/9Qcg0= X-Received: by 2002:a05:600c:4e0b:b0:434:a525:7257 with SMTP id 5b1f17b1804b1-43891433febmr20127185e9.21.1737116018574; Fri, 17 Jan 2025 04:13:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IFG7ekDOaSf03X2SQ2YbDfeS6Z+IFH7kor0w7tiCRiE6Mcd4HuFkTYD51P6hboOXSe7yQpsLQ== X-Received: by 2002:a05:600c:4e0b:b0:434:a525:7257 with SMTP id 5b1f17b1804b1-43891433febmr20126905e9.21.1737116018063; Fri, 17 Jan 2025 04:13:38 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf32755b3sm2448688f8f.63.2025.01.17.04.13.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2025 04:13:37 -0800 (PST) Message-ID: <329e349d-f86c-479b-97ee-61397aa28c60@redhat.com> Date: Fri, 17 Jan 2025 13:13:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/9] vhost-user: Migration support To: passt-dev@passt.top References: <20241219111400.2352110-1-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20241219111400.2352110-1-lvivier@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: b3uZXidc1QFRp4ReaiPt0XXtdfQkBsjaEv83izTmo5k_1737116019 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: TBOCRXHJHMVUCFITA525UINE5CK2QNKA X-Message-ID-Hash: TBOCRXHJHMVUCFITA525UINE5CK2QNKA X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 19/12/2024 12:13, Laurent Vivier wrote: > This series allows a QEMU guest to be migrated while it is connected > to Passt using vhost-user interface. > > There are two parts: > > - first part enables the migration of QEMU without transferring the > internal state of Passt. All connections are lost. > > This is done by implementing VHOST_USER_SET_LOG_FD and > VHOST_USER_SET_LOG_BASE commands (and enabling > VHOST_USER_PROTOCOL_F_LOG_SHMFD feature) > > "vhost-user: add VHOST_USER_SET_LOG_FD command" > "vhost-user: add VHOST_USER_SET_LOG_BASE command" > "vhost-user: Report to front-end we support VHOST_USER_PROTOCOL_F_LOG_SHMFD" > > - second part allows source Passt instance to send its internal > state using QEMU migration channel to destination Passt instance. > > This is done implementing VHOST_USER_SET_DEVICE_STATE_FD and > VHOST_USER_CHECK_DEVICE_STATE (and enabling > VHOST_USER_PROTOCOL_F_DEVICE_STATE feature). > > "vhost-user: add VHOST_USER_CHECK_DEVICE_STATE command" > "vhost-user: add VHOST_USER_SET_DEVICE_STATE_FD command" > "vhost-user: Report to front-end we support VHOST_USER_PROTOCOL_F_DEVICE_STATE" > > For now, it only implements the function needed to transfer the > state but no state is transferred. > > VHOST_USER_PROTOCOL_F_DEVICE_STATE is implemented in QEMU > only for vhost-user-fs, to be able to use it with virtio-net > I have proposed a patch upstream: > > https://patchew.org/QEMU/20241218143453.1573185-1-lvivier@redhat.com/ > > Laurent Vivier (9): > virtio: Use const pointer for vu_dev > vhost-user: update protocol features and commands list > vhost-user: add VHOST_USER_SET_LOG_FD command > vhost-user: Pass vu_dev to more virtio functions > vhost-user: add VHOST_USER_SET_LOG_BASE command > vhost-user: Report to front-end we support > VHOST_USER_PROTOCOL_F_LOG_SHMFD > vhost-user: add VHOST_USER_CHECK_DEVICE_STATE command > vhost-user: add VHOST_USER_SET_DEVICE_STATE_FD command > vhost-user: Report to front-end we support > VHOST_USER_PROTOCOL_F_DEVICE_STATE > > epoll_type.h | 2 + > passt.c | 4 + > util.h | 3 + > vhost_user.c | 251 ++++++++++++++++++++++++++++++++++++++++++++++++++- > vhost_user.h | 50 +++++++++- > virtio.c | 116 +++++++++++++++++++++--- > virtio.h | 32 +++++-- > vu_common.c | 59 +++++++++++- > vu_common.h | 3 +- > 9 files changed, 484 insertions(+), 36 deletions(-) > Another point: vhost-user can ask backend (passt) to send a notification at the end of the migration on the destination side to the network to update the network topology. Do we need this? This is VHOST_USER_SEND_RARP: "Ask vhost user back-end to broadcast a fake RARP to notify the migration is terminated for guest that does not support GUEST_ANNOUNCE. Only legal if feature bit VHOST_USER_F_PROTOCOL_FEATURES is present in VHOST_USER_GET_FEATURES and protocol feature bit VHOST_USER_PROTOCOL_F_RARP is present in VHOST_USER_GET_PROTOCOL_FEATURES. The first 6 bytes of the payload contain the mac address of the guest to allow the vhost user back-end to construct and broadcast the fake RARP." GUEST_ANNOUNCE is a feature that allows vhost-user to ask the kernel to send the notification itself at the end of the migration. Thanks, Laurent