From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YLdAJGJT; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id B63AF5A004C for ; Wed, 28 Aug 2024 12:03:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724839396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JqTX9kbNIHndlUvMhJGojAbjjbYaRZv/Fx1AvUQPIZk=; b=YLdAJGJTOnYBNN3Uce2OtVoEDGZdq4AB5FuzdIW590m7yyfSVa2Fua11zsz8j48ACraBM5 /bnS4YoEsboKxPlVniSLeIUdgVgiAJZEFQkIwt3UISr35YYrSkPJTOX4eNBsqeaR0/QC6f jjZ7COp4TVHUf5k5HS9XTVEb7Z0PpDg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-hV5Igfn1PrStpPQsp849og-1; Wed, 28 Aug 2024 06:03:15 -0400 X-MC-Unique: hV5Igfn1PrStpPQsp849og-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37189fa7ad6so4709203f8f.0 for ; Wed, 28 Aug 2024 03:03:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724839394; x=1725444194; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JqTX9kbNIHndlUvMhJGojAbjjbYaRZv/Fx1AvUQPIZk=; b=jZWRe+qj67xznM/8fG3vLuFZYHSguhysZSwso0GtUZ8ygP4pvYcXnS4tHkIzD3d89M xnPzJQqZtIkcTuFDvcXiFv/UY4tlYaSyzSed64pfT3ze6jGbdo9awHOWAg+MHFAnWjcr EQ1glKuKUE5he9EpF7MzTDDDRQE9pWJCcsb3puarzm/GdcARYe2o7zzI+Jg23IMUbyNG 4UCanBEVuO4L9JU84nFCrn/p0Wxmz62746fb9qidby/hWuVdXNnJSeLk8F1YK4BbO1Yc f1g/DplwljQwOujJ9IdWDXHbqzYo1Une3cjmNGqe9FhO3dAmZ/pxTZbi7SdiGO595fb+ yDgg== X-Forwarded-Encrypted: i=1; AJvYcCUb767B/HUqFiIihxzDku5mFdMafLYoqG/9bHD75Kl2/Fv8w5sJEWF+o+4xn7eE3HsxCwbcrzvFFHQ=@passt.top X-Gm-Message-State: AOJu0Yw7UjAlmSR71pbqrnIJsOKE6GWIXI8yZ4yeclporQXW+77w1MT9 OokZ6sHRidBJpQUy1mOooTL3fS6+l2S/jhy3OULS9wfUjg0oCZScJoNDVLaK/IO43XW2X1Eyttu Gt6h+EwJr/eD6orcc1JRNNinSWEE4O1VQhCTgsEVuSck+hLm7Fg== X-Received: by 2002:adf:b311:0:b0:368:3f6a:1dea with SMTP id ffacd0b85a97d-37311840050mr12379025f8f.6.1724839393958; Wed, 28 Aug 2024 03:03:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjEQMELogKcIcVPeLZ66LmmugLEzQZwEVPAuJaj3deOkjpIx3UCpPErg4AZo6zexNTMv8VHQ== X-Received: by 2002:adf:b311:0:b0:368:3f6a:1dea with SMTP id ffacd0b85a97d-37311840050mr12378992f8f.6.1724839393325; Wed, 28 Aug 2024 03:03:13 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78? ([2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ba61c0666sm16883725e9.0.2024.08.28.03.03.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Aug 2024 03:03:12 -0700 (PDT) Message-ID: <392bed8f-d3b8-4d50-8c29-d0e21449572a@redhat.com> Date: Wed, 28 Aug 2024 12:03:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] conf, fwd: Don't attempt to forward port 0 To: David Gibson , passt-dev@passt.top, Stefano Brivio References: <20240828055610.3241117-1-david@gibson.dropbear.id.au> <20240828055610.3241117-3-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20240828055610.3241117-3-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: XVEN444M5XKKO4P4JXVXTRUUC56E4A4X X-Message-ID-Hash: XVEN444M5XKKO4P4JXVXTRUUC56E4A4X X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 28/08/2024 07:56, David Gibson wrote: > When using -t all, -u all or exclude-only ranges, we'll attempt to forward > all non-ephemeral port numbers, including port 0. However, this won't work > as intended: bind() treats a zero port not as literal port 0, but as > "pick a port for me". Because of the special meaning of port 0, we mostly > outright exclude it in our handling. > > Do the same for setting up forwards, not attempting to forward for port 0. > > Signed-off-by: David Gibson > --- > conf.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/conf.c b/conf.c > index 6b3dafd5..3eb117ff 100644 > --- a/conf.c > +++ b/conf.c > @@ -157,7 +157,10 @@ static void conf_ports(const struct ctx *c, char optname, const char *optarg, > > fwd->mode = FWD_ALL; > > - for (i = 0; i < NUM_PORTS; i++) { > + /* Skip port 0. It has special meaning for many socket APIs, so > + * trying to bind it is not really safe. > + */ > + for (i = 1; i < NUM_PORTS; i++) { > if (fwd_port_is_ephemeral(i)) > continue; > > @@ -262,7 +265,10 @@ static void conf_ports(const struct ctx *c, char optname, const char *optarg, > } while ((p = next_chunk(p, ','))); > > if (exclude_only) { > - for (i = 0; i < NUM_PORTS; i++) { > + /* Skip port 0. It has special meaning for many socket APIs, so > + * trying to bind it is not really safe. > + */ > + for (i = 1; i < NUM_PORTS; i++) { > if (fwd_port_is_ephemeral(i) || > bitmap_isset(exclude, i)) > continue; Reviewed-by: Laurent Vivier