From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=B5ncnVb1; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 773E55A026F for ; Sun, 05 Oct 2025 15:39:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759671581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O3cKo2QMnSgUQ9Z3FksbBmRFmTeWtVPO3SgJIFlChEA=; b=B5ncnVb1Bv64aIAoHWmI8LKodZHzn8Q/GVS6jiahJvmjM5yCqqR9PvFUz6bvDAlMEDXXPs GXG2eFI+0uy5EbStNIr3Uuj/Qg4GYFksBofDuwFnanL/Wbtb9nqWHrdns61vJHz3BN70qy SiBVN6bu1ZVN88bdP8AsH1Nvi6KUqjA= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-264-Ma-ZB7p0NK2KjS7JHdAYFQ-1; Sun, 05 Oct 2025 09:39:39 -0400 X-MC-Unique: Ma-ZB7p0NK2KjS7JHdAYFQ-1 X-Mimecast-MFC-AGG-ID: Ma-ZB7p0NK2KjS7JHdAYFQ_1759671579 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-871614ad3efso784143885a.0 for ; Sun, 05 Oct 2025 06:39:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759671579; x=1760276379; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O3cKo2QMnSgUQ9Z3FksbBmRFmTeWtVPO3SgJIFlChEA=; b=FtQEDacDVG4p9t57/HnBwgpgRGGj3vw4a4cieEL5BYvdZ9VWHnmotUsKw84mkmrK+G GQJFefOIhN9fnv1329KYe3FJgiMM0wTgITK+HTGBwzu/z8sB3FZpaHyOiSsbByVkA+eS /UFzmbBx2DrfF0VSFMnof/eR3Qdcrfh+9n8/Vj0iJGzXclStYGO+X9m3zRiYtgXOVQ37 rIHgwr9x4loLIdApCKo9UxumGI5+Zel6HN3co3vJ/LmWLdlswHZHCzEl/IjhvR2ieRyC 1fbJZW0Zem4FqWEbcSalY9pdNY8OdZ0x9UmFTcbeB40H2y8AyBODVvUjvZKaVjd+VSbt VTsA== X-Forwarded-Encrypted: i=1; AJvYcCV5Kv3YXGResH0sv88Lj7Vs7PrX6fu4wfU7+d+mP2fn166mI8qR9E89cW9RZ+fn9FR/SIFXSC8Eel0=@passt.top X-Gm-Message-State: AOJu0YxOnAUJANUnXdGyTDMUD6ltdGyqCeu3Fc5SSxUGDPMDPumjxmfC LQ2/O30bOmtgfS8dTMFJLjQglAbKHEB8xI7nSIWt91tAkDXn23Rw4pXKBkBcD8eg32ElbTYWlEo yNFm+5JN+iiOTBFk7SoYpwz4PmtizDYQ7oQxyKZpD2RcNPp68ftJdeg== X-Gm-Gg: ASbGncvP/FPKG4KnQVuUSi1L+Wkxkdolar0G35FqVBCqtv8lYXT0J8xuUXzFnSEW798 R8toWIrdKkgGsKiHAs+E2caoOtnUBGFL4CQtwchydVrIomdvd00oG9BfrDVqvKAp0sgXDstsoaB EJnmS7bIeWG7Dd0L6NqJxa4kWo8lCxghJdPdpmGIa5gOt1D0FJ2tQx7MncXlNwq5P4KcPzgw85M d5lYXhblnTM9S1R7usehDSfgEMTlxzJuKaxZI65fgFVRZIMa9Fb2UdKwxaEIagz5OsPBUFQHuXP 2q9jwy9Ct/thVE2UrmTFAgkVimv39ze4JqBCaUlmE1v23rfFuH6Bpa4G515BQCtgkb+h6/St/KO ZU7/YV0zXDW0oUwI= X-Received: by 2002:a05:620a:269a:b0:861:27a4:5bd3 with SMTP id af79cd13be357-87a3b1c6f08mr1196055985a.64.1759671579235; Sun, 05 Oct 2025 06:39:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpp9iZgHY4TlddclEr6XD2N9me0NwKAhonG6tRp4Gv5D7jd2Rmz2qZ7t7NlckPVS3Tt6d/XQ== X-Received: by 2002:a05:620a:269a:b0:861:27a4:5bd3 with SMTP id af79cd13be357-87a3b1c6f08mr1196053585a.64.1759671578648; Sun, 05 Oct 2025 06:39:38 -0700 (PDT) Received: from ?IPV6:2001:4958:2193:9901:6217:960c:2ef1:f0f3? ([2001:4958:2193:9901:6217:960c:2ef1:f0f3]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4e5579d6f35sm92064661cf.0.2025.10.05.06.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Oct 2025 06:39:38 -0700 (PDT) Message-ID: <3adef423-c353-43db-947d-fa76f9224d06@redhat.com> Date: Sun, 5 Oct 2025 09:39:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 0/9] Use true MAC address of LAN local remote hosts To: David Gibson References: <20251003003412.588801-1-jmaloy@redhat.com> From: Jon Maloy In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dIRzmz9Y2M5P9TnvkcwBLltAbKTT61JYN4M99qPQkbE_1759671579 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: UCGVCGZXPP55X3ZMOEYVBP3LBJMCENKS X-Message-ID-Hash: UCGVCGZXPP55X3ZMOEYVBP3LBJMCENKS X-MailFrom: jmaloy@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2025-10-03 01:33, David Gibson wrote: > On Thu, Oct 02, 2025 at 08:34:03PM -0400, Jon Maloy wrote: >> >> >> Bug #120 asks us to use the true MAC addresses of LAN local >> remote hosts, since some programs need this information. >> These commits introduces this for ARP, NDP, UDP, TCP and >> ICMP. > > I have a bunch of more detailed comments on the patches, but they're a > bit confused, because for the earlier ones I hadn't read the whole > series to get the whole context. > > There is a problem here in that you're not consistent about whether > the neighbour table is indexed by host side addresses or guest side > addresses. You'll mostly get away with this, because they're > usually the same. But it will result in bugs on the edge cases. > > Having read the whole series now, I think it will be simplest to > standardize on indexing by guest side addresses. That invalidates > some of my earlier comments, but instead you'll need to use > nat_inbound() when you populate the table from netlink updates. > I think I agree. After all this is all about what we are showing the guest in the form of IP and MAC addresses, so it is conceptually clearer. It doesn't change the implementation much, but it makes it easier to understand which special cases we need to consider. See my next email. ///jon