From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Do5M6AZ/; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id D559E5A0265 for ; Tue, 26 May 2026 18:14:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779812040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+v7oxb4QaLAAOWpz4MQGABwhaMVhWUjpj/OK/PspIDs=; b=Do5M6AZ/O67ri6Sk1SsMddOSsks3OccF3BCygiSJfnMDVodZgh2eokb+UXkuQrXw8wNjq9 Th12YGfrvnW+2zE8ujJlnKjDCqLD3X+Qh7nZUpm1wHx/AJN84cTLu+n6L5Wzx9EYqjHdMI gZECSn4LwrifVhLt9gKT3YAJLmlp3E4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-S0muaWMdNDSp2uXsuiMm0g-1; Tue, 26 May 2026 12:13:58 -0400 X-MC-Unique: S0muaWMdNDSp2uXsuiMm0g-1 X-Mimecast-MFC-AGG-ID: S0muaWMdNDSp2uXsuiMm0g_1779812037 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48fe44ce385so83583695e9.0 for ; Tue, 26 May 2026 09:13:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779812037; x=1780416837; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+v7oxb4QaLAAOWpz4MQGABwhaMVhWUjpj/OK/PspIDs=; b=q+7LLvHLXG+GuW8f4IOEgFL36qDM02kv3FjUOxI1dD5FZWNijvpxDFUg1U0qrE956c TunDINQRmkqAE6fjIsJxnPFjSPTYUh+ZCuLpYNvUZXdhPa2pzUNBPXvKjMxI7T9qd7Vn yGuCYcHPTUOEvh7IgGuKNVw9XsRK2BFgK2WbBfDNJFlyA6Lo69MSZZYmLkAsHMxFfIxa VTK2dh9bx3NVMdaOpB2PGEI7YK4Hf3jKYQgP9RhljrZuEgZzuLXTqgs4lmpEFVtAIAk4 kKZkhixKe3DDRL35lazr72KWy6OOTofSUWMjKXSkj3Xmb53AkyVB1dIjr71N4NFsR1KF tQVg== X-Forwarded-Encrypted: i=1; AFNElJ/BdMRkdI2RhEcZuuOXfXpdzFMqV2teKvkAwxyqrQpy+DsxkZ9ikDFNxvAYqDtHQsqnIcbDcfSrgno=@passt.top X-Gm-Message-State: AOJu0YwrKBtraNjFNrU50Nwgb6FSRu7r1OsAv2Nubb8FVhycet9j+/y2 +NDmNEp+EA8FVYFHH0oHBBCpchWVmOZaKfViDtG1UO5UDHYMokin3QWdAxsUvyJKY25yUZonx1F d67M0R4fYSRX7vY8kbFF3Zrxbxc+ZiBZl+ar6bc6ggvGpv56BbKGhPQ== X-Gm-Gg: Acq92OExsRIQvqmYEZNk4dVujmZNZtJ9fe6/KnOANicpaNNPoimZnrfdfvykatbTDLM WgX8hqI4irxdhHhwoIO5f0CC/Jr5RjMpk+ElpABneybKzaiRiMdCUKrv2tTQS2vToGBAwqbdTo4 Pnq/m1UBgtHLNgpY6rpggtp/eYuWJr+SUvmQDdwb48KN5SNT2fPxCjAJq7WT7meZH+2No+BqtZh cZUbvlUbN30CKRzX0PC0RdAq54m26ehnPEcg/FSffd4njxLXIdu0xm+5WHUY0sHP2Jr6Z3ryxnG OsYhzBHW530bc+eZ1QkL9GhrDnqHOdvvc+z4hqEDAf1aXqIcdIoUfzoVFYrIYt15Rx86gUuUPyE 7/hnyd+PxLL2NWTWC5y9oETz7sxZNrI958ysv5TG+bWo8JGMR6oUzXMI= X-Received: by 2002:a05:600c:4ecc:b0:48a:56de:d62a with SMTP id 5b1f17b1804b1-490424b3c7fmr291415745e9.11.1779812037041; Tue, 26 May 2026 09:13:57 -0700 (PDT) X-Received: by 2002:a05:600c:4ecc:b0:48a:56de:d62a with SMTP id 5b1f17b1804b1-490424b3c7fmr291414955e9.11.1779812036515; Tue, 26 May 2026 09:13:56 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490454dedd9sm307284695e9.6.2026.05.26.09.13.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 09:13:55 -0700 (PDT) Message-ID: <3b36426b-798c-489c-aad2-abcde13d2e93@redhat.com> Date: Tue, 26 May 2026 18:13:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] dhcp: Refactor fill_one() to operate on a generic buffer To: Anshu Kumari , passt-dev@passt.top, sbrivio@redhat.com References: <20260526123115.1226166-1-anskuma@redhat.com> <20260526123115.1226166-5-anskuma@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260526123115.1226166-5-anskuma@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6te3oymDJV_xkEozVQlWY08m-LDhdyQabXZ_JPTS0Do_1779812037 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 Message-ID-Hash: SYE3XXEGK2YVGQOF3UVUWMQEVJOJDBX7 X-Message-ID-Hash: SYE3XXEGK2YVGQOF3UVUWMQEVJOJDBX7 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: jmaloy@redhat.com, david@gibson.dropbear.id.au X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: T24gNS8yNi8yNiAxNDozMSwgQW5zaHUgS3VtYXJpIHdyb3RlOg0KPiBDaGFuZ2UgZmlsbF9vbmUo KSB0byBhY2NlcHQgYSBidWZmZXIgcG9pbnRlciBhbmQgY2FwYWNpdHkgaW5zdGVhZCBvZg0KPiBh IHN0cnVjdCBtc2cgcG9pbnRlci4gIFRoaXMgaXMgYSBwdXJlIHJlZmFjdG9yIHdpdGggbm8gYmVo YXZpb3IgY2hhbmdlLA0KPiBwcmVwYXJpbmcgZm9yIG9wdGlvbiBvdmVybG9hZCBzdXBwb3J0IHdo ZXJlIGZpbGxfb25lKCkgd2lsbCBhbHNvIHdyaXRlDQo+IGludG8gdGhlIGZpbGUgYW5kIHNuYW1l IGZpZWxkcy4NCj4gDQo+IExpbms6IGh0dHBzOi8vYnVncy5wYXNzdC50b3Avc2hvd19idWcuY2dp P2lkPTE5Mg0KPiBTaWduZWQtb2ZmLWJ5OiBBbnNodSBLdW1hcmkgPGFuc2t1bWFAcmVkaGF0LmNv bT4NCj4gLS0tDQo+IHYyOg0KPiAgICAtIFJlbmFtZWQgcGFyYW1ldGVyIGNhcCDihpIgc2l6ZS4N Cj4gLS0tDQo+ICAgZGhjcC5jIHwgMjcgKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tDQo+ICAg MSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQ0KPiANCj4g ZGlmZiAtLWdpdCBhL2RoY3AuYyBiL2RoY3AuYw0KPiBpbmRleCBlMWM5NWFkLi5lMTI2MDYzIDEw MDY0NA0KPiAtLS0gYS9kaGNwLmMNCj4gKysrIGIvZGhjcC5jDQo+IEBAIC0yNzksMjggKzI3OSwy NyBAQCBzdHJ1Y3QgbXNnIHsNCj4gICB9IF9fYXR0cmlidXRlX18oKF9fcGFja2VkX18pKTsNCj4g ICANCj4gICAvKioNCj4gLSAqIGZpbGxfb25lKCkgLSBGaWxsIGEgc2luZ2xlIG9wdGlvbiBpbiBt ZXNzYWdlDQo+IC0gKiBAbToJCU1lc3NhZ2UgdG8gZmlsbA0KPiArICogZmlsbF9vbmUoKSAtIEZp bGwgYSBzaW5nbGUgb3B0aW9uIGludG8gYSBidWZmZXINCj4gKyAqIEBidWY6CUJ1ZmZlciB0byB3 cml0ZSBvcHRpb24NCj4gKyAqIEBzaXplOglVc2FibGUgc2l6ZSBvZiBAYnVmIChleGNsdWRpbmcg ZW5kIG1hcmtlcikNCj4gICAgKiBAbzoJCU9wdGlvbiBudW1iZXINCj4gLSAqIEBvZmZzZXQ6CUN1 cnJlbnQgb2Zmc2V0IHdpdGhpbiBvcHRpb25zIGZpZWxkLCB1cGRhdGVkIG9uIGluc2VydGlvbg0K PiArICogQG9mZnNldDoJQ3VycmVudCBvZmZzZXQgd2l0aGluIEBidWYsIHVwZGF0ZWQgb24gaW5z ZXJ0aW9uDQo+ICAgICoNCj4gLSAqIFJldHVybjogZmFsc2UgaWYgbSBoYXMgc3BhY2UgdG8gd3Jp dGUgdGhlIG9wdGlvbiwgdHJ1ZSBvdGhlcndpc2UNCj4gKyAqIFJldHVybjogZmFsc2UgaWYgQGJ1 ZiBoYXMgc3BhY2UgdG8gd3JpdGUgdGhlIG9wdGlvbiwgdHJ1ZSBvdGhlcndpc2UNCj4gICAgKi8N Cj4gLXN0YXRpYyBib29sIGZpbGxfb25lKHN0cnVjdCBtc2cgKm0sIGludCBvLCBpbnQgKm9mZnNl dCkNCj4gK3N0YXRpYyBib29sIGZpbGxfb25lKHVpbnQ4X3QgKmJ1Ziwgc2l6ZV90IHNpemUsIGlu dCBvLCBpbnQgKm9mZnNldCkNCj4gICB7DQo+ICAgCXNpemVfdCBzbGVuID0gb3B0c1tvXS5zbGVu Ow0KPiAgIA0KPiAtCS8qIElmIHdlIGRvbid0IGhhdmUgc3BhY2UgdG8gd3JpdGUgdGhlIG9wdGlv biwgdGhlbiBqdXN0IHNraXAgKi8NCj4gLQlpZiAoKm9mZnNldCArIDIgLyogY29kZSBhbmQgbGVu Z3RoIG9mIG9wdGlvbiAqLyArIHNsZW4gPiBPUFRfTUFYKQ0KDQpQZXJoYXBzIHdlIGNhbiBrZWVw IHRoZSBjb21tZW50cz8NCg0KPiArCWlmICgqb2Zmc2V0ICsgMiArIHNsZW4gPiBzaXplKQ0KPiAg IAkJcmV0dXJuIHRydWU7DQo+ICAgDQo+IC0JbS0+b1sqb2Zmc2V0XSA9IG87DQo+IC0JbS0+b1sq b2Zmc2V0ICsgMV0gPSBzbGVuOw0KPiArCWJ1Zlsqb2Zmc2V0XSA9IG87DQo+ICsJYnVmWypvZmZz ZXQgKyAxXSA9IHNsZW47DQo+ICAgDQo+IC0JLyogTW92ZSB0byBvcHRpb24gKi8NCg0KZGl0dG8N Cg0KPiAgIAkqb2Zmc2V0ICs9IDI7DQo+ICAgDQo+IC0JbWVtY3B5KCZtLT5vWypvZmZzZXRdLCBv cHRzW29dLnMsIHNsZW4pOw0KPiArCW1lbWNweSgmYnVmWypvZmZzZXRdLCBvcHRzW29dLnMsIHNs ZW4pOw0KPiAgIA0KPiAgIAlvcHRzW29dLnNlbnQgPSAxOw0KPiAgIAkqb2Zmc2V0ICs9IHNsZW47 DQo+IEBAIC0zMjUsMTkgKzMyNCwxOSBAQCBzdGF0aWMgaW50IGZpbGwoc3RydWN0IG1zZyAqbSkN Cj4gICAJICogUHV0IGl0IHRoZXJlIGV4cGxpY2l0bHksIHVubGVzcyByZXF1ZXN0ZWQgdmlhIG9w dGlvbiA1NS4NCj4gICAJICovDQo+ICAgCWlmIChvcHRzWzU1XS5jbGVuID4gMCAmJiAhbWVtY2hy KG9wdHNbNTVdLmMsIDUzLCBvcHRzWzU1XS5jbGVuKSkNCj4gLQkJaWYgKGZpbGxfb25lKG0sIDUz LCAmb2Zmc2V0KSkNCj4gKwkJaWYgKGZpbGxfb25lKG0tPm8sIE9QVF9NQVgsIDUzLCAmb2Zmc2V0 KSkNCj4gICAJCQkgZGVidWcoIkRIQ1A6IHNraXBwaW5nIG9wdGlvbiA1MyIpOw0KPiAgIA0KPiAg IAlmb3IgKGkgPSAwOyBpIDwgb3B0c1s1NV0uY2xlbjsgaSsrKSB7DQo+ICAgCQlvID0gb3B0c1s1 NV0uY1tpXTsNCj4gICAJCWlmIChvcHRzW29dLnNsZW4gIT0gLTEpDQo+IC0JCQlpZiAoZmlsbF9v bmUobSwgbywgJm9mZnNldCkpDQo+ICsJCQlpZiAoZmlsbF9vbmUobS0+bywgT1BUX01BWCwgbywg Jm9mZnNldCkpDQo+ICAgCQkJCWRlYnVnKCJESENQOiBza2lwcGluZyBvcHRpb24gJWkiLCBvKTsN Cj4gICAJfQ0KPiAgIA0KPiAgIAlmb3IgKG8gPSAwOyBvIDwgMjU1OyBvKyspIHsNCj4gICAJCWlm IChvcHRzW29dLnNsZW4gIT0gLTEgJiYgIW9wdHNbb10uc2VudCkNCj4gLQkJCWlmIChmaWxsX29u ZShtLCBvLCAmb2Zmc2V0KSkNCj4gKwkJCWlmIChmaWxsX29uZShtLT5vLCBPUFRfTUFYLCBvLCAm b2Zmc2V0KSkNCj4gICAJCQkJZGVidWcoIkRIQ1A6IHNraXBwaW5nIG9wdGlvbiAlaSIsIG8pOw0K PiAgIAl9DQo+ICAgDQoNClJldmlld2VkLWJ5OiBMYXVyZW50IFZpdmllciA8bHZpdmllckByZWRo YXQuY29tPg0KDQo=