From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=foRRxEOC; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id CC7645A0262 for ; Fri, 21 Aug 2026 15:05:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787317504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rpM4hODQZscBjbsNEFluq3HuOYlN0c+DSyg4ji9rqwg=; b=foRRxEOCNFJgzGb91dWU7DKkFssnLyCTFDlvQC5xXN+j4qepe3AF3HtmMgY+gBTWHQc8Uc QeUhH2sKT2rY/UrVPOBGAilPqsnU2bF8prk6vwRN4DJAm7fnHRGCV+F0Vo2IbmA92GIvS+ QmuqlhKTE6/m9qa/w3kMUYV/4SRtWYg= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-NWkRkILwNw2w-egAPwGrHw-1; Fri, 21 Aug 2026 09:05:03 -0400 X-MC-Unique: NWkRkILwNw2w-egAPwGrHw-1 X-Mimecast-MFC-AGG-ID: NWkRkILwNw2w-egAPwGrHw_1787317502 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-c15ceb17a28so74959966b.3 for ; Fri, 21 Aug 2026 06:05:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787317502; x=1787922302; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rpM4hODQZscBjbsNEFluq3HuOYlN0c+DSyg4ji9rqwg=; b=asLndnemkm8cJRFeQsqe+2k0rKR32vAbspy6zCJyF4dH2w3EdUIfF90jEx+x2JrAMq 58IcDiwRBYVbL3VjOdtUtSecucECc9Ug/ZCPHlQnK/t4XrzLLIq15T/pZEUJSB2/4+jW Lx9VbC9HGsdUkH+xQPiEQpZXMdY6dRuCl879NIQNepwM6sgiZlXkhgmVeJ4JrDjNXtVL uAWHa3hOUsT+ZhO/MUggD8bZbCi9fcdtoaGLJb717B6wrj4a7KtFQSOO7qAhhDbgU2Ou IqgMZBYrR+e/xZvSWoz1DwOM64TxW9aXM6uhexrIcFV7yzO1gkRs6w0A+N/EnTdQIZs+ wmZg== X-Forwarded-Encrypted: i=1; AHgh+RoKFUa+odjmpt7db8aL8T74iWteWMn1EtOUPnWkl1kbIe3x5BcpMqerNLHyI1ZuCl+VbK5onJVIF8A=@passt.top X-Gm-Message-State: AFuF++l2bndyeM2JZmWlzuxGzDTkqNTvcfh3MHjCVZRAICCEm5XpsYX8 DG/mCHxqBgnFa7i8f423MBOJkf+dJBUnvP1RAkdM74t4U0D/inWcwAwv4Z/9Tks0D71gbd0NkHF 0cLug3Njf9izw5692UvEVCDchSFYrYXuf2X0su9F0lasTmX4ruSoALw== X-Gm-Gg: AR+sD13Qy3ju3HY4tavpG18bwa3/V7zYA71SsDK1FjHiMsbRXjzOaCXukXHIbSH+ekf j9wkWnarvRWUCp9/qQyA5VdcYrf0nmpUaHAnRA/E4DBvbktb/DJJCtRyw9Jcqt5fTfuHdgn5G/A 2xo8ZTOoUcKhvyNF2QhKnfJUZT6ox+6jgbmTITtt+NvfPvOGESBK93+May7GvFs9Af5eZhGZGku jY59Mo3kp76Cd6/oYmi5UwVolPPPeXjaFR4cT69ZfOiD7g5x1CnsbrhY7ibMUTcXYY9v8b5V7FB lKXwl7CjBVboDoX8ySM7X9Z9N49XwiFBjsGGoPo6X4sm20HhwBWz63fHFQm+NjKraND3FuAtvNu 9eqVfRoTQ5/yK3VXV1SUlSsUnN33Q5ml63rjLjmr61sAE X-Received: by 2002:a17:907:3d0a:b0:c20:83b1:396c with SMTP id a640c23a62f3a-c246a62b68fmr619574266b.17.1787317502311; Fri, 21 Aug 2026 06:05:02 -0700 (PDT) X-Received: by 2002:a17:907:3d0a:b0:c20:83b1:396c with SMTP id a640c23a62f3a-c246a62b68fmr619565466b.17.1787317501813; Fri, 21 Aug 2026 06:05:01 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:d92c:7e4a:47e6:1b23? ([2a01:e0a:e10:ef90:d92c:7e4a:47e6:1b23]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2459198d59sm426770366b.35.2026.08.21.06.05.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Aug 2026 06:05:01 -0700 (PDT) Message-ID: <3e540fa0-101b-4de5-9574-e8f7c9270623@redhat.com> Date: Fri, 21 Aug 2026 15:05:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] util, pasta: Remove some unneeded #includes To: David Gibson , Stefano Brivio , passt-dev@passt.top References: <20260821050403.170891-1-david@gibson.dropbear.id.au> <20260821050403.170891-5-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260821050403.170891-5-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Xk66hPpCpy-oIc6bqASn4-5Q8uERVLdhLSMFcBEjEsY_1787317502 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: RUTMGSDKQIMWGYSMLD72ZPJYFOFTMC4S X-Message-ID-Hash: RUTMGSDKQIMWGYSMLD72ZPJYFOFTMC4S X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/21/26 07:04, David Gibson wrote: > Presumably these mattered at some point in the past, but no longer. Found > by clangd as invoked by Zed editor. Not sure why direct clang-tidy runs > didn't spot these. > > Signed-off-by: David Gibson > --- > pasta.c | 1 - > util.c | 3 --- > 2 files changed, 4 deletions(-) > > diff --git a/pasta.c b/pasta.c > index 5aa56b78..247ebeda 100644 > --- a/pasta.c > +++ b/pasta.c > @@ -46,7 +46,6 @@ > > #include "util.h" > #include "passt.h" > -#include "isolation.h" > #include "netlink.h" > #include "log.h" > #include "epoll_ctl.h" > diff --git a/util.c b/util.c > index df972a05..99585d2c 100644 > --- a/util.c > +++ b/util.c > @@ -30,11 +30,8 @@ > #include "util.h" > #include "iov.h" > #include "passt.h" > -#include "packet.h" > #include "log.h" > #include "pcap.h" > -#include "epoll_ctl.h" > -#include "pasta.h" > #include "serialise.h" > #ifdef HAS_GETRANDOM > #include Reviewed-by: Laurent Vivier