From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LyHE8fLC; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 29FE65A0262 for ; Thu, 12 Mar 2026 09:08:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773302919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CY54yyn3WUqT3LT7H2dJgaKMNaM9taSA2tyJvYvqQxw=; b=LyHE8fLCsC5mgmxu4MqPm9EOonziaUr1gS91SjGp0BVCnBEefSc7xF1wLfV6jwQCGxNj8u zYNN4aysrh5TozIrbAKB/BlGm3yShykx2q5Gpk4MrAfQdcXlw3AgfXPkJHDGPRyyAG7nsg 2/uaG3vPHn6BLrHIeJsKhDDiKDW84Po= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-RdPb3KTtNKuqHvIS9L8KHg-1; Thu, 12 Mar 2026 04:08:37 -0400 X-MC-Unique: RdPb3KTtNKuqHvIS9L8KHg-1 X-Mimecast-MFC-AGG-ID: RdPb3KTtNKuqHvIS9L8KHg_1773302916 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4853ac455b2so7288165e9.1 for ; Thu, 12 Mar 2026 01:08:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773302916; x=1773907716; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CY54yyn3WUqT3LT7H2dJgaKMNaM9taSA2tyJvYvqQxw=; b=NQgDTDsYIVL+z2t+2tT3cOhyZeuR198hetEgrHzBAFn4KvwtxbM/lfCdDGrkffQa1r hS7O/vytxhbFfY4SYLW8WCtPQctYw4zWi/VNeXWsQFSUER7jyToFdNUJdR4BTEvOK2Jk NCk3ta5YSxdANFNDK9lTHAfTF/4NEQBf9ID9k+i+yljSfyoeRwLIYV3fOjvkqGKOsTTW 4z710RZaFezMN6pMPAiB2lCKBo5gUn/2gPxtXJOcZhYvZqZpuJpeLbynpU+AjWKvzBZD Aw9GAAXxRfsdnrXPjqcnqAljojfSuUIxv3PHTAR7SCs0NgasL8uB4aH1TsxVkASH1lhb AwjQ== X-Gm-Message-State: AOJu0Yx2Bt2LfKOcCjpzn3QGNkN0ynPOXr5oK/ZiKg6reU6MmxZDMODj xrrZ4N0HzZFkeMtCBKEg2sIRLbejL/W8E1km99Y51mtWZxLFeKSl5sTYct0HVAr0SHXtAMeMfLD 9+/za5NhSfupoNAgW+EnHfHwXT1WZlU1JPktD6I0rUI67Y4JUIIPLebuj9EQzoA== X-Gm-Gg: ATEYQzxw7jTZmKHdAC4oMzvVUuKYbdU5gjsJfigyWy4fxK5O2X97h9xCaLKsRqsakyS 8YidXVHXbaA3VFiqGFBRM0ojFGaI0gxWvAYQzWUUQcaF5QtF97Uxx1Scavvn3i1frxpdbomFO+z QaPniD40So/BrjAybgBHHCxkeldibgMk8dhTGe4Tnc2u37PxRYt+Pw7Rh28/gQYRFZVcCltgvj+ iTIT4Lh0NMK5KFs5yjxZQ0FyRJ8cYgRW7Al1yw5m0S/4thPBdHpg/j6573LNKxntqpX8bMYjHbq z0OJhPEQEqpEzxU8/NcF9JANKqKaO22zWWFfw/YaKMvNH7s+Z0hKrb+mKQafrQhvGNUYe2zYMvM wrkUXQCTAqBofCUPKy9mZbb7ESGFiI0Mm8WE7UqSDYkEGSeztaVZhgvwl5PPjw8UlFQ== X-Received: by 2002:a05:600c:46d3:b0:485:3c66:e230 with SMTP id 5b1f17b1804b1-4854b12ced9mr88737525e9.29.1773302916081; Thu, 12 Mar 2026 01:08:36 -0700 (PDT) X-Received: by 2002:a05:600c:46d3:b0:485:3c66:e230 with SMTP id 5b1f17b1804b1-4854b12ced9mr88736835e9.29.1773302915287; Thu, 12 Mar 2026 01:08:35 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4326:a36e:a7cb:624b? ([2a01:e0a:e10:ef90:4326:a36e:a7cb:624b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b6756e4sm129887245e9.15.2026.03.12.01.08.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 01:08:34 -0700 (PDT) Message-ID: <43363999-76cf-4f4c-a73d-450c5906e6b9@redhat.com> Date: Thu, 12 Mar 2026 09:08:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/13] vhost-user,udp: Use 2 iovec entries per element To: David Gibson References: <20260309094744.1907754-1-lvivier@redhat.com> <20260309094744.1907754-14-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8SJwFtnIBX-aQKEhgGxO1ZdhXsogrPt5fZcy6Z72M_4_1773302916 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: NJ5JVDZ63JQEHAUEYVJ3S2NQJQLB4BO2 X-Message-ID-Hash: NJ5JVDZ63JQEHAUEYVJ3S2NQJQLB4BO2 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/12/26 05:39, David Gibson wrote: > On Mon, Mar 09, 2026 at 10:47:44AM +0100, Laurent Vivier wrote: >> iPXE places the vnet header in one virtqueue descriptor and the payload >> in another. When passt maps these descriptors, it needs two iovecs per >> virtqueue element to handle this layout. >> >> Without this, passt crashes with: >> >> ASSERTION FAILED in virtqueue_map_desc (virtio.c:403): num_sg < max_num_sg >> >> Signed-off-by: Laurent Vivier >> --- >> udp_vu.c | 8 ++++---- >> vu_common.c | 15 +++++++++++---- >> 2 files changed, 15 insertions(+), 8 deletions(-) >> >> diff --git a/udp_vu.c b/udp_vu.c >> index cb5274aa1d81..47659b0402fd 100644 >> --- a/udp_vu.c >> +++ b/udp_vu.c >> @@ -34,7 +34,7 @@ >> #include "vu_common.h" >> >> static struct iovec iov_vu [VIRTQUEUE_MAX_SIZE]; >> -static struct vu_virtq_element elem [VIRTQUEUE_MAX_SIZE]; >> +static struct vu_virtq_element elem [VIRTQUEUE_MAX_SIZE / IOV_PER_ELEM]; > > The two level structure of the queues (array of elems, each pointing > to an array of iovs) confuses me a bit. I would have thought that > VIRTQUEUE_MAX_SIZE represented the maximum number of elements, even if > those elements had multiple iovs. Can you enlighten me? > In all the code until now I supposed the number of iovec is equal to the number of element because we had only one iovec per element. At virtio level, VIRTQUEUE_MAX_SIZE is the number of vring_desc in a virtqueue, and a vring_desc is translated to an iovec in virtqueue_map_desc() that are collected to an element in vu_queue_map_desc(). So in passt, the maximum number of collected iovec will be VIRTQUEUE_MAX_SIZE and the maximum of element is VIRTQUEUE_MAX_SIZE if we have only one iovec per element. I'm reworking all of this to be able to have several iovec per element on demand (in vu_queue_map_desc()). This patch and previous one will be dropped. Thanks, Laurent