From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RWElj1jY; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 2D4AC5A004E for ; Wed, 16 Oct 2024 12:07:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729073251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RvT5a15Q2GajOwR3oTXlyk25k+MHefQgKhaMrcO3qJk=; b=RWElj1jYB/DiUgImhUC2hjUSmhpfWzmiojZqMx1T3ohKeZFoyvl2kJtv4sasQXvmbGKaGt WbhShqM9qo0+ett+LCEl0d1ViZHA9Ouj7hgyp7EVwZG3L9rEZyAxL7Ja6diPcdXmNatDAs a0NgnRt0U8x/J8HL5FLLewP+gV0DjTo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-4B7OiHBMMsGhmbJIor0dpA-1; Wed, 16 Oct 2024 06:07:24 -0400 X-MC-Unique: 4B7OiHBMMsGhmbJIor0dpA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-37d49887a2cso397761f8f.0 for ; Wed, 16 Oct 2024 03:07:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729073243; x=1729678043; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RvT5a15Q2GajOwR3oTXlyk25k+MHefQgKhaMrcO3qJk=; b=mp3ttu3ZnSr3cmDizCGA+1tzjw5Y/d+TYCUqEK54+h1yGoctAHw0BXLQCJ1iQv47Tw J3+B32fV/WQu9slkZp+qxAKQHxM6tMmC3ydIrV76MlpUyXkxSNpslP61LbvUujWP2d/V 1cSSsp7y+d2mZOV97LVpYSgBEJLUWpUAzKUXuxuNzFmzamojd3H5hx4HP0iH3Uu0zyiZ yXegpFT25GUrtkNRWcennqkisudLOijYQls/KOI8R7dUd6P1RpovGtCcJbBxKNfejznY X3hPJ4eaHxoWdH/jzr33xN/7H1PcuJlleRQQfk6GJ19n+xSW4JT8RYarhGJaEFc4bSjM 4R7w== X-Gm-Message-State: AOJu0YxhMHTx3rXrosW3eIv4RIqHIOTpIvKQu7mdFVqqzU/TLTB0Jbme by+0gdqYRNGxV4xKIJ6Lc+YVZbqpHHmMePQe5Cz53McfWcE4wL5BTARJ8rB4Pst8LdQ/xWaoo6m 6Qi2/NsGGXj2yIH4kfrZqkksE+2Fosi8P35w2cCEjN3kImn6yqGdP99dbWQ== X-Received: by 2002:a05:6000:128f:b0:37d:364c:b410 with SMTP id ffacd0b85a97d-37d55304616mr13906505f8f.33.1729073243254; Wed, 16 Oct 2024 03:07:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE+gHRgRJfnNWX+UpRsOs1+y7sJWegxvuY4zPE+RUs/0lfo+rcGNcQRTUT/b7bLmx0UCp6tNw== X-Received: by 2002:a05:6000:128f:b0:37d:364c:b410 with SMTP id ffacd0b85a97d-37d55304616mr13906489f8f.33.1729073242860; Wed, 16 Oct 2024 03:07:22 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78? ([2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d7fc445fesm3896161f8f.113.2024.10.16.03.07.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2024 03:07:22 -0700 (PDT) Message-ID: <45e1f806-7516-41df-a11f-028516bfd513@redhat.com> Date: Wed, 16 Oct 2024 12:07:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 7/8] vhost-user: add vhost-user To: David Gibson References: <20241010122903.1188992-1-lvivier@redhat.com> <20241010122903.1188992-8-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: RMUMJGV5UXZQNZNTHS6QGACHKEHSG765 X-Message-ID-Hash: RMUMJGV5UXZQNZNTHS6QGACHKEHSG765 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 15/10/2024 05:23, David Gibson wrote: >> +/** >> + * tcp_vu_update_check() - Calculate TCP checksum >> + * @tapside: Address information for one side of the flow >> + * @iov: Pointer to the array of IO vectors >> + * @iov_used: Length of the array >> + */ >> +static void tcp_vu_update_check(const struct flowside *tapside, >> + struct iovec *iov, int iov_used) > AFAICT this is only used for the pcap path. Rather than filling in > the checksum at a different point from normal, I think it would be > easier to just clear the no_tcp_csum flag when pcap is enabled. That > would, AFAICT, remove the need for this function entirely. To do that is a little bit complicated because we need to pass the iov array to tcp_fill_headers4()/tcp_fill_headers6() to be able to compute the checksum of the TCP part. In tcp_buf, the TCP header and TCP payload are in the same iovec but with tcp_vu they can be split on several iovecs. And if we provide the iovec , theoretically we should not provide the TAP, IP and TCP headers via the parameters as they are in the iovec, but for tcp_buf they have one iovec each, and with tcp_vu they are probably all in the same iovec (the first one). So, again, it can be complicated to extract headers to update them. In conclusion, I update the checksum only for VU and in the case of pcap because it is simpler (the same logic applies for udp_update_hdr4()/udp_update_hdr6()). I'm open to any suggestion that could do the checksum in udp_update_hdr4()/udp_update_hdr6() (I agree with you, it should be the place to do it) but I don't see an easy and nice way to implement it. Thanks, Laurent