[PATCH] fedora: Fix build on Fedora 43, selinux_requires_min not available on Copr builders

[PATCH] fedora: Fix build on Fedora 43, selinux_requires_min not available on Copr builders

[Stefano Brivio]

For some reason, on Copr:

  Building target platforms: aarch64
  Building for target aarch64
  error: line 42: Unknown tag: %selinux_requires_min
  Child return code was: 1

Use %selinux_requires_min starting from current Rawhide / Fedora 44,
there it works.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
I just merged this as I needed to fix Fedora 43 builds, feel free
to propose changes on top if you see a better way / have a proper
explanation.

 contrib/fedora/passt.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec
index bcbe1f7..38b06b0 100644
--- a/contrib/fedora/passt.spec
+++ b/contrib/fedora/passt.spec
@@ -37,7 +37,7 @@ requiring any capabilities or privileges.
 %package		    selinux
 BuildArch:		    noarch
 Summary:		    SELinux support for passt and pasta
-%if 0%{?fedora} >= 43
+%if 0%{?fedora} > 43
 BuildRequires:      selinux-policy-devel
 %selinux_requires_min
 %else
-- 
2.43.0

Re: [PATCH] fedora: Fix build on Fedora 43, selinux_requires_min not available on Copr builders

[Max Chernoff]

Hi Stefano,

On Mon, 2025-12-08 at 11:34 +0100, Stefano Brivio wrote:
> For some reason, on Copr:
>
>   Building target platforms: aarch64
>   Building for target aarch64
>   error: line 42: Unknown tag: %selinux_requires_min
>   Child return code was: 1
>
> Use %selinux_requires_min starting from current Rawhide / Fedora 44,
> there it works.

The previous code worked locally for me with F43, so I guess that that
means that the COPR builders have old dependencies installed? Which is
kind of surprising, but your patch looks harmless to me, so if it solved
the problem, then that seems okay to me.

Thanks,
-- Max

Re: [PATCH] fedora: Fix build on Fedora 43, selinux_requires_min not available on Copr builders

[Stefano Brivio]

On Mon, 08 Dec 2025 03:43:30 -0700
Max Chernoff <git@maxchernoff.ca> wrote:

> Hi Stefano,
> 
> On Mon, 2025-12-08 at 11:34 +0100, Stefano Brivio wrote:
> > For some reason, on Copr:
> >
> >   Building target platforms: aarch64
> >   Building for target aarch64
> >   error: line 42: Unknown tag: %selinux_requires_min
> >   Child return code was: 1
> >
> > Use %selinux_requires_min starting from current Rawhide / Fedora 44,
> > there it works.  
> 
> The previous code worked locally for me with F43, so I guess that that
> means that the COPR builders have old dependencies installed? Which is
> kind of surprising, but your patch looks harmless to me, so if it solved
> the problem, then that seems okay to me.

Thanks for checking. Yes, I'm also rather surprised, even though I
didn't check exactly what version of what causes the problem, yet. This
(not a permanent link, sorry!) worked:

  https://download.copr.fedorainfracloud.org/results/sbrivio/passt/fedora-rawhide-x86_64/09885681-passt/builder-live.log.gz

and this didn't:

  https://download.copr.fedorainfracloud.org/results/sbrivio/passt/fedora-43-x86_64/09885681-passt/builder-live.log.gz

-- 
Stefano

Re: [PATCH] fedora: Fix build on Fedora 43, selinux_requires_min not available on Copr builders

[Max Chernoff]

Hi Stefano,

On Mon, 2025-12-08 at 11:55 +0100, Stefano Brivio wrote:
> This (not a permanent link, sorry!) worked:
>
>   https://download.copr.fedorainfracloud.org/results/sbrivio/passt/fedora-rawhide-x86_64/09885681-passt/builder-live.log.gz
>
> and this didn't:
>
>   https://download.copr.fedorainfracloud.org/results/sbrivio/passt/fedora-43-x86_64/09885681-passt/builder-live.log.gz

%selinux_requires_min is defined in

    /usr/lib/rpm/macros.d/macros.selinux-policy

which is provided by the "selinux-policy" package, which is installed in
the

    Start: installing minimal buildroot with dnf5

section of the rawhide builder, but not the F43 one. The "Installing
group/module packages" are identical in both builders, but it looks like
one of the dependencies changed in rawhide to automatically pull in
"selinux-policy":

    https://src.fedoraproject.org/rpms/rust-add-determinism/c/e2ef3ed3?branch=rawhide

Thanks,
-- Max

Re: [PATCH] fedora: Fix build on Fedora 43, selinux_requires_min not available on Copr builders

[Stefano Brivio]

On Mon, 08 Dec 2025 04:30:52 -0700
Max Chernoff <git@maxchernoff.ca> wrote:

> Hi Stefano,
> 
> On Mon, 2025-12-08 at 11:55 +0100, Stefano Brivio wrote:
> > This (not a permanent link, sorry!) worked:
> >
> >   https://download.copr.fedorainfracloud.org/results/sbrivio/passt/fedora-rawhide-x86_64/09885681-passt/builder-live.log.gz
> >
> > and this didn't:
> >
> >   https://download.copr.fedorainfracloud.org/results/sbrivio/passt/fedora-43-x86_64/09885681-passt/builder-live.log.gz  
> 
> %selinux_requires_min is defined in
> 
>     /usr/lib/rpm/macros.d/macros.selinux-policy
> 
> which is provided by the "selinux-policy" package, which is installed in
> the
> 
>     Start: installing minimal buildroot with dnf5
> 
> section of the rawhide builder, but not the F43 one. The "Installing
> group/module packages" are identical in both builders, but it looks like
> one of the dependencies changed in rawhide to automatically pull in
> "selinux-policy":
> 
>     https://src.fedoraproject.org/rpms/rust-add-determinism/c/e2ef3ed3?branch=rawhide

Hah, thanks for the explanation! I saw that selinux-policy wasn't
installed in one case but it didn't even occur to me to trace it down
like you did.

-- 
Stefano