From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id D67B75A0082 for ; Thu, 16 Feb 2023 14:32:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676554377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WdoL+2zDocIqTvVcZDtXea3iinkkuW0TJW1vX+ICS/E=; b=Qup7iimaw9Pm+xCm5iJjjuPQUQTqUZQE5oBNMdgpgwkj1xrnvhnV3tSay0E06kFVdOeBvH 2xB5JzkaWF8LNMhqJqzl+vKoTaeqV48j5CvgJ7Oxr0O3v9AIv6fIzZOIw9nSs1+zTfB47P ZtIunqynDe/sLqKsvHxRcNKb7CJxGl0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-277-1JwrpBkpPiGUFCnuGr1BZA-1; Thu, 16 Feb 2023 08:32:55 -0500 X-MC-Unique: 1JwrpBkpPiGUFCnuGr1BZA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5717D811E9C for ; Thu, 16 Feb 2023 13:32:55 +0000 (UTC) Received: from maggie.redhat.com (unknown [10.43.2.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id C01BE2166B30; Thu, 16 Feb 2023 13:32:54 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH v2 1/5] qemu_passt: Avoid double daemonizing passt Date: Thu, 16 Feb 2023 14:32:48 +0100 Message-Id: <4fa71e685d69f496d481ef51157c1ffa4c85166d.1676554196.git.mprivozn@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: SVN26UGXAAPRL3H2ESMI7MM5FNBWGUG2 X-Message-ID-Hash: SVN26UGXAAPRL3H2ESMI7MM5FNBWGUG2 X-Mailman-Approved-At: Thu, 16 Feb 2023 18:44:36 +0100 CC: sbrivio@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When passt is started, it daemonizes itself by default. There's no point in having our virCommand module daemonize it too. Signed-off-by: Michal Privoznik --- src/qemu/qemu_passt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c index 78830fdc26..adc69fc052 100644 --- a/src/qemu/qemu_passt.c +++ b/src/qemu/qemu_passt.c @@ -156,7 +156,6 @@ qemuPasstStart(virDomainObj *vm, virCommandClearCaps(cmd); virCommandSetPidFile(cmd, pidfile); virCommandSetErrorFD(cmd, &errfd); - virCommandDaemonize(cmd); virCommandAddArgList(cmd, "--one-off", -- 2.39.1