public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
blob 50598a582e38a6ca3bbb9bc100788bc8bf69764a 5378 bytes (raw)

  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
 
#! /usr/bin/python3

# SPDX-License-Identifier: GPL-2.0-or-later
#
# tasst - Test A Simple Socket Transport
#         library of test helpers for passt & pasta
#
# tasst/nstool.py - Run commands in namespaces via 'nstool'
#
# Copyright Red Hat
# Author: David Gibson <david@gibson.dropbear.id.au>

import contextlib
import os
import sys
import tempfile

import avocado
from avocado.utils.process import CmdError

from tasst import Tasst
from tasst.site import IsolatedSiteTasst, SiteTasst, Site, REAL_HOST
from tasst.typing import typecheck

# FIXME: Can this be made more portable?
UNIX_PATH_MAX = 108


class NsToolSite(Site):
    NST_BIN = './test/nstool'

    def __init__(self, name, sockpath):
        if len(sockpath) > UNIX_PATH_MAX:
            raise ValueError('Unix domain socket path \"{}\" is too long'.format(sockpath))

        super().__init__(name)
        self.sockpath = sockpath

    def __enter__(self):
        self._pid = int(REAL_HOST.output('{} info -wp {}'.format(self.NST_BIN, self.sockpath), timeout=1))
        return self

    def __exit__(self, *exc_details):
        pass

    # PID of the nstool hold process as seen by the test host
    def pid(self):
        return self._pid

    # PID of the nstool hold process as seen by another site
    # (important when using PID namespaces)
    def relative_pid(self, relative_to):
        cmd = '{} info -p {}'.format(self.NST_BIN, self.sockpath)
        return int(relative_to.output(cmd))

    def _nst_cmd(self, cmd, sudo=False):
        nst_args = self.sockpath
        if sudo:
            nst_args = '--keep-caps ' + nst_args
        return '{} exec {} -- {}'.format(self.NST_BIN, nst_args, cmd)

    def output(self, cmd, sudo=False, **kwargs):
        return REAL_HOST.output(self._nst_cmd(cmd, sudo), **kwargs)

    def fg(self, cmd, sudo=False, **kwargs):
        return REAL_HOST.fg(self._nst_cmd(cmd, sudo), **kwargs)

    def bg(self, cmd, sudo=False, **kwargs):
        return REAL_HOST.bg(self._nst_cmd(cmd, sudo), **kwargs)


# Create path for temporary nstool Unix socket
#
# The obvious choice would be to use Avocado's workdir, but that often
# gives paths that are too long for Unix sockets
def temp_sockpath(name):
    tmpd = tempfile.mkdtemp(suffix=name)
    return os.path.join(tmpd, 's')


class UnshareSite(NsToolSite):
    def __init__(self, name, unshare_opts, parent=REAL_HOST, sudo=False):
        sockpath = temp_sockpath(name)
        parent.require_cmds('unshare', self.NST_BIN)

        super().__init__(name, sockpath)

        self.parent = typecheck(parent, Site)
        self.holdcmd = 'unshare {} -- {} hold {}'.format(unshare_opts,
                                                         self.NST_BIN, sockpath)
        self.sudo = typecheck(sudo, bool)

    def __enter__(self):
        self.holder = self.parent.bg(self.holdcmd, sudo=self.sudo)
        self.holder.__enter__()
        return super().__enter__()

    def __exit__(self, *exc_details):
        super().__exit__(*exc_details)
        
        try:
            self.parent.fg('{} stop {}'.format(self.NST_BIN, self.sockpath))
        finally:
            self.holder.__exit__(*exc_details)

        try:
            os.remove(self.sockpath)
        except FileNotFoundError:
            pass

        os.rmdir(os.path.dirname(self.sockpath))


class UserNetNsTasst(IsolatedSiteTasst):
    """
    Test creating a userns+netns together

    :avocado: tags=meta
    """

    @contextlib.contextmanager
    def setup_site(self):
        with UnshareSite(type(self).__name__, '-Ucn') as ns:
            ns.ifup('lo')
            yield ns

    def test_userns(self):
        REAL_HOST.require_cmds('capsh')
        with self.setup_site() as ns:
            ns.require_cmds('capsh')
            capcmd = 'capsh --has-p=CAP_SETUID'
            self.assertRaises(CmdError, REAL_HOST.fg, capcmd)
            ns.fg(capcmd, sudo=True)


class NestedNsTasst(IsolatedSiteTasst):
    """
    Test creating userns with a netns nested within

    :avocado: tags=meta
    """

    @contextlib.contextmanager
    def setup_site(self):
        name = type(self).__name__
        with UnshareSite(name + '.userns', '-Uc') as userns:
            with UnshareSite(name + '.netns', '-n', parent=userns, sudo=True) as netns:
                netns.ifup('lo')
                yield netns


class PidNsTasst(IsolatedSiteTasst):
    """
    Test unsing unshare -p  to create a pidns

    :avocado: tags=meta
    """

    @contextlib.contextmanager
    def setup_site(self):
        with UnshareSite(type(self).__name__, '-Upfn') as ns:
            ns.ifup('lo')
            yield ns

    def test_relative_pid(self):
        with self.setup_site() as site:
            # The holder is init (pid 1) within its own pidns
            self.assertEquals(site.relative_pid(site), 1)


class ConnectNsToolTasst(SiteTasst):
    """
    Test connecting to a pre-existing nstool

    :avocado: tags=meta
    """

    @contextlib.contextmanager
    def setup_site(self):
        sockpath = temp_sockpath(type(self).__name__)
        holdcmd = '{} hold {}'.format(NsToolSite.NST_BIN, sockpath)
        with REAL_HOST.bg(holdcmd) as holder:
            with NsToolSite("fake ns", sockpath) as site:
                yield site

        try:
            os.remove(sockpath)
        finally:
            os.rmdir(os.path.dirname(sockpath))

debug log:

solving 50598a5 ...
found 50598a5 in https://archives.passt.top/passt-dev/20230531015849.3229596-11-david@gibson.dropbear.id.au/
found 020e8a0 in https://archives.passt.top/passt-dev/20230531015849.3229596-10-david@gibson.dropbear.id.au/

applying [1/2] https://archives.passt.top/passt-dev/20230531015849.3229596-10-david@gibson.dropbear.id.au/
diff --git a/avocado/tasst/nstool.py b/avocado/tasst/nstool.py
new file mode 100644
index 0000000..020e8a0


applying [2/2] https://archives.passt.top/passt-dev/20230531015849.3229596-11-david@gibson.dropbear.id.au/
diff --git a/avocado/tasst/nstool.py b/avocado/tasst/nstool.py
index 020e8a0..50598a5 100644

2:106: trailing whitespace.
        
Checking patch avocado/tasst/nstool.py...
Applied patch avocado/tasst/nstool.py cleanly.
Checking patch avocado/tasst/nstool.py...
Applied patch avocado/tasst/nstool.py cleanly.
warning: 1 line adds whitespace errors.

index at:
100644 50598a582e38a6ca3bbb9bc100788bc8bf69764a	avocado/tasst/nstool.py

Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).