From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VeD4K7wK; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 51A825A061A for ; Wed, 11 Dec 2024 11:36:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733913384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ll0YFvIqD8+kLHTjSJ42PEdfSoKZSvOAULYt3kXe8Hw=; b=VeD4K7wKqo98WlglTthRnfDMt53KXm8U5981CwF24v2GuGmGg52V2sY9UMfZCXW2eivDHa LpiNzinUFYrZtUngxZ/6KbZ4upz9Bkg8VovAiJEsZ2bJozc7Dlg/7OIPrD5VwHYPcpgIIE FOVs77dP9tTQpR2P/I2gYrrL2iKEvUM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-BiPGADZ1NIuYxcfS2zcMJA-1; Wed, 11 Dec 2024 05:36:22 -0500 X-MC-Unique: BiPGADZ1NIuYxcfS2zcMJA-1 X-Mimecast-MFC-AGG-ID: BiPGADZ1NIuYxcfS2zcMJA Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4361efc9d1fso3893075e9.2 for ; Wed, 11 Dec 2024 02:36:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733913382; x=1734518182; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ll0YFvIqD8+kLHTjSJ42PEdfSoKZSvOAULYt3kXe8Hw=; b=Tan30F8FAq6p4AIHl4cSk44IKiSWAVmWbm/cdftzc7rEuVCLfXkKUY1+Ry/KrxF+nM TPkW4I2+bG9KvQZUjkD3lr6hmwyQE5QQQlq3o3YmNTlHo/1ejb/FXtlMHSWF+7oStt7a hskaLbCyCQAB6MVhuZwPT2IG2pj0eiCaPz29dltc2P9Y42JHCuF3+ihz6I9rAszP6t7O SvgVo0usGs3Hl9bWuCxhHMkXRrQKmrMhQVRuSNesl1SDrR+TpmgT/qbvUnhf3F19/Qzl Wo99sgXMVeXbe9Ok07RU2zOGB7MB2oCkmHsjNcDRwbLPss/NbwOTj3f+CMWA0Cq+Uxv/ 8GhA== X-Gm-Message-State: AOJu0Yy1nVZFISna19L6LelrgX9dHk46H9+diUfVx6OSs1Nw6IQyCSB4 thPfGXHCh9Wkmmp8fgnJTOrPE4mhlKhnh7D7+grnv3KjvH+8mtNPO966sz3zDgyu5cePnVWntbw Vk7l4VSUCbmwLe2TvOiiJyQuW4AwSpLpvqCPcEbUM4nCdAZQQtA== X-Gm-Gg: ASbGncua4MwN9NXpZ6pw9YgtEKIUFcZp1jazpWe1Oi+DsTB5sLRHkOQj2+agFbMArTf 1YRdLpzml5zE/9Zlis0zkPVi1PDIigMA/T7S8+UFiHLUWCKkqWaQedGgIpAPOF+GJhXPsSEUmhr WSSo5DrV+J8tOyp3DOKpWFnQsRe++8G0KlLSsV0B3hN1ykJugxBqDNMqImQkoVUlVY5X2uwmr2x YYjP3HhhZ7vqdKSsAYWzf/r9kKVJYTZnGp6jODCGq0Sb7VCANWSmkMseJQ= X-Received: by 2002:a05:600c:83cf:b0:434:f7e3:bfa0 with SMTP id 5b1f17b1804b1-4361c3e351fmr15399155e9.21.1733913381718; Wed, 11 Dec 2024 02:36:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IGNf5j4PJpASOxGSwj+YguIMmjZ0pycqSYzw0a/l9/Dpu6gK2OQfrnWR1JnjcACpnpyDYwVBA== X-Received: by 2002:a05:600c:83cf:b0:434:f7e3:bfa0 with SMTP id 5b1f17b1804b1-4361c3e351fmr15398945e9.21.1733913381399; Wed, 11 Dec 2024 02:36:21 -0800 (PST) Received: from [192.168.188.25] ([80.243.52.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434f063357csm137563265e9.22.2024.12.11.02.36.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2024 02:36:20 -0800 (PST) Message-ID: <570332c8-fd8d-4447-9091-00244b0db164@redhat.com> Date: Wed, 11 Dec 2024 11:36:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] treewide: Dodge dynamic memory allocation in strerror() from glibc > 2.40 To: David Gibson , Stefano Brivio References: <20241210232909.1034903-1-sbrivio@redhat.com> <20241211014641.27e438ca@elisabeth> From: Paul Holzinger In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yuMaM_kKDR1L5V3cspNb230a8lsMYzsa3PRr-q6zfLc_1733913382 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: IPYOQ4QHTGXD7CSP25KCUKCBE5V4Y5JZ X-Message-ID-Hash: IPYOQ4QHTGXD7CSP25KCUKCBE5V4Y5JZ X-MailFrom: pholzing@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/12/2024 04:55, David Gibson wrote: >> I wonder if ignoring the locale is really that bad. After all, we print >> all the messages in English, without localisation. Printing the error >> description in other languages is arguably inconsistent. > Hm, I guess. Maybe we can tackle respecting locale for the kernel > library errors when/if we add localisation support for our own > messages. As German who has a few systems with a German locale configured I prefer it when the locale is ignored in such cases. Getting a mixed English/German error text always looks wrong and I much rather have it only in English. But then again I understand English and these error messages well enough already so users who do not might feel differently. -- Paul Holzinger