From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id AE3615A0275 for ; Fri, 8 Mar 2024 12:11:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709896271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VNe2V2NByvCajUgF6AFxApwNXJ0v7wawRU4a9gNdz3E=; b=DZRQWQAbimdSZb2JUU3/9cv+CgXJR31XYrUIXBzKsdzS+y8YYtlyoQ8FVpUfXsLci/6BS1 kcmrEslrPHBsUtPWA5J8gdQZouFsNJlAZQCGoYzG0u83ige4b8LFhva9Wk9+uPDy02Aoak dRrQ+CTBRvABOj3uSNCfJI9xH1g0ahI= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-18hDrbsMNkSSdBEDO10SfQ-1; Fri, 08 Mar 2024 06:11:09 -0500 X-MC-Unique: 18hDrbsMNkSSdBEDO10SfQ-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-5133f5243d7so818483e87.1 for ; Fri, 08 Mar 2024 03:11:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709896268; x=1710501068; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VNe2V2NByvCajUgF6AFxApwNXJ0v7wawRU4a9gNdz3E=; b=NdAXP5KwVvrqtLLh7abG/8e0oQi3nnz2l3i016Yvb84dqhYur14iaRSTUJo7z3CIap J/0pP9yClakju2LNH3JJqqKDMMnInNKcrnI8xLihxvsYfY9cUkMHr8H34S63LxYFtG4d vuFpWdeTw6J0n1xAlze9eJHjDCg+GUWga99r+GjIWcz9YOvNm8DW3IREfgbcUIg0uD3g 6ZdKj/i0GcShjmunlRT5wuGlTSAvZR5jOxc7bSw85vI9FvLAM/rMAzDlxCLZpZJEHXvu uI9hAzTVV9MK9IaVsISRHRQYl0x6C4EVmNBeVVUE73VwMOQLk5+pUyU0BbaxH7A0op0v lE6g== X-Forwarded-Encrypted: i=1; AJvYcCX8GlFS1APSqu5xJQqeVJZ2m4Mtn8pM/cAShp6TAP4AnOAX77lVrPV2gTlcf5Np9not5Nu2B73WbU8hcx8a7WEvIsB+ X-Gm-Message-State: AOJu0YxqsNXkUknUTUe3q5DqMup9SU5wP4hcxNSWYbeEOx1R4GcauFgI Zz/LEqWy4Btao/7f4n8PRSzGT1gsFCoWD3OGUFaia8PwNh1tdmRfIBHMrt5kDKBKOLN6P95SGkU RTm8Xxnf2jsMHUEimxOgoW4zCi2fPkFTmTxtx7UiYTMayx2yzgw== X-Received: by 2002:a05:6512:3606:b0:512:c985:4890 with SMTP id f6-20020a056512360600b00512c9854890mr2875085lfs.67.1709896268561; Fri, 08 Mar 2024 03:11:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IGXdGdxiLoIcYsq52MPdBz3cRaqasDUT6bjYoNnIQNDr3WCOH14FZaYiGDnhdk6qIUVwSk7Kg== X-Received: by 2002:a05:6512:3606:b0:512:c985:4890 with SMTP id f6-20020a056512360600b00512c9854890mr2875064lfs.67.1709896268024; Fri, 08 Mar 2024 03:11:08 -0800 (PST) Received: from [192.168.188.25] ([80.243.52.133]) by smtp.gmail.com with ESMTPSA id q13-20020adfcb8d000000b0033ce06c303csm22470306wrh.40.2024.03.08.03.11.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Mar 2024 03:11:07 -0800 (PST) Message-ID: <5ec2bef6-01bc-4de2-ab76-02a08dfaf03a@redhat.com> Date: Fri, 8 Mar 2024 12:11:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] conf: Don't warn if nameservers were found, but won't be advertised To: Stefano Brivio , passt-dev@passt.top References: <20240307232551.1828628-1-sbrivio@redhat.com> From: Paul Holzinger In-Reply-To: <20240307232551.1828628-1-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 7OONQCSVF7QHBNOR457Z2UDGLEHQ6KMP X-Message-ID-Hash: 7OONQCSVF7QHBNOR457Z2UDGLEHQ6KMP X-MailFrom: pholzing@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks Stefano On 08/03/2024 00:25, Stefano Brivio wrote: > Starting from commit 3a2afde87dd1 ("conf, udp: Drop mostly duplicated > dns_send arrays, rename related fields"), we won't add to c->ip4.dns > and c->ip6.dns nameservers that can't be used by the guest or > container, and we won't advertise them. > > However, the fact that we don't advertise any nameserver doesn't mean > that we didn't find any, and we should warn only if we couldn't find > any. > > This is particularly relevant in case both --dns-forward and > --no-map-gw are passed, and a single loopback address is listed in > /etc/resolv.conf: we'll forward queries directed to the address > specified by --dns-forward to the loopback address we found, we > won't advertise that address, so we shouldn't warn: this is a > perfectly legitimate usage. > > Reported-by: Paul Holzinger > Link: https://github.com/containers/podman/issues/19213 > Fixes: 3a2afde87dd1 ("conf, udp: Drop mostly duplicated dns_send arrays, rename related fields") > Signed-off-by: Stefano Brivio Tested-by: Paul Holzinger