From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 39A3E5A0082 for ; Thu, 16 Feb 2023 17:34:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676565291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZrFMSQV2a0+6L12xL/61O0qOqefiDRLddJDZbeY4flY=; b=LueqOhWcGurCsyARkKb2QAKv5315oQ6FayeEW+nmCnLZEUkFdibI8K1xpvrLP0QVOjqjEe hvxDbOlmvnJOwqqtrAR/mpYXzEtSPfpgAnbR8TuZ0IMrawuLttrQQL3tU20xYvy44grfNK 84zvzYj/IXLDdh+mYnky9Vy/foQ7uy8= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-652-nsQLUILwMHKi_ZJINoQVEg-1; Thu, 16 Feb 2023 11:34:49 -0500 X-MC-Unique: nsQLUILwMHKi_ZJINoQVEg-1 Received: by mail-qv1-f72.google.com with SMTP id ng1-20020a0562143bc100b004bb706b3a27so1362587qvb.20 for ; Thu, 16 Feb 2023 08:34:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZrFMSQV2a0+6L12xL/61O0qOqefiDRLddJDZbeY4flY=; b=Uk1wtDjC3ns1nasuyHF8tLvzIF1+119byJhb5iIbt6gGzvWfLkhcEGFP23lotf941e kX2h62YLIe/AQJr7HFgsbS15pV6P/RuGJY8b9PNt2uybMMhBidG/N5Cp1uBE84HXkTBR dy7NdQrU3BYuNtrrI+rc34zhO5gsmgh6LbtFP8LbLveAOrwGE8rdIoSyAb/VJPycpz7c yQBFHjdVQFvQHUckyLrkYr5x+hJVJu8SetwpaW+j7xaK7dpmgQ5ixMy0gth6tbg9pZfX jrTXfrepFdaThPEBDFDqHeLHA0CG8aENxt4fovJ+9GYVfs3KmqxJiyOu2CwFQZr5rzaU ysVA== X-Gm-Message-State: AO0yUKXt7pjK164Df2HtPcPgQPUEN7ijoOr6bzXA3RhOY97eIcQdeMeC hMoB4MG/DRUEhRLkKRDxGe15PGyUxWvaTEEzKGijfpG61FDQ9rtQASeiFmNG7bC7OWPrW+rOIht TRu1zcJP42uPs+sQ3fA== X-Received: by 2002:a05:622a:551:b0:3a9:81f0:d8e9 with SMTP id m17-20020a05622a055100b003a981f0d8e9mr10614518qtx.68.1676565288599; Thu, 16 Feb 2023 08:34:48 -0800 (PST) X-Google-Smtp-Source: AK7set/qflN0QitpY++7FAb3pWceWi/4q3yV3/Vnjx51q8G34uWuC+Y5lJyv72fB7YvYqjTtR1tSyw== X-Received: by 2002:a05:622a:551:b0:3a9:81f0:d8e9 with SMTP id m17-20020a05622a055100b003a981f0d8e9mr10614497qtx.68.1676565288384; Thu, 16 Feb 2023 08:34:48 -0800 (PST) Received: from ?IPV6:2600:8805:3a00:3:3b4f:6d3c:92c4:a5c7? ([2600:8805:3a00:3:3b4f:6d3c:92c4:a5c7]) by smtp.gmail.com with ESMTPSA id i12-20020ac860cc000000b003b848759ed8sm1492227qtm.47.2023.02.16.08.34.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 08:34:48 -0800 (PST) Message-ID: <6082df91-6fec-698d-dccb-d46ce3c610b7@redhat.com> Date: Thu, 16 Feb 2023 11:34:47 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 1/5] qemu_passt: Avoid double daemonizing passt To: libvir-list@redhat.com References: <4fa71e685d69f496d481ef51157c1ffa4c85166d.1676554196.git.mprivozn@redhat.com> From: Laine Stump Organization: Red Hat In-Reply-To: <4fa71e685d69f496d481ef51157c1ffa4c85166d.1676554196.git.mprivozn@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: QYP5BP3D3LBRMQHHFWKDA4ZOKJK4TRX2 X-Message-ID-Hash: QYP5BP3D3LBRMQHHFWKDA4ZOKJK4TRX2 X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, passt-dev@passt.top, Michal Privoznik X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/16/23 8:32 AM, Michal Privoznik wrote: > When passt is started, it daemonizes itself by default. There's > no point in having our virCommand module daemonize it too. > > Signed-off-by: Michal Privoznik Reviewed-by: Laine Stump > --- > src/qemu/qemu_passt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c > index 78830fdc26..adc69fc052 100644 > --- a/src/qemu/qemu_passt.c > +++ b/src/qemu/qemu_passt.c > @@ -156,7 +156,6 @@ qemuPasstStart(virDomainObj *vm, > virCommandClearCaps(cmd); > virCommandSetPidFile(cmd, pidfile); > virCommandSetErrorFD(cmd, &errfd); > - virCommandDaemonize(cmd); > > virCommandAddArgList(cmd, > "--one-off",