From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 8730D5A005E for ; Wed, 15 Feb 2023 08:06:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676444767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i6Nk+Q/JwlQ/L/bBO18kncAhEmtSDVU3eLw9gfy6aCM=; b=Vb5EyGBGcrdFr4GL3ACnIvd+5wy0Aa84cP4+7XzR7eHIKN2bICZlpdl+e3O9FR1AtQp054 mWj5qSw8QG+4+sxhkUJzIDdVdYm7zlAfjQ6LTey9Nde6FR34nbsGOa0EyVkRpnFc5GiHmt pki3p+xAIH62eCDxqGMnz+h+xUwZJW0= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-70-2UIZRY09N3WgFGrMRJZidw-1; Wed, 15 Feb 2023 02:06:06 -0500 X-MC-Unique: 2UIZRY09N3WgFGrMRJZidw-1 Received: by mail-qv1-f69.google.com with SMTP id c10-20020a05621401ea00b004c72d0e92bcso10040898qvu.12 for ; Tue, 14 Feb 2023 23:06:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i6Nk+Q/JwlQ/L/bBO18kncAhEmtSDVU3eLw9gfy6aCM=; b=oB3m/HTrwnL7KqJuKRa84J8BVRhAsOWTtLRjandvY8DWQ389wAVFXDzyMhPR2QDdSb sL1P5ZV80NT7tDT3xf93sf9puRLm2poU7XgIOt26lof1/zyfAxebPY789TeWfWQhoNjj MHzixr1b5ywmnY/OqVloxR1IG2LzBoVyL6c2ivOtYC7KC47wt0pBAWJ/DxDGW65UU2Lm 0/E1UA9fEv1G5miNbZM7zY1iC0PY0cc95X+9YzvnNLM1bTbDuE5PJzRQGlwxbmNoFig+ XYbfIwyd57xFMzZnWOURhH6gACNR3tumxPwwCxkyS78qYjnUw1zWGFBkEybgApAXCOuQ mp+g== X-Gm-Message-State: AO0yUKUuuk6lXLD5XUrBP0QT8IU2D7XzoyGwSrt8q8siO7HOyaosZD/H tFR8FL8eERDmJzLBxinhjYZF6qNkFJt/Sg3I0vZGFMNDhPZ8JcaTi4R1yqhw/swrjoRHRcdFOeW OAyVDDSbtLSMl X-Received: by 2002:ac8:5a53:0:b0:3b8:2ea9:a08d with SMTP id o19-20020ac85a53000000b003b82ea9a08dmr1716077qta.52.1676444765884; Tue, 14 Feb 2023 23:06:05 -0800 (PST) X-Google-Smtp-Source: AK7set8h1HIAx5UPmfO+20IIBXZ/sDgJ8CQS5SCbxaDZCayI8ABHfLBXXUb87zJUW+M1TI7/4QBWBA== X-Received: by 2002:ac8:5a53:0:b0:3b8:2ea9:a08d with SMTP id o19-20020ac85a53000000b003b82ea9a08dmr1716042qta.52.1676444765345; Tue, 14 Feb 2023 23:06:05 -0800 (PST) Received: from ?IPV6:2600:8805:3a00:3:3b4f:6d3c:92c4:a5c7? ([2600:8805:3a00:3:3b4f:6d3c:92c4:a5c7]) by smtp.gmail.com with ESMTPSA id h19-20020ac87453000000b003b9a6d54b6csm12482433qtr.59.2023.02.14.23.06.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Feb 2023 23:06:05 -0800 (PST) Message-ID: <62829291-8e9f-68ed-d58c-8ff0ee858256@redhat.com> Date: Wed, 15 Feb 2023 02:06:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/4] Revert "qemu: allow passt to self-daemonize" To: libvir-list@redhat.com References: <77f3fc97d2343f25b85a2cc2295fc6f022c984d7.1676374699.git.mprivozn@redhat.com> From: Laine Stump Organization: Red Hat In-Reply-To: <77f3fc97d2343f25b85a2cc2295fc6f022c984d7.1676374699.git.mprivozn@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: CYSN4C3JNR7UC7R46AJ7YKKNPP53VRNG X-Message-ID-Hash: CYSN4C3JNR7UC7R46AJ7YKKNPP53VRNG X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, passt-dev@passt.top, Michal Privoznik X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/14/23 6:51 AM, Michal Privoznik wrote: > This reverts commit 0c4e716835eaf2a575bd063fde074c0fc7c4e4d4. > > This patch was pushed by my mistake. Even though it got ACKed on > the list, I've raised couple of issues with it. They will be > fixed in next commits. I admire your optimism :-) > > Signed-off-by: Michal Privoznik Reviewed-by: Laine Stump > --- > src/qemu/qemu_passt.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c > index f640a69c00..0f09bf3db8 100644 > --- a/src/qemu/qemu_passt.c > +++ b/src/qemu/qemu_passt.c > @@ -141,23 +141,24 @@ qemuPasstStart(virDomainObj *vm, > g_autofree char *passtSocketName = qemuPasstCreateSocketPath(vm, net); > g_autoptr(virCommand) cmd = NULL; > g_autofree char *pidfile = qemuPasstCreatePidFilename(vm, net); > - g_autofree char *errbuf = NULL; > char macaddr[VIR_MAC_STRING_BUFLEN]; > size_t i; > pid_t pid = (pid_t) -1; > int exitstatus = 0; > int cmdret = 0; > + VIR_AUTOCLOSE errfd = -1; > > cmd = virCommandNew(PASST); > > virCommandClearCaps(cmd); > - virCommandSetErrorBuffer(cmd, &errbuf); > + virCommandSetPidFile(cmd, pidfile); > + virCommandSetErrorFD(cmd, &errfd); > + virCommandDaemonize(cmd); > > virCommandAddArgList(cmd, > "--one-off", > "--socket", passtSocketName, > "--mac-addr", virMacAddrFormat(&net->mac, macaddr), > - "--pid", pidfile, > NULL); > > if (net->mtu) { > @@ -263,7 +264,7 @@ qemuPasstStart(virDomainObj *vm, > > if (cmdret < 0 || exitstatus != 0) { > virReportError(VIR_ERR_INTERNAL_ERROR, > - _("Could not start 'passt': %s"), errbuf); > + _("Could not start 'passt'. exitstatus: %d"), exitstatus); > goto error; > } >