From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ba98DG75; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id B71495A0262 for ; Fri, 21 Aug 2026 14:56:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787317005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UoA7TLMD+YYNd+tJ0cDNO7DgJ2r/1huga9k81bmTjvc=; b=ba98DG750fl65bRkUAOT9/BDEg2zVpOT4qhcqThheCjo9LINz/txyX9jn4Leg8KJnJAJMd akMfzNFkLPsdZHaQNqQmlkm0c+SsmgiN6c/6Y9XXjgE4maSkbIBaBtRYtFd9pXTjzwInsE ili1Ni/BiaxBBcsDfER3SpR3GJ7AMrM= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-zj0Gr93TOCelZJlfarkuNw-1; Fri, 21 Aug 2026 08:56:34 -0400 X-MC-Unique: zj0Gr93TOCelZJlfarkuNw-1 X-Mimecast-MFC-AGG-ID: zj0Gr93TOCelZJlfarkuNw_1787316993 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-c20e5890680so85160166b.1 for ; Fri, 21 Aug 2026 05:56:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787316993; x=1787921793; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UoA7TLMD+YYNd+tJ0cDNO7DgJ2r/1huga9k81bmTjvc=; b=iBD/iA/LRJSfccD/zc6v5zBsiDq6OmQtBRC4ygalAq++EHtoPHA7H1ZSevQVk4yW2U coU0QUkjT92XwOni+udjtLPdEsivpLGXfbQ4oGty8ndECTXcv6/wDs9FElkY2RYBR1Vp QC3iBBJipQSK6952QQuKTzX+swUygzqEkxNBN6iKPDmQnFoVYiktZepxa34YO4xqc+TL vrMNjg5O5NOKGSQomz0mT9YnxCBmXH/YN0wL5TiFp38YXFzUqKcEqeCX6lt0DaAmPpnt rvK3APPwoJJAzVBRrfJcXQIcyJ08k7iSAhinnIOBAQwlxclOVpT/Bn1fIFAX47LhExcA uuXg== X-Forwarded-Encrypted: i=1; AHgh+RrDtC9sppD2LZxwouOrmKoa+QgL1qofCDuBkvr8lVEH/zrcs5WP3slCBzTcTJgUue08xusEOuPMqzs=@passt.top X-Gm-Message-State: AFuF++k96loYh+aqCd72tB6ELpK8X8EKkBnr4ZRFkJXTQbu//Ld8K76t 5sZCTqjrs+1dPt+3mx7Cf3AZErwrpUBWlNo9Jv58YTRUo5E8AMBYgerMYHojpFL8xbX8XIwSlOi +1Mt18S+kr9xyhAiTlsY7h3EqypI3BMTHvhj6516rrkz24rB39HnYXA== X-Gm-Gg: AR+sD11c6G1vlkWU63gHW8fIqnxliaOFYeLvLOQif7xehgSkj6m72yhwVQD0lJPdMiA erc4sEYlBcBhqVbQPNSEsAw0Or5YLPgVnXX/nwS87xL9RPbHxTHGnw4ZZwCkopIVBjhkwC9yKAe IwHYgUwO3kisT1uoxU8U1tgQPDjM4ZhZNSXOikfCwyTRHFDBkEnhgFlf5wvN63nbtIYOfUxFALJ Zrxoo1g0ZQg/QRklwa2SSyLuOR4gybSHU+zzvBXn7lrK5ddyA5abcZiwruiV5elher0kVYRjT/L GjhoPhI+CrG0s5pCucMSANzZEHSXBE5c/7QSGMydJq4pvtHc03uaOdDd2IZU/kXELg7nI+g6HWZ G9KgKhJo8EG9cTlgXI23haYQGoAVEMeD5RqTKc3wTQsbS X-Received: by 2002:a17:907:c789:b0:c16:831c:427d with SMTP id a640c23a62f3a-c246a736bfdmr738143466b.21.1787316992984; Fri, 21 Aug 2026 05:56:32 -0700 (PDT) X-Received: by 2002:a17:907:c789:b0:c16:831c:427d with SMTP id a640c23a62f3a-c246a736bfdmr738135066b.21.1787316992567; Fri, 21 Aug 2026 05:56:32 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:d92c:7e4a:47e6:1b23? ([2a01:e0a:e10:ef90:d92c:7e4a:47e6:1b23]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2458b648f9sm443396966b.28.2026.08.21.05.56.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Aug 2026 05:56:32 -0700 (PDT) Message-ID: <63544f72-d8b4-4cc7-9975-3ecb318ae984@redhat.com> Date: Fri, 21 Aug 2026 14:56:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] util: Add missing O_CLOEXEC for !HAS_GETRANDOM path To: David Gibson , Stefano Brivio , passt-dev@passt.top References: <20260821050403.170891-1-david@gibson.dropbear.id.au> <20260821050403.170891-4-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260821050403.170891-4-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qZwDoksZCS8xioQkbR4NUIT2_V46wPB57UruIs_JYxA_1787316993 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 7O5GA57V3RUF7EYRWCHURIIGDKL7GPPJ X-Message-ID-Hash: 7O5GA57V3RUF7EYRWCHURIIGDKL7GPPJ X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/21/26 07:04, David Gibson wrote: > It rarely matters, since we usually have getrandom(), but in case we don't > our open() of /dev/random was missing O_CLOEXEC, which can cause clang > warnings. > > Signed-off-by: David Gibson > --- > util.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util.c b/util.c > index 500e8f55..df972a05 100644 > --- a/util.c > +++ b/util.c > @@ -964,7 +964,7 @@ void raw_random(void *buf, size_t buflen) > { > size_t random_read = 0; > #ifndef HAS_GETRANDOM > - int fd = open(DEV_RANDOM, O_RDONLY); > + int fd = open(DEV_RANDOM, O_RDONLY | O_CLOEXEC); > > if (fd < 0) > die_perror("Couldn't open %s", DEV_RANDOM); Reviewed-by: Laurent Vivier