From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=N6d/rDJK; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id B1D885A0262 for ; Tue, 05 May 2026 12:26:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777976798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VysoA+X+GieXKNwGlbek5rGJ1Q/OufNMnM5S5EDr7ls=; b=N6d/rDJKILawPp5tbEh2FYbnG3ItEV2YrJCo2nVMHoPiKE7xJQbyoItk9kb0sNQR828UXW Mvt6JZr2nSwMVY5uJY0IhKQMkWmADiZvyg5UwXN7yUAUxrWXGBIz58KR5gdCcOFYvb8uNs R+Cs+nSdsY4lGnemoZ5ij4/eiyFeZD4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-3NJiOkyANFiyPtx709K5nQ-1; Tue, 05 May 2026 06:26:37 -0400 X-MC-Unique: 3NJiOkyANFiyPtx709K5nQ-1 X-Mimecast-MFC-AGG-ID: 3NJiOkyANFiyPtx709K5nQ_1777976796 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-488bd1ee9e7so52627315e9.1 for ; Tue, 05 May 2026 03:26:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777976796; x=1778581596; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VysoA+X+GieXKNwGlbek5rGJ1Q/OufNMnM5S5EDr7ls=; b=LZxtf31Etzx5YJ6STFwq3QNWXNeCxXCJIwVj66scokyglJG82sSJ7J52zZOs7KRT47 6SSBisTJoiHJLr3sYz94j/sXe+J9pqLDlioi+HUyXt7RFn6iI97FUnIEnGjGDFxGfzwG kTL/uZoMae/AAIkJkl3/S5N8thRywNE3L+Fw42NVqey6K7YJZVXuoMeFVTo4QBsfEzhU HAi8mwc3koU/qeka63CwYoUvSKUCifBrZahf3c5tYzV3VJNhYaOenRUiPj+aA26dyQr7 gL6BwwjPkibZuhX+fqzLDdG8LFLayG5qSxMXNQvS6bcosWY2g1GQjefSmF4iaG4xbsio ofxw== X-Forwarded-Encrypted: i=1; AFNElJ/IgJzUoWl6GEHVEun9QpLVHZXtfvtHbP/CcMB5ml+a0ktJpAa2XfJm7PqgS4kjOvW4ywl6zW7fpRw=@passt.top X-Gm-Message-State: AOJu0YyCF4wW2BfFNDdwqtqCLMBMxJ3el3nMbOfNGV9RvoS2PXD2d54c zyw2T7en9OU8BppxRYDoWy5V2ZB7xT5/lZI0qlG+m20UPWuhDqo/QcEXXMMxq/ck35ee2l5H+6H YNhGtn3OrcmbcLNy3wU9I08q8S5qdR68YIUKyVT49WiqRe4EP3pmvqUtUoyvbVQ== X-Gm-Gg: AeBDievLXXFj1zBxMe9v+NVlq2JJ2XokXTNiduu3t+3NbX4CwgI7ewIWPZP3BGYVvbR KuH74zkT1UwM1pb7gRoYfmk2q4eqE3ztH19estGRPhAeNqjZw0LfvVJFYLCit5d3rieRGrg1EDE EOtfV7Mq4zWytqPyney6wWreF2rdw7zZjgoWNSNqThALtzbNq8CVUfJ2hB48d6pZnwrX77LY3Yh j00M+qeX7Rix9e+LCBBEYYdwDh8ce0jTdZQKgcNbSSjMGccBSlz87DbjoKjN9gtAiCZyrQ6FZf7 mLxwSqSgeZndbvI0XOwEyeV/4UnYBM4aUWSV9mFI76BbhT9/gAIUcdG3j/fdeILNLXw8a4KH7j6 z7CfXCE54YZnGFxOJX957j5Lp8jD7KhGzb6HsmSY2QL98qTUTsJKJX2WngjA1/EJHPQ== X-Received: by 2002:a05:600c:45d4:b0:489:1c5f:3a9e with SMTP id 5b1f17b1804b1-48a9865e17dmr210270855e9.13.1777976795856; Tue, 05 May 2026 03:26:35 -0700 (PDT) X-Received: by 2002:a05:600c:45d4:b0:489:1c5f:3a9e with SMTP id 5b1f17b1804b1-48a9865e17dmr210270515e9.13.1777976795415; Tue, 05 May 2026 03:26:35 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45055d381c8sm3380155f8f.33.2026.05.05.03.26.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 03:26:35 -0700 (PDT) Message-ID: <65d63440-f582-403c-977a-5a105b5a3462@redhat.com> Date: Tue, 5 May 2026 12:26:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/13] cppcheck: Split out essential defines into a BASE_CPPFLAGS variable To: David Gibson , Stefano Brivio , passt-dev@passt.top References: <20260421032338.1909084-1-david@gibson.dropbear.id.au> <20260421032338.1909084-3-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260421032338.1909084-3-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4BfdHzHdm-bcUapHRxAONaJlU5_5dyGRV1Qpa09slpg_1777976796 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: AHXEDMCAL4ELZYQVVVNARHDFLD2HQCIF X-Message-ID-Hash: AHXEDMCAL4ELZYQVVVNARHDFLD2HQCIF X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/21/26 05:23, David Gibson wrote: > Our cppcheck target need certain flags from the compiler so that they it > can analyse the code correctly. Currently we extract these rather "so that it can analyze" > awkwardly from FLAGS / CFLAGS / CPPFLAGS. But this means we inhibit one > of cppcheck's features: by default it will attempt to analyse paths for all > combinations of compile time options, not just a single one. > > Analysing *all* paths doesn't work for us because many of the -D options we > use are essential to compile at all, so unless we supply those to cppcheck, > overriding the default behaviour we get many spurious errors. At the > moment, however, we give cppcheck *all* our -D options, including > conditional / configurable ones, not just the essential ones. > > All cppcheck really needs here is those essential -D options. Split those > into a separate variable, and use that directly rather than the clunky > $(filter) expression. > > Signed-off-by: David Gibson Reviewed-by: Laurent Vivier > --- > Makefile | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/Makefile b/Makefile > index 17e70d22..0de98375 100644 > --- a/Makefile > +++ b/Makefile > @@ -30,11 +30,15 @@ ifeq ($(shell $(CC) -O2 -dM -E - < /dev/null 2>&1 | grep ' _FORTIFY_SOURCE ' > / > FORTIFY_FLAG := -D_FORTIFY_SOURCE=2 > endif > > +# Require preprocessor flags we can't build without > +BASE_CPPFLAGS := -D_XOPEN_SOURCE=700 -D_GNU_SOURCE \ > + -DPAGE_SIZE=$(shell getconf PAGE_SIZE) \ > + -DVERSION=\"$(VERSION)\" > + > FLAGS := -Wall -Wextra -Wno-format-zero-length -Wformat-security > -FLAGS += -pedantic -std=c11 -D_XOPEN_SOURCE=700 -D_GNU_SOURCE > +FLAGS += -pedantic -std=c11 > FLAGS += $(FORTIFY_FLAG) -O2 -pie -fPIE > -FLAGS += -DPAGE_SIZE=$(shell getconf PAGE_SIZE) > -FLAGS += -DVERSION=\"$(VERSION)\" > +FLAGS += $(BASE_CPPFLAGS) > FLAGS += -DDUAL_STACK_SOCKETS=$(DUAL_STACK_SOCKETS) > > PASST_SRCS = arch.c arp.c bitmap.c checksum.c conf.c dhcp.c dhcpv6.c \ > @@ -195,6 +199,4 @@ CPPCHECK_FLAGS = --std=c11 --error-exitcode=1 --enable=all --force \ > -D CPPCHECK_6936 > > cppcheck: $(PASST_SRCS) $(HEADERS) > - $(CPPCHECK) $(CPPCHECK_FLAGS) \ > - $(filter -D%,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) $^ \ > - $^ > + $(CPPCHECK) $(CPPCHECK_FLAGS) $(BASE_CPPFLAGS) $^