From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=fail (p=quarantine dis=none) header.from=redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 9F70A5A0265 for ; Tue, 17 Nov 2026 14:16:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794921363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1/PaJh4/cxZA5iMcCkZ48V7VKZGugpsOvWlQoVWDjE4=; b=O/kgdrEb4O2N1IL/ciVUNvEZdfo8Gx3Jucsu34r+nUTUnwnvWF+Mqtl+SSUHHZz5hfN8Qn YvW5sEWCz4MEdlo9WoAJ7SxOey9T1MLPVHYgtGP1tY6MHePWTdqPpAqJ5d5ruJyMRzegsv Lq92akJdrYsA5o6jtZbhB00qaqb/gbk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-576-qxfXphxeOXC8z-4iJY3mQw-1; Tue, 17 Nov 2026 08:16:02 -0500 X-MC-Unique: qxfXphxeOXC8z-4iJY3mQw-1 X-Mimecast-MFC-AGG-ID: qxfXphxeOXC8z-4iJY3mQw_1794921361 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4925ef75fc4so2703473f8f.1 for ; Tue, 17 Nov 2026 05:16:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794921361; x=1795526161; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1/PaJh4/cxZA5iMcCkZ48V7VKZGugpsOvWlQoVWDjE4=; b=JaoKnaRx4ZFqah5rled3W6dE5IHHg8B0hfwN99n97OdjbLRC2OBOTQxWC660a2fwel 75yKiLYkWtgIeUh4D9EYTxjhj7gHXZQ3d3AEHPNH+IvWIuAV3KIHpQvEX96DbMr5K0KT LhvXVaKG7eVjxLXkG/a5eI9cOa41ymVZFi2XPWysH211gC1U/Lc/LpBxf6rpYwvh04Gk Kf8hBPeUG4rdtMrB26BsNH2UZpQyvXl+eU8A9UhTXC/wTTEZfeivH6EKwb/1h1U5nOmh tQlfcNAIYXeZiLdZ3S78Rpjlx8qtRgS06+0Noc3CsdJ/5nmDYvj1DyI96mH42O2R0uue qwGg== X-Forwarded-Encrypted: i=1; AL+hErFQfY+bLqaN1CweKnBzGicL34qOqxCrYK/mxnbgY1xkJuSCP5A/N+nybeQA/0AAvwJ5784DX8wO9NM=@passt.top X-Gm-Message-State: APuU4Z+wM00MIjCPOmLwHET6rR6n10s5JFVy/MNCqzFJMrQ3Jk20LCRr 5aPoCM2HLCDlRCQU3j8vMNmiHpF8YvYwQQ0p42rTUFR5QY1vUFxHIwuvbDKVe7z+dT/y1eJvFHN HztujUGklqbmSaJe1n5iuHxqsL6nqSjKf6mRX5xGk8HQAc8yE5vKzgg== X-Gm-Gg: AZFdTZcwjzevavMQo+2lqYtEsinIQXe501Mltbg7he7utQw1+C5Y9eX8l453qwT1NIB dJE7148dTn+L48ZbiYuXh/QvzyvwyYBGxTJcMZTE32S+W3FAle8cK0Zm8UoQo8FlP0prT7SU+Aw NV7TPpo/ttB5SPqvpwsAjvjJrZLgbMazeeuxpfZuKu8ZVlWobkjii9dgxi1HU93IzJEpHv8XMKO RiPN55E54Ux26StMggp2cqcRMSPokwzcqDhw/TG8Ae/VUubvSHS70XKFtsLV/rXbpH5bDcJCvAB ZdvGxVFyJN6tOsEeZzUTKHw2QTL3JPn8nxozY8loHBzYJBwa4UiQz0cvGGf84zPL0YR0JoA4oPs eutPOhzLuRFI+wfvDOTm/cOZtCxVZG8f7zOYT3l1oem1ARLHPdssczRZxxkR9FHr5ixZ1WBkcTZ ARe0hdhyxTcbXAzxdL X-Received: by 2002:a05:6000:29ce:b0:48d:e101:5707 with SMTP id ffacd0b85a97d-49c70ed9147mr20912487f8f.13.1794921360909; Tue, 17 Nov 2026 05:16:00 -0800 (PST) X-Received: by 2002:a05:6000:29ce:b0:48d:e101:5707 with SMTP id ffacd0b85a97d-49c70ed9147mr20912433f8f.13.1794921360433; Tue, 17 Nov 2026 05:16:00 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:e9e7:d9a0:a4eb:dc4b? ([2a01:e0a:e10:ef90:e9e7:d9a0:a4eb:dc4b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a2f61c0989sm6255889f8f.48.2026.11.17.05.15.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2026 05:15:59 -0800 (PST) Message-ID: <6a060132-fb18-44f4-a97d-b549fe966e05@redhat.com> Date: Tue, 17 Nov 2026 14:15:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] pasta: Terminate inotify buffer, skip nameless events in netns watch To: Aditya Merchant , passt-dev@passt.top References: <20261113112114.38764-1-adityamerchant08@gmail.com> <20261113112114.38764-3-adityamerchant08@gmail.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20261113112114.38764-3-adityamerchant08@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QOwzFePfdS1tUhp3wcWXHxJvO72RHu8bAZyRVWIDnvU_1794921361 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: Y5E6OMC7WSWCDIBS52WZI5ELRNDSUBVS X-Message-ID-Hash: Y5E6OMC7WSWCDIBS52WZI5ELRNDSUBVS X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Stefano Brivio , David Gibson , Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/13/26 12:21, Aditya Merchant wrote: > In pasta_netns_quit_inotify_handler(), we compare the name of each event > we read with the base name of the namespace, but we don't make sure that > the buffer we read events into is zero-terminated. Events without a name, > such as the IN_IGNORED we get once the watch is removed, also have no > name to compare: for those, ev->name points past the end of the event. > > Terminate the buffer, as wait_for_socket() in passt-repair does, and > skip events without a name. > > Suggested-by: Stefano Brivio > Signed-off-by: Aditya Merchant Reviewed-by: Laurent Vivier > --- > pasta.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/pasta.c b/pasta.c > index 4cd58fd..5ef678d 100644 > --- a/pasta.c > +++ b/pasta.c > @@ -537,10 +537,13 @@ void pasta_netns_quit_inotify_handler(const struct ctx *c, int inotify_fd) > if ((n = read(inotify_fd, buf, sizeof(buf))) < (ssize_t)sizeof(*ev)) > return; > > + /* cppcheck-suppress [negativeIndex, unmatchedSuppression] */ > + buf[n - 1] = '\0'; > for (p = buf; p < buf + n; p += sizeof(*ev) + ev->len) { > ev = (const struct inotify_event *)p; > > - if (!strncmp(ev->name, c->netns_base, sizeof(c->netns_base))) { > + if (ev->len && > + !strncmp(ev->name, c->netns_base, sizeof(c->netns_base))) { > info("Namespace %s is gone, exiting", c->netns_base); > passt_exit(EXIT_SUCCESS); > }