From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DqO4geGo; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 537AA5A004C for ; Mon, 07 Oct 2024 13:57:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728302264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=d5VIdURVIix0tyZvNI4T1AhJ/gBvn4wa7zBIB20Wd+0=; b=DqO4geGo2YEZpAkGmEJ3+7NIgsvoKrZ86JNk86lt/I1a816DB16anL/y4gcrqU9EAk4mFv ROgHnwP+nc6R8llkrYPHF7CRFD4h/YzF3/kY/nn7I0GysPlR4JY5KQnckNZ2Th2qZMUH4A csL1pXaEbvy8e7rUnAjfblXZs7fH8Q8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-9EMqtygvPH-XIP8W9t5MQQ-1; Mon, 07 Oct 2024 07:57:42 -0400 X-MC-Unique: 9EMqtygvPH-XIP8W9t5MQQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-37cc9b5e533so1821264f8f.3 for ; Mon, 07 Oct 2024 04:57:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728302262; x=1728907062; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d5VIdURVIix0tyZvNI4T1AhJ/gBvn4wa7zBIB20Wd+0=; b=eKo0kX7ZTTOIvpa1WGULx6leEehh290Z2rw0YmG/5CRxyerqk8ljapwEsmzsGT0kNf VO1gx48fB+R8C9+rsmhOHC9oJK6+fN1EzJLXP5U4KCrV+2PlZfji3oS7kh8pUG0dttHu pnK4CiJNLNVxUkW5RC4Z3WNl+MSRLJInR3fs7P9HwDbBhsEt/cA6Fwx23L24Omz5L06a oidYYhjNKmBdokH5vkBUXRpP3jLL9zDfKFRLLNeNzAUZcsEscd9L1pSgHH7cLTg4O/d2 dexgiA9WXRgpqwthxDyRl5wbx+/pwSk845Zh9x+PzOXTw+q8w7q/zbVDZ2UEvTbPdmuH IxSA== X-Forwarded-Encrypted: i=1; AJvYcCWFootNXqM29jAi4zWLG6zeG2SQE/XzdgA8JGf8zXGyVer/2cFktA3xkqJlJVp3+sjUEX8dGmmbJwo=@passt.top X-Gm-Message-State: AOJu0Yzr9EfwrK5UGgiqz9dqyJEs1QDy33mf0YNcG/P1tnm4FZSOk0N0 VmwKdDeZXNVlqwG1Hw9IL9J6PhTXHJTQ5qtfbHRI+HBoFuKk3QwOGb8HuhDOT7IcJ6s59qrHxzy nJelp3NdYgkp7Ty/AKoLROnW0extIMcWAEQrr+DSk5S1odk00/g== X-Received: by 2002:a5d:404c:0:b0:374:c8dd:ea47 with SMTP id ffacd0b85a97d-37d0eb0b38fmr6070020f8f.50.1728302261778; Mon, 07 Oct 2024 04:57:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH6od08nj6tReZFsQIhfxOD9spRtPUQyY1kXVB0lMcFbJ0iRh5GO+h8Qko7+sEWmIB8QlCXGQ== X-Received: by 2002:a5d:404c:0:b0:374:c8dd:ea47 with SMTP id ffacd0b85a97d-37d0eb0b38fmr6070004f8f.50.1728302261386; Mon, 07 Oct 2024 04:57:41 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78? ([2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d1695e395sm5571989f8f.89.2024.10.07.04.57.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Oct 2024 04:57:41 -0700 (PDT) Message-ID: <6a4e01c7-4fc7-4c5a-85d9-7b74b255cff6@redhat.com> Date: Mon, 7 Oct 2024 13:57:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] test: Add tests for passt in vhost-user mode To: Stefano Brivio , passt-dev@passt.top References: <20241001182228.2347208-1-sbrivio@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20241001182228.2347208-1-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 2LUWG7AELNEIA2HEAOBTLT3FBLH7RTAC X-Message-ID-Hash: 2LUWG7AELNEIA2HEAOBTLT3FBLH7RTAC X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 01/10/2024 20:22, Stefano Brivio wrote: > Run functional and performance tests for vhost-user mode as well. For > functional tests, we add passt_vu and passt_vu_in_ns as symbolic links > to their non-vhost-user counterparts, as no differences are intended > but we want to distinguish them in test logs. > > For performance tests, instead, we add separate perf/passt_vu_tcp and > perf/passt_vu_udp files, as we need longer test duration, as well as > higher UDP sending bandwidths and larger TCP windows, to actually get > the highest throughput vhost-user mode offers. > > For valgrind tests, vhost-user mode needs two extra system calls: > statx and readlink. Add them as EXTRA_SYSCALLS for the valgrind > target. > > Signed-off-by: Stefano Brivio > --- > v2: > - oops, add all the files I forgot in v1: test/perf/passt_vu_tcp, > test/perf/passt_vu_udp, and symbolic links > - also run the 'two_guests' case in vhost-user mode > > Makefile | 3 +- > test/lib/perf_report | 15 +++ > test/lib/setup | 77 ++++++++++++--- > test/passt_vu | 1 + > test/passt_vu_in_ns | 1 + > test/perf/passt_vu_tcp | 211 +++++++++++++++++++++++++++++++++++++++++ > test/perf/passt_vu_udp | 159 +++++++++++++++++++++++++++++++ > test/run | 25 +++++ > test/two_guests_vu | 1 + > 9 files changed, 478 insertions(+), 15 deletions(-) > create mode 120000 test/passt_vu > create mode 120000 test/passt_vu_in_ns > create mode 100644 test/perf/passt_vu_tcp > create mode 100644 test/perf/passt_vu_udp > create mode 120000 test/two_guests_vu > Something like this is missing: diff --git a/test/lib/setup_ugly b/test/lib/setup_ugly index 4b2a0774de1d..46089eb9834b 100755 --- a/test/lib/setup_ugly +++ b/test/lib/setup_ugly @@ -33,7 +33,7 @@ setup_memory() { pane_or_context_run guest 'qemu-system-$(uname -m)' \ ' -machine accel=kvm' \ - ' -m '${VMEM}' -cpu host -smp '${VCPUS} \ + ' -m '$((${MEM_KIB} / 1024 / 4))' -cpu host -smp '${VCPUS} \ ' -kernel ' "/boot/vmlinuz-$(uname -r)" \ ' -initrd '${INITRAMFS_MEM}' -nographic -serial stdio' \ ' -nodefaults' \ Thanks, Laurent