From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Cs3HD9ZW; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 1FCB55A0269 for ; Mon, 11 May 2026 15:01:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778504464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7/QW3oryLLYAl7lDCIgZPwkbpmoC5M9XNSy/NO/sS4I=; b=Cs3HD9ZWQ96IA1R7oKH5N0m756Aj34PNKMYs2LJjXGXuMR3eI/xPb00GaQUNY92D748tdr 7FTrRxk1a3voZNz3xGbo0Tib6B9BtvkzBgpLW2NsPHrB+1WF0q8cCI9HfSDQc6liCr8qdf wWwoD8Y0/ryHJcVu1q3EWXKnLzyNLes= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-185-8hWUzlh5MfWiLZrP5OdYsw-1; Mon, 11 May 2026 09:01:02 -0400 X-MC-Unique: 8hWUzlh5MfWiLZrP5OdYsw-1 X-Mimecast-MFC-AGG-ID: 8hWUzlh5MfWiLZrP5OdYsw_1778504460 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48d144d3428so25003305e9.3 for ; Mon, 11 May 2026 06:01:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778504460; x=1779109260; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7/QW3oryLLYAl7lDCIgZPwkbpmoC5M9XNSy/NO/sS4I=; b=LuX7W0LEKmRY1nw84M9Dc4uoWIFT9Ad3/7tmO682WaPWebzD2pVCQuFf2TA5Z+M/p2 2i4WGRBvAINnXbBy0rlDvLvd4HVa1z60Bumerpg8Dhj/tOxChpp59eoapvFAR9VaTPHW hPB3QsotL0rP0xY01AyDyiq58z/acCgRcNQ0+/dsWvhOCEymeaWTUgdY4tsxZEWT/hMc jOLDXzJH3+spBkpCRWJUj+YFaGiI2cHPmTh8abVFE+rjbx7zJ8cX8pgH3mjPyhOjpa/y fRtp5Vloo/ZG+dNdSw1PSkPF0Vu43btkLZOIScvJB8vOKMVELIVzwIgaDx768rXksLRv rv5A== X-Forwarded-Encrypted: i=1; AFNElJ/WN7602kVSiYmnT6pK+rbaPSNctVZ1AZ6a3z1pEvUKLguSfg6sb/yEvW23Eo3K9h2GpGCI5pRt8xM=@passt.top X-Gm-Message-State: AOJu0Yx495medGCwdXxThoY6Kw+C7aRE1GHyqWXO9891v/4olW0wy5d8 PuB446IF+/dER2GWY0J27rIebZxiL9T7S4Cb7CaA1LgSGzGuLbv39b7dtN0LNhN20wuQcn9GZVK mk4/DO662PBkyVJwhJBTi9NnY8ZE+UaTIBpwYYl4NQnyV+/5lFc6N4w== X-Gm-Gg: Acq92OG5w7il/yeXRWKo2Xo4Iqy47xsT5/oa+TPztKnc6DiIkkkDfgfhOUX1/LWWu+S B7HPKpbW2gN6gW1SCfpzQeRgUk7qSxEU2UJMSWaJOQ8yt75AqP0eEMgy7MW4SPEL26FYedLJQTb Ikbpo6jjbcY5MMqbc9019626c831Zo7EDcBQEm/86hBqRv+w9f+tQozuS9t6gH/ySwEUtc7LbN1 vBBecvTw5gsAmrz2jpkJH/d7N3XV+cULhSoDkE0jqfrBDgoiYSOhts0gNXMs6ISUP6AwY5BS5KV Zp8Avm9a3l9Df+ocWB/TcGTOIq9eqHQQlC8d+tTSfcraeLpnexY6pWNsl4N475Ik4MUAW+FEZLW AJWOEeFNw6k/RUL2RqWMH548r8wmYeYeRgbtf3WrlqaypQ5BHBilc2jk= X-Received: by 2002:a05:600d:e:b0:489:ad:7b5b with SMTP id 5b1f17b1804b1-48e706d24e3mr143986665e9.24.1778504459773; Mon, 11 May 2026 06:00:59 -0700 (PDT) X-Received: by 2002:a05:600d:e:b0:489:ad:7b5b with SMTP id 5b1f17b1804b1-48e706d24e3mr143985895e9.24.1778504459263; Mon, 11 May 2026 06:00:59 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-454916df968sm26395454f8f.25.2026.05.11.06.00.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2026 06:00:58 -0700 (PDT) Message-ID: <6afbc473-da79-426c-bb75-4451d3bca20b@redhat.com> Date: Mon, 11 May 2026 15:00:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/8] conf: Fix not-actually-const parameter to conf_runas() and conf_ugid() To: David Gibson , passt-dev@passt.top, Stefano Brivio References: <20260511100322.1016757-1-david@gibson.dropbear.id.au> <20260511100322.1016757-4-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260511100322.1016757-4-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: e73E5iyC0P8rwgsC0usyNroGEwkCjyPOlO7zWjhDJSk_1778504460 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 3WFTGHK32A4JC2M2QE7BPCWENEQWMFV6 X-Message-ID-Hash: 3WFTGHK32A4JC2M2QE7BPCWENEQWMFV6 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/11/26 12:03, David Gibson wrote: > Commit 4af3d83170fd changed the @opt parameter to conf_runas() to a const > pointer, to remove a cppcheck error. However, that error was a false > positive. We *do* modify that parameter via an aliased pointer within it > retreived from strchr(). At least with gcc 16.1.1 that now causes a > "discards const" warning. Revert that change and instead directly suppress > the cppcheck warning. > > Fixes: 4af3d83170fd ("treewide: Fix more pointers which can be const") > Signed-off-by: David Gibson Reviewed-by: Laurent Vivier > --- > conf.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/conf.c b/conf.c > index 4a4ab489..8acf66cc 100644 > --- a/conf.c > +++ b/conf.c > @@ -925,7 +925,8 @@ dns6: > * > * Return: 0 on success, negative error code on failure > */ > -static int conf_runas(const char *opt, unsigned int *uid, unsigned int *gid) > +/* cppcheck-suppress [constParameterPointer,unmatchedSuppression] */ > +static int conf_runas(char *opt, unsigned int *uid, unsigned int *gid) > { > const char *uopt, *gopt = NULL; > char *sep = strchr(opt, ':'); > @@ -977,7 +978,7 @@ static int conf_runas(const char *opt, unsigned int *uid, unsigned int *gid) > * @uid: User ID, set on success > * @gid: Group ID, set on success > */ > -static void conf_ugid(const char *runas, uid_t *uid, gid_t *gid) > +static void conf_ugid(char *runas, uid_t *uid, gid_t *gid) > { > /* If user has specified --runas, that takes precedence... */ > if (runas) { > @@ -1247,7 +1248,7 @@ void conf(struct ctx *c, int argc, char **argv) > uint8_t prefix_len_from_opt = 0; > unsigned int ifi4 = 0, ifi6 = 0; > const char *logfile = NULL; > - const char *runas = NULL; > + char *runas = NULL; > size_t logsize = 0; > long fd_tap_opt; > int name, ret;