From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SUi3R+nA; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id A389E5A0271 for ; Thu, 07 Aug 2025 11:05:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754557550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sFWna7u1HYiS2fQZ/cltVr1IDn9YL7yvntwjVm0fvdk=; b=SUi3R+nAStKNzXtyAT110kB7c3ZSxibyol2lHWv/S830GTkCcqJCdmCkmOg5V0WdhAqS3W 0BgYXLcW9l0cYHKODfX8mX4kB38TtYyqKKFK/CvylkbxEp2h4M9R8zBkDblJTK4YuCl2qP 4jqmwEwPKOOe6A0EBKxD8XUPQy7kyEY= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-4QnCb9LJPcukt0vCedMM-Q-1; Thu, 07 Aug 2025 05:05:49 -0400 X-MC-Unique: 4QnCb9LJPcukt0vCedMM-Q-1 X-Mimecast-MFC-AGG-ID: 4QnCb9LJPcukt0vCedMM-Q_1754557549 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7e7807af588so237903185a.1 for ; Thu, 07 Aug 2025 02:05:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754557549; x=1755162349; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sFWna7u1HYiS2fQZ/cltVr1IDn9YL7yvntwjVm0fvdk=; b=BudtkMqd0YW94x1nz+cnT0fOIUANYGKSbPuywbGnr0O3J+Y0lPMbnvNnwap/vcdF8E yIs+qbPm3p003ZKfKHw/6tt6Z86ZBIFGe9pLGHAdORmVBd8dzBPOOIW6Aph/bUuYrhNJ kJcccHYHB/9XacHe72xY3LxAiSvBWcUUUCpPKISWALRuqQP/eBPOKEZXjc+KtnKDjpXq aqIuVZx+aaY4jI8QG7aS9nAUJ9VJywhUT3ArAhANdLXjpaVzetmLJAk2JJY/taEH6UWJ A8lbORpRtIM9J+O+y9uiIZd9ThetBqaFJJhbRhDENriCzTMxcARx7rcoHTc5sf+xtYT2 OMMA== X-Gm-Message-State: AOJu0YyncC49v9b4+hLkNM/N7BQZf2/nXPtIk37aicSAjtwR/IKQO5Hy IZyptXoTY3I+v5vk97sGwDsL9yK/TrJgWjq26a35tnWq9mxpSqLRncwrFnnVTe7DE7wdd+5P8DM +81/SgV6euSOsVAN7u+gcnum9Mp/9/DyE4AfesdAtoyDklacPpzNxnA== X-Gm-Gg: ASbGncscD+LYVgPtuK/hIOK2+dZKJSbQvf7HUWjas+QulHgg3xZtPGHAZg6KGXAt+tX y8CtfodbxYLvME//XxlkgUNoVLZ9K/Bbz4EdOwDmQRUDsEymZVgs3v+6JWs8pVCjDUfPCwC15h2 cnAG/s0foddmZoG/Um5cScAefE3WDGX2J+GkwcP5NTzC2ueG/W3ekaPTZYW6/FwNlvgsiYAjz0Y uwpRYnq83Q9yQeEBAkt4ey0cVrjPCWddZCR2bAp+J5L1dELVdIv7I+R+plHoc7ztaBmmvBXo5GS oNggv0o9vAwDqfe/uVpAWVR9r7bXIOkRfV7lRT4JKVxGo37/gDGYfowFIPTswpXGL0JDiwoBM6h 4GY1fqEqo X-Received: by 2002:a05:620a:d88:b0:7e3:3d42:6a86 with SMTP id af79cd13be357-7e814d06a5emr1008221385a.12.1754557548523; Thu, 07 Aug 2025 02:05:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpO/1LtBzDtrDetuMDTU/7XeFPPE7l8BMg68xhf5JAqH2+gxJV56NGwXtRhF+X/golVW/z/g== X-Received: by 2002:a05:620a:d88:b0:7e3:3d42:6a86 with SMTP id af79cd13be357-7e814d06a5emr1008217385a.12.1754557547939; Thu, 07 Aug 2025 02:05:47 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e67f5c55a2sm933448885a.36.2025.08.07.02.05.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Aug 2025 02:05:47 -0700 (PDT) Message-ID: <6b6b3834-76a1-449c-93ca-ec6fdea2c84f@redhat.com> Date: Thu, 7 Aug 2025 11:05:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 29/30] packet: Refactor vhost-user memory region handling To: David Gibson References: <20250805154628.301343-1-lvivier@redhat.com> <20250805154628.301343-30-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xgVeyU4U5ReEuEhbMF3uzStpeQ_96eJKL7fG2va2GtQ_1754557549 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 3XZMWKFQXYPLCPCFQBNKKVABTPGXNMYH X-Message-ID-Hash: 3XZMWKFQXYPLCPCFQBNKKVABTPGXNMYH X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 07/08/2025 08:10, David Gibson wrote: >> @@ -437,12 +437,12 @@ static bool vu_set_mem_table_exec(struct vu_dev *vdev, >> r->size + r->mmap_offset); >> } >> } >> - vdev->nregions = memory->nregions; >> + vdev->memory.nregions = memory->nregions; >> >> debug("vhost-user nregions: %u", memory->nregions); >> - for (i = 0; i < vdev->nregions; i++) { >> + for (i = 0; i < vdev->memory.nregions; i++) { >> struct vhost_user_memory_region *msg_region = &memory->regions[i]; >> - struct vu_dev_region *dev_region = &vdev->regions[i]; >> + struct vu_dev_region *dev_region = &vdev->memory.regions[i]; >> void *mmap_addr; >> >> debug("vhost-user region %d", i); >> @@ -484,13 +484,7 @@ static bool vu_set_mem_table_exec(struct vu_dev *vdev, >> } >> } >> >> - /* As vu_packet_check_range() has no access to the number of >> - * memory regions, mark the end of the array with mmap_addr = 0 >> - */ >> - ASSERT(vdev->nregions < VHOST_USER_MAX_RAM_SLOTS - 1); >> - vdev->regions[vdev->nregions].mmap_addr = 0; >> - >> - tap_sock_update_pool(vdev->regions, 0); >> + ASSERT(vdev->memory.nregions < VHOST_USER_MAX_RAM_SLOTS); > It looks like the assertion is changing threshold by one, and I'm not > sure why. It's because previous version was using the last slot to mark the end of the array with a NULL memory region. Now, we have a counter, it's not needed anymore. Thanks, Laurent