From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KPlTWGZf; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 2E4B35A026F for ; Tue, 04 Nov 2025 16:11:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762269095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5xjrMYDAdGM+w/5Q7v285hoiEfqJXTUiwghEge/Ld08=; b=KPlTWGZfm63Hi6MwvIjXDB/Y3C+iZy6/so+tTUiT3D0517S7LLsAOvzfkbMN7K9aHgvUgK yBy3q3PJvwTvsWuFKJzTVpPYO7bpXB9jAKNjc3rW+gl1dc6K3xEchqMAcF9sszhsm9kOh/ wxzDBIIkDGDCmNuEVBV//ycM8hHIglM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-H48bR_OmNqWUXZ99-TiD8w-1; Tue, 04 Nov 2025 10:11:32 -0500 X-MC-Unique: H48bR_OmNqWUXZ99-TiD8w-1 X-Mimecast-MFC-AGG-ID: H48bR_OmNqWUXZ99-TiD8w_1762269091 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-429c9024a1dso1459075f8f.2 for ; Tue, 04 Nov 2025 07:11:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762269091; x=1762873891; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5xjrMYDAdGM+w/5Q7v285hoiEfqJXTUiwghEge/Ld08=; b=Ob0Tx+GKaS94JtQ991AW1wmmTVWGR3Jg4UZv/2y9tzElOsfDGcdnMJtXWgqHTgP49T dR0JpG79j2Rex56ywm1dikvkn6gM9kuiSJFicfpCgKBYlQqKtSnwFPY/ySA8+IlHVRDZ Kp8i3drvZnsRucd+WYL5bZl/W40QMFAZIT5rBPJxMEdTd8YuD0XwSEw2jmRs0F7gsW+s xH3hRWT4wVRsPU86k0lIYjh4kuMUEn2GYhR7D5qliKPMApPUrWs2l1Sw00IJIS6GLEDS 4qkyqadMhGVa3vZfzDxTMS0qa3x4luwYy98nGCu9QbIdbCPTygD3gXMgEVwON4OSPHzX e/LQ== X-Forwarded-Encrypted: i=1; AJvYcCXvfYu4sr1ABq3Xqz92FRcTpVBE5HrcVvhNhkv8vdqT7JLQRSS4JAFS5qMcrhHeDDnPMS66ZMP86cg=@passt.top X-Gm-Message-State: AOJu0Ywz/or8gaMkiOBWi8oL+IUWbRDDtCn5Ya247gV3BsGOSGUe1xbW pARMu+uhnLbhdb7fRqud9BtdHxU+eqcqHLEJLkEE611OvjqSyObelmGGQ1aiQ7cJgqYPxIJsxgf +yfdLiuLuJmUFcjavSheGndcubVo7FmSndt97gq+O3lrPxxQyDIea6Q== X-Gm-Gg: ASbGncv2sRo/yvVQRh5aBE7NP4nCC/uueiullBsZ5AkxJ3SNYv/5QKyXJjHC4036QO1 3Ha8/9V6GHq6z+vSeM+vIEqf5NF6yP55tZVEm2ukNTXtezIQC09wTyNTzMJ0gh4uGWFmQleVvfy /BneUugKZa8dTquFMZRWTGdSZKOBvunwcZ9A/Klmy5lIzyJpjps3s/gWVBAZMOjlkrCNi9/4EjT YAyRBjY+7bxIp8j7hUlckjgjpw+TJAalb7Z+1vvKoa19F3Kc6iTWsaRnFzNikx3FEirunPpkk4Q AHsTmBlQqYnIU4er3W3LKAP+fpGIuAnscYcf5bvfKs8R6q3DFdiNHMoev/LZNGtKc8vq1h/u65z t/DziGVkmW034vhIA88lmnT69iG6eBvzpwCf06w== X-Received: by 2002:a05:6000:26d2:b0:429:c5db:f50f with SMTP id ffacd0b85a97d-429c5dbf6a0mr11739325f8f.29.1762269091171; Tue, 04 Nov 2025 07:11:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IHojKLPU4rDVbqhaGtBYpoqKQdhlHQQUFHR+h/b3H5XrUdbtPzx+fA2vVwxhA2HMf+3PQcRxg== X-Received: by 2002:a05:6000:26d2:b0:429:c5db:f50f with SMTP id ffacd0b85a97d-429c5dbf6a0mr11739290f8f.29.1762269090802; Tue, 04 Nov 2025 07:11:30 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429dc1a850fsm5369347f8f.20.2025.11.04.07.11.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Nov 2025 07:11:30 -0800 (PST) Message-ID: <6c6a8018-a8c7-4145-b634-2e856c57b895@redhat.com> Date: Tue, 4 Nov 2025 16:11:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 3/3] iov, vu_common: Make iov_from_buf() fill destination iov entirely To: Stefano Brivio , passt-dev@passt.top References: <20251103101629.1412331-1-sbrivio@redhat.com> <20251103101629.1412331-4-sbrivio@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20251103101629.1412331-4-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zKsCAImir5JDYLhowkFeYi6AE06w7BT8Hi1yv1hkPK8_1762269091 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: RUJBE2MPINFODOD6NK3YOPKCOYSXIWIS X-Message-ID-Hash: RUJBE2MPINFODOD6NK3YOPKCOYSXIWIS X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/3/25 11:16, Stefano Brivio wrote: > ...and, for consistency, rename 'bytes' to 'copy' in iov_to_buf(). > > Two commits ago, I changed vhost-user functions to use iov_from_buf() > to copy only up to the size of source buffers, instead of using the > size of the destination vhost-user buffers. > > This change pads the rest with zeroes, which is not strictly needed, > but looks definitely cleaner. > > Signed-off-by: Stefano Brivio > --- > iov.c | 54 ++++++++++++++++++++++++++++++++++------------------- > iov.h | 4 ++-- > vu_common.c | 2 +- > 3 files changed, 38 insertions(+), 22 deletions(-) > Reviewed-by: Laurent Vivier