public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [RFC PATCH 3/5] udp: Fix coding style for comment to enum udp_iov_idx
Date: Tue, 4 Nov 2025 16:18:38 +0100	[thread overview]
Message-ID: <6cab4dd1-2d4a-4fc7-9212-f7581957cdc6@redhat.com> (raw)
In-Reply-To: <20251103101612.1412079-4-sbrivio@redhat.com>

On 11/3/25 11:16, Stefano Brivio wrote:
> ...as I'm going to add a new value to it.
> 
> Fixes: 3f9bd867b585 ("udp: Split tap-bound UDP packets into multiple buffers using io vector")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> ---
>   udp.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/udp.c b/udp.c
> index 9c00950..0e37e77 100644
> --- a/udp.c
> +++ b/udp.c
> @@ -164,11 +164,11 @@ udp_meta[UDP_MAX_FRAMES];
>   
>   /**
>    * enum udp_iov_idx - Indices for the buffers making up a single UDP frame
> - * @UDP_IOV_TAP         tap specific header
> - * @UDP_IOV_ETH         Ethernet header
> - * @UDP_IOV_IP          IP (v4/v6) header
> - * @UDP_IOV_PAYLOAD     IP payload (UDP header + data)
> - * @UDP_NUM_IOVS        the number of entries in the iovec array
> + * @UDP_IOV_TAP		tap specific header
> + * @UDP_IOV_ETH		Ethernet header
> + * @UDP_IOV_IP		IP (v4/v6) header
> + * @UDP_IOV_PAYLOAD	IP payload (UDP header + data)
> + * @UDP_NUM_IOVS	the number of entries in the iovec array
>    */
>   enum udp_iov_idx {
>   	UDP_IOV_TAP,

Reviewed-by: Laurent Vivier <lvivier@redhat.com>


  parent reply	other threads:[~2025-11-04 15:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-03 10:16 [RFC PATCH 0/5] Pad all inbound frames to 802.3 minimum size if needed Stefano Brivio
2025-11-03 10:16 ` [RFC PATCH 1/5] tap: Pad non-batched frames to 802.3 minimum (60 bytes) " Stefano Brivio
2025-11-03 10:20   ` Stefano Brivio
2025-11-03 11:02     ` David Gibson
2025-11-03 11:00   ` David Gibson
2025-11-04 15:25   ` Laurent Vivier
2025-11-03 10:16 ` [RFC PATCH 2/5] tcp: Fix coding style for comment to enum tcp_iov_parts Stefano Brivio
2025-11-03 11:03   ` David Gibson
2025-11-04 15:18   ` Laurent Vivier
2025-11-03 10:16 ` [RFC PATCH 3/5] udp: Fix coding style for comment to enum udp_iov_idx Stefano Brivio
2025-11-03 11:03   ` David Gibson
2025-11-04 15:18   ` Laurent Vivier [this message]
2025-11-03 10:16 ` [RFC PATCH 4/5] tcp, udp: Pad batched frames to 60 bytes (802.3 minimum) in non-vhost-user modes Stefano Brivio
2025-11-03 11:58   ` David Gibson
2025-11-04 15:31   ` Laurent Vivier
2025-11-03 10:16 ` [RFC PATCH 5/5] tcp, udp: Pad batched frames for vhost-user modes to 60 bytes (802.3 minimum) Stefano Brivio
2025-11-04 15:50   ` Laurent Vivier
2025-11-04 16:09     ` Stefano Brivio
2025-11-04 16:28       ` Laurent Vivier
2025-11-04 17:26         ` Stefano Brivio
2025-11-05  3:49   ` David Gibson
2025-12-05  0:51     ` Stefano Brivio
2025-12-05  4:12       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cab4dd1-2d4a-4fc7-9212-f7581957cdc6@redhat.com \
    --to=lvivier@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).