From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AnKcAoZw; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 9393C5A0271 for ; Thu, 07 Aug 2025 14:58:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754571519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+AZ4ZNwW7DREoatHL8EJyHSGTaqRLkElfqKE5hafM6k=; b=AnKcAoZw9/N/C94+zuXUiXPU29sZvW2iYhcQ/AfiUnyluPxkMWkTKN7UZH9h0zK+SFrMLV CN3yir+Ty0nCPfLxV+GvOK7r2nziQHHk0MQk3JwCoud+chSA1H+OxuTrc87PylaslllzKy YLOEOhLB6b5trmV+ujsJLPkqB0gwsL4= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-_KB7sw-5PAe7LMWf-FQxnQ-1; Thu, 07 Aug 2025 08:58:37 -0400 X-MC-Unique: _KB7sw-5PAe7LMWf-FQxnQ-1 X-Mimecast-MFC-AGG-ID: _KB7sw-5PAe7LMWf-FQxnQ_1754571517 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7e65340b626so249131485a.2 for ; Thu, 07 Aug 2025 05:58:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754571517; x=1755176317; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+AZ4ZNwW7DREoatHL8EJyHSGTaqRLkElfqKE5hafM6k=; b=pd1JMFIoqXEuKkOqGD8I7k+8p62PpWRsQwyYtp0f5LLNaLVKx9W4GNit6Aq2YXmhQr /LfRsZ4mdDhA7NUmtezSNdVit1tZoh2C9PbhBrXXrrRPaglZ0V2iPagidRnSRqPQxI41 GOG5S8EGMnsgBTNvow1aP99YfR/sB2+0Kdhh6RX6tbxA4/x2AhJthhkGji9t4VUX+fTd HixGx/5MThvVqEYt+EnlAahLxjamSudXA80uMrTvsEr74mU0AehPmeSv1HI0gsMx9ShO Hn4g5Iehg2eMPCuKKPhvquDS6Oaq7D55uAFvl2IHKRt9R0sgAUH5wMn43z44lKvdaIqv cgfw== X-Gm-Message-State: AOJu0Yxlr62d6kGHlMxBoNgr4dwa2MAOILqkMEBwMq93S3ntA/fL/8tX p9tfW38ECNsS/CwUCpFHlVqACzNkT+dntt8fPh4hq9cr3FtUH7qshLTQP3lWgRWaV19EdEdfNOt 739YkurIVsWwtqGxg9s6zUp9iMOOtunVNoJuskC31ep1A3a7qvr348A== X-Gm-Gg: ASbGnctjenpxnUleryUSiXMKvofTuagioUB/1zrK77a/eRg+KYte3EKsLUBSRwJVHHC tDJ4nzPF5jZOTNyi6JZ/Tyep6606twwAm67EkwylwF/+by6pE02tnHVZVVr2/7KNMoQnU/Jloc+ w/M5j60pnUgdi5zSeCveNqLNNZxZjc0yA0sp9mtMTrfQT6o3zi0ykt4dy38oorZ39aUA3Y/vkCq Zcd4dqWHn/XKdExKoCvemtCsd+FVHBA4Tcuz0d1LoDx84ONyp9D2vkWnLeSO2sFHKki6U9f1C+j iXS1+h+Ubu/AaXVNPNb9U3X6yFghrwBFPvbocKktJJhYJL8ZLIxGFGffDvqjyUzGJiGTHaALeKE y6V3weEg+ X-Received: by 2002:ac8:7c48:0:b0:4b0:63a8:67b with SMTP id d75a77b69052e-4b0a165898emr36624001cf.28.1754571517208; Thu, 07 Aug 2025 05:58:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElrF5Da+KAIwK8dVCIXtTKb7rTufdGsjRXatT3cs+qNWxROMttB/FY0UZ9J7VA30oe9lPr3A== X-Received: by 2002:ac8:7c48:0:b0:4b0:63a8:67b with SMTP id d75a77b69052e-4b0a165898emr36623771cf.28.1754571516689; Thu, 07 Aug 2025 05:58:36 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4aeeedb2b7asm90113401cf.46.2025.08.07.05.58.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Aug 2025 05:58:36 -0700 (PDT) Message-ID: <6e7993ce-e668-42dd-83ef-45907e1e66fa@redhat.com> Date: Thu, 7 Aug 2025 14:58:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 07/30] arp: Convert to iov_tail To: Stefano Brivio References: <20250805154628.301343-1-lvivier@redhat.com> <20250805154628.301343-8-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: p6uz06M7sx59Dr6UQr8WT7hJwMgKrC9j6y4svu-kjJ4_1754571517 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: LKLRJSGKGD5SJRO7HJGBCFIEUSDBUGEL X-Message-ID-Hash: LKLRJSGKGD5SJRO7HJGBCFIEUSDBUGEL X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 06/08/2025 04:17, David Gibson wrote: > On Tue, Aug 05, 2025 at 05:46:05PM +0200, Laurent Vivier wrote: >> Use packet_data() and extract headers using IOV_REMOVE_HEADER() >> rather than packet_get(). >> >> Signed-off-by: Laurent Vivier >> Reviewed-by: David Gibson > > Still R-b, but making an observation below that's perhaps more > relevant to the previous patch. > >> --- >> arp.c | 12 +++++++++--- >> packet.c | 1 - >> 2 files changed, 9 insertions(+), 4 deletions(-) >> >> diff --git a/arp.c b/arp.c >> index 9f1fedeafec0..b3ac42082841 100644 >> --- a/arp.c >> +++ b/arp.c >> @@ -74,14 +74,20 @@ int arp(const struct ctx *c, const struct pool *p) >> struct arphdr ah; >> struct arpmsg am; >> } __attribute__((__packed__)) resp; >> + struct arphdr ah_storage; >> + struct ethhdr eh_storage; >> + struct arpmsg am_storage; >> const struct ethhdr *eh; >> const struct arphdr *ah; >> const struct arpmsg *am; >> + struct iov_tail data; >> >> - eh = packet_get(p, 0, 0, sizeof(*eh), NULL); >> - ah = packet_get(p, 0, sizeof(*eh), sizeof(*ah), NULL); >> - am = packet_get(p, 0, sizeof(*eh) + sizeof(*ah), sizeof(*am), NULL); >> + if (!packet_data(p, 0, &data)) >> + return -1; > > The only case where packet_data() will return false is if you give it > a bad packet index. That should never happen, by construction. So > I'm wondering if that should be an ASSSERT() in packet_data() rather > than a return value. > > Stefano, why do you think of this idea? Thanks, Laurent