From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 4D4415A004F for ; Mon, 05 Aug 2024 09:11:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722841901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hpRwhpXrm2p3V7EsztQGSq2/hAHfeThFQ0BtFqRbuKc=; b=dv0NR+NaYwMxM+/7z9Yd0Bu1pKdJhGF/xMPTQ4Q0dFEc5XyjiizgwW7oaoG4myYxf1Tqj7 kWkcJdYNffEIFSVP8xTqG1IqdyfTdZAbPXccOQvEmN1qZH8hRw+jbzN6oNAtaFynoII8OL QinzwhR0N7WwUXm1owBXPJIg7d+hxIg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-uKeYUDdZPGi-kRVs7YhB0A-1; Mon, 05 Aug 2024 03:11:39 -0400 X-MC-Unique: uKeYUDdZPGi-kRVs7YhB0A-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42816aacabcso66655335e9.1 for ; Mon, 05 Aug 2024 00:11:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722841898; x=1723446698; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hpRwhpXrm2p3V7EsztQGSq2/hAHfeThFQ0BtFqRbuKc=; b=Ky2drdRuBC/l2ix+Nul0ztIexnyZ711q6ib5frLlIIgX6rDlRkVMoqvS0sEoQ8BUFl pbY6ykctJKmJ6gqzGc5xXPCLsfBH3rX/V1UGLCfdOSxqTT0FTbzNVIwofSsa8fqd3m/A 2IoqVpHFFAWb1iUdBxLa8y+LGf2rP3y/7UXUcRgM/+tWHg09/0ulVd17mCTdp8ntmaea ASIyS8pnwBQkSEg+xGIOXqroRaIhVBiIHaJcWnHxHOitN3osomj0+yWkPPHwH6Bce64/ bzUztovygCXRK/8opJZj0mImcpRCw6IAADspoI+pvEqQdgbifLBFVhBQucwHL97OcA7W q3Fw== X-Gm-Message-State: AOJu0Yy1RlJ8rR9htpHqP4ZTLbElI9Y7UUYZd5CbLO3En4PlkeQX+Cq4 agX/VZwKL7wfKbaOOctnjzDPbzDUWO7l4vlgSe7CamM77cqRlEkedx4W7YMq672p2bNMbfRXPi9 QLTZGXQx6XkiNmdbi+dNgDcAddW2sN3f20gx2d9LdGasGwBUEWaqdpk8lOw== X-Received: by 2002:a05:600c:4f16:b0:428:1c91:bddd with SMTP id 5b1f17b1804b1-428e6af0b05mr67764955e9.12.1722841898098; Mon, 05 Aug 2024 00:11:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+yg+LGkNfVqHvfT7n1hdTNdpoqehYHsezza9febmPH1lN17DNSP/336nuNgvLrtHrwTcBoQ== X-Received: by 2002:a05:600c:4f16:b0:428:1c91:bddd with SMTP id 5b1f17b1804b1-428e6af0b05mr67764745e9.12.1722841897583; Mon, 05 Aug 2024 00:11:37 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:8e19:3414:44f0:befd? ([2a01:e0a:e10:ef90:8e19:3414:44f0:befd]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4282bba3249sm187068025e9.48.2024.08.05.00.11.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Aug 2024 00:11:37 -0700 (PDT) Message-ID: <73ecabe9-5ea6-46bf-8b1c-29429336ad51@redhat.com> Date: Mon, 5 Aug 2024 09:11:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] udp_flow: move all udp_flow functions to udp_flow.c To: David Gibson References: <20240802161036.1404559-1-lvivier@redhat.com> <20240802161036.1404559-3-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: BE2MXSKB3JVHI2LLESGAHKNTH7F2Q2JG X-Message-ID-Hash: BE2MXSKB3JVHI2LLESGAHKNTH7F2Q2JG X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 03/08/2024 09:51, David Gibson wrote: > On Fri, Aug 02, 2024 at 06:10:36PM +0200, Laurent Vivier wrote: >> No code change. >> >> They need to be exported to be available by the vhost-user version of >> passt. >> >> Signed-off-by: Laurent Vivier > > LGTM, with one nit: > >> +/** >> + * udp_at_sidx() - Get UDP specific flow at given sidx >> + * @sidx: Flow and side to retrieve >> + * >> + * Return: UDP specific flow at @sidx, or NULL of @sidx is invalid. Asserts if >> + * the flow at @sidx is not FLOW_UDP. >> + */ >> +struct udp_flow *udp_at_sidx(flow_sidx_t sidx) >> +{ >> + union flow *flow = flow_at_sidx(sidx); >> + >> + if (!flow) >> + return NULL; >> + >> + ASSERT(flow->f.type == FLOW_UDP); >> + return &flow->udp; >> +} > > udp_at_sidx() is so simple it probably makes more sense to have it as > an inline in the header file, rather than a regular function. When it > was a local function, I was pretty much assuming the compiler would > inline it anyways. > I can't move it to udp_flow.h because udp_at_sidx() uses flow_at_sidx() that is defined in flow_table.h after udp_flow.h has already been included. flow_table.h includes udp_flow.h at its top because it needs "struct udp_flow" in union flow. Thanks, Laurent