From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IBIbgs+D; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 7CA6D5A0271 for ; Fri, 19 Sep 2025 11:54:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758275691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=etCpvKSXiR3qLzi7uEmuJb51pmyb8m1P6sEhNw05Dtw=; b=IBIbgs+D6HPxxS6UHDUykAPoDX5geBGdA2pLLV6qv146lTSlKZwNuU449+WrcbR/AxsZSV krjntCMXNaWydIG3B7jYm9HHCeOPTmfqiDHcp8XdHZRceyGOEXbjnF0Nrm/rCHbgt3lil7 dmgZQ9wWxFHDRvWPweFPH0E7d/W8184= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-IkpHywCbN7yX4jBzN5e7OA-1; Fri, 19 Sep 2025 05:54:44 -0400 X-MC-Unique: IkpHywCbN7yX4jBzN5e7OA-1 X-Mimecast-MFC-AGG-ID: IkpHywCbN7yX4jBzN5e7OA_1758275682 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3df19a545c2so1262239f8f.3 for ; Fri, 19 Sep 2025 02:54:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758275682; x=1758880482; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=etCpvKSXiR3qLzi7uEmuJb51pmyb8m1P6sEhNw05Dtw=; b=LnXioBG3FvVD8rvAS5o2fxnCFtZx2M9K8nI7n3gd+XLqxg950HarEr9xZdwMUidkFg hGPCq8ntS1ETg4/hzfM4Ty46xbo2FslxNDog1MiTe+XrO8W2Rux2igGUBsGCIv7r36Fh JU7gl1B2yIoPY89Q7To8m/+TlvXdmNda8ZKuy3OvLulcQmxsqrjZc6xMXZoUODNcSK9+ lsy/DinB54BQVoSFNRZQjto/m56FK+B3ykN80ssNueQJdBiQUi/mjtK6A4xfotHZTs7J Ia/1mrxmQy6C8O+CKdBtMq611AEURbqTAHHSQWEEBGO4IyFU+hwGXOB1oCyii3lxlCk7 p0JA== X-Forwarded-Encrypted: i=1; AJvYcCWpKNsXg5l+OyAmBFyZCSO8fVxo38AtbWRdazR/RIuN4y9/VRi9Z7vNX3K6p6Z36oZXEiC/2S6ft80=@passt.top X-Gm-Message-State: AOJu0YyQ2A+XslOFTptxd7DCqvGrqK5j9/YZHhLsWHqTaCIabO9gQJE7 SjRaAA3OEwH+sPN5H3xbLchE2x4J8OKpq9e/kk8AXXNXedHz7GCsx9gc3zn+7vM8kvV9EJC6mWF imq+YGECKrJoYau9yx5QFZJs4Mrh3ZpPzgwLDeD7JVV1xBxRB6lYMoA== X-Gm-Gg: ASbGncsaS36jODymYR7+ft9St3y1bf7Xx0N6qGvjPRcwV2SBCgdODY/aQH1+8TY1JTM CRte/Y9lrESQ7ZNdmWE7MLFRXiTHg7z10mTsAgTSVBNyKN+KErl76y1rcB6l/CTgClngYULD5AX 7kPLA3DSFYr0yLGAY+EEOPMz7yiAJI3KkMOw4x+39+s8x1ezJPCAmbRRrKQOyeCWMRK1xcWTwrt BmDYW10hrCNwYxiC55cFnTA0iOaLtgN/t3fa6LJOxxwckdPqZmnbBLEsYF4Ie3yjpSkOVWgLplM +NME4wbEZ19Uitqlxa0niZq9LaCGmgAkC2IUN37QqMytSA== X-Received: by 2002:a5d:5846:0:b0:3e7:4835:8eeb with SMTP id ffacd0b85a97d-3ee86d6cfbfmr2206442f8f.53.1758275682109; Fri, 19 Sep 2025 02:54:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8BH0l4m4m9BjZHx+2qpu2WmtYZ7pncssrlBlJJXRnI0q8ur42omGuYgmUBWVUWTH07k4KZQ== X-Received: by 2002:a5d:5846:0:b0:3e7:4835:8eeb with SMTP id ffacd0b85a97d-3ee86d6cfbfmr2206412f8f.53.1758275681682; Fri, 19 Sep 2025 02:54:41 -0700 (PDT) Received: from [192.168.188.22] ([80.243.52.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3ee1095489asm6589216f8f.24.2025.09.19.02.54.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Sep 2025 02:54:41 -0700 (PDT) Message-ID: <7571fda7-db9b-4e31-8ff2-629a716b6d1d@redhat.com> Date: Fri, 19 Sep 2025 11:54:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] netlink: Drop nexthop state flags from routes we duplicate To: Stefano Brivio , passt-dev@passt.top References: <20250918163350.1204452-1-sbrivio@redhat.com> From: Paul Holzinger In-Reply-To: <20250918163350.1204452-1-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bnc7EcAAeJ87eNpfdoNu4wPp56WV8NQ3bwG9fbgTGQQ_1758275682 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: K4TF5OLYYL6H7ZQ2XCI4FIK67NDWYTZV X-Message-ID-Hash: K4TF5OLYYL6H7ZQ2XCI4FIK67NDWYTZV X-MailFrom: pholzing@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 18/09/2025 18:33, Stefano Brivio wrote: > The kernel doesn't like those (EINVAL) on RTM_NEWROUTE, as they are > flags representing states, not configuration. > > Link: https://github.com/containers/podman/discussions/27104 > Signed-off-by: Stefano Brivio Reviewed-by: Paul Holzinger > --- > netlink.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/netlink.c b/netlink.c > index 8f82e73..c436780 100644 > --- a/netlink.c > +++ b/netlink.c > @@ -565,6 +565,11 @@ int nl_route_dup(int s_src, unsigned int ifi_src, > if (nh->nlmsg_type != RTM_NEWROUTE) > continue; > > + /* nexthop state flags don't apply to freshly created routes, > + * and the kernel will refuse our route if they are set. > + */ > + rtm->rtm_flags &= ~RTNH_COMPARE_MASK; > + > for (rta = RTM_RTA(rtm), na = RTM_PAYLOAD(nh); RTA_OK(rta, na); > rta = RTA_NEXT(rta, na)) { > /* RTA_OIF and RTA_MULTIPATH attributes carry the -- Paul Holzinger