From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SV1Evjzz; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 897DF5A026F for ; Wed, 01 Oct 2025 12:40:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759315214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WqgewIv0UTEJ3lL+DYVPIKDiCPCeP8kMBb0TSJMa3W0=; b=SV1Evjzz9TLWIqnNa651KA4SHYHjjioNfyYtpNvDi3aCBdjY0ThUXw8co2ozMWqkf+PiLW 7tsiMS7io6xT55r5B0SHrF7ekRIjGN5VdETM1gXM2CwqJSRdtlZkNpXSpVTc42XH+5zO1o h6qQXbdHIEih3/2ebCGiAdAGOFF4NsE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-148-A-L118dsNamRh7xMTlo9vg-1; Wed, 01 Oct 2025 06:40:13 -0400 X-MC-Unique: A-L118dsNamRh7xMTlo9vg-1 X-Mimecast-MFC-AGG-ID: A-L118dsNamRh7xMTlo9vg_1759315212 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-42557bdbe50so369150f8f.1 for ; Wed, 01 Oct 2025 03:40:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759315212; x=1759920012; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WqgewIv0UTEJ3lL+DYVPIKDiCPCeP8kMBb0TSJMa3W0=; b=urDMA0QNpy9OgT6gc036WQwUxs+o2kI0JjvjpVZZ/FG4WyJJXWtQsdObcS4nexm0fC mxYaHXsHvoNz82nW9FQVDhh2XJViA+wLLvQEf30WEtt5zP4TY1tEblHx9RSMFS4VrGrn IZdUhf59/5EalEsHN3451TTwsAW7xgFiTdacQAvgxarYZFzbHYTBLpMq/xvHlbyQtOrj ucNMUW9hqly4piwaxA9L9tBB3xgv5fLLZRWrLu/aw4y3DlQ2d1DY3656xr4p/0PmYFVO 15c380cUOrcTGr4+K2DvPnxv0Y4Termw/oOxb3C7zyw0IRaKJvAvNbM66uL3rYcpVt6Z uM3w== X-Gm-Message-State: AOJu0YxNOtTZXb1DICKsp7PqHjHAIb8630meKNlL6pfF0dPizShcFKA3 W8Qhoerp/04iP+iIXPdbGyuf4jbN2hhNdNFCIiD1GEUDxQaaiKHNFntI/t2VSygqQsxeHFN3kAj Of3fOkb7GPilHbWazNaYkudkU49wSczr8r63NnAAq7qGxwtHrQTB5yw== X-Gm-Gg: ASbGncubfAkybD4IUeYZjnYlajNFN4af+pvMezh3nN/IYO1bKMJJzTlKDipX6UWUxAT Y/Z20joS/lTQ8yX31H/P94xAqgavOfpY7ASsOBTbJffwPlpvTVRuPMtK67UX+pJfJ/P16FgFSTs 9NmnWJ+QGcPxcg2XBSIuXNctEBircYE9LhXArAe5jpnws8DLMjRPGrEI73EW0GErc9H76y/ykM3 Rl4efgzorqO8asUnTyKdfvB/dXmymHBx8oa+qNcB1sjgMH353RMx//JI4fMFNkY0UjgUk8ghxVv T6jcfipApBIl1A1yOj7boocMTvlT5DN7HORK9VSmUig5139An28= X-Received: by 2002:a05:6000:2dc8:b0:401:ae97:a1ab with SMTP id ffacd0b85a97d-4255777b23amr2754557f8f.10.1759315212023; Wed, 01 Oct 2025 03:40:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQXT6cSgARILVjm1eQ4YDFERpA/CGTQvGSvc1z3QpU3/NENAXkYw2qWosQ1VDtPVkhCcAmVA== X-Received: by 2002:a05:6000:2dc8:b0:401:ae97:a1ab with SMTP id ffacd0b85a97d-4255777b23amr2754542f8f.10.1759315211595; Wed, 01 Oct 2025 03:40:11 -0700 (PDT) Received: from [192.168.188.22] ([80.243.52.136]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fc6cf3835sm26714332f8f.46.2025.10.01.03.40.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Oct 2025 03:40:10 -0700 (PDT) Message-ID: <779811c8-ec8b-4426-86ca-4fbeb31769ee@redhat.com> Date: Wed, 1 Oct 2025 12:40:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] test: Add linting of Python test scripts To: Stefano Brivio References: <20251001095202.3875003-1-david@gibson.dropbear.id.au> <20251001095202.3875003-3-david@gibson.dropbear.id.au> <20251001122351.7020b79a@elisabeth> From: Paul Holzinger In-Reply-To: <20251001122351.7020b79a@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fdrb5h4Zk1SFViTUl9o8slPT6Up-oPAjinVogWHJT3w_1759315212 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: ISNGJN5HNP22XPMG4PPMCHNYEUKBFCEF X-Message-ID-Hash: ISNGJN5HNP22XPMG4PPMCHNYEUKBFCEF X-MailFrom: pholzing@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 01/10/2025 12:23, Stefano Brivio wrote: > On Wed, 1 Oct 2025 19:51:58 +1000 > David Gibson wrote: > >> We currently have one test moved to the new exeter based framwork written >> in Python. We plan to add many more, so add linting (flake8) and type >> checking (mypy) of those scripts. This can be invoked manually with >> "make flake8" or "make mypy" in test/, and is also added to the static >> checkers test set. > I never used a Python linter, so I'm not sure if it's as bad as Go or > Rust linters taking the whole poetry away, as it happened for instance > in my most recent experience with 'cargo fmt': > > https://github.com/AsahiLinux/muvm/compare/68094c02c19b6f5d5e3def6d29379c1244c9a5e4..9af11c334a1ce37f533c056d982f8608c8d80d27#diff-e1a95ce380b9a8a317f97cccce1cbfd3dccd343dc62169ed1340208ab304fab9L106 > > https://github.com/AsahiLinux/muvm/pull/111#discussion_r1863551727 > (you need to click around before you get to it, no idea how to share > a proper link that opens that comment right away) Not really on topic for this series but since you brought up rust there is actually a "#[rustfmt::skip]" attribute that can be used to skip the formatting selectively in case you need it in the future. -- Paul Holzinger