Re: [PATCH] conf: Separate local mode for each IP version, don't enable disabled IP version

[Paul Holzinger <pholzing@redhat.com>]

On 05/12/2025 12:31, Stefano Brivio wrote:
> On Fri, 5 Dec 2025 12:26:06 +0100
> Paul Holzinger <pholzing@redhat.com> wrote:
>
>> On 05/12/2025 01:51, Stefano Brivio wrote:
>>> This fixes an issue and introduces a feature:
>>>
>>> - in local mode, we accidentally ignored the -4 / --ipv4-only and
>>>     -6 / --ipv6-only command line options
>>>
>>> - if no template interface is available for a given IP version,
>>>     instead of disabling that IP version, use local mode, separately,
>>>     for it
>>>
>>> Link: https://bugs.passt.top/show_bug.cgi?id=129
>>> Link: https://bugs.passt.top/show_bug.cgi?id=128
>>> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
>> Tested-by: Paul Holzinger <pholzing@redhat.com>
> Ah, thanks, that's quite reassuring / much needed for this one.

FWIW, this is how I tested:

unshare -rn  sh -c "ip link add test type bridge && ip link set test up 
&& ip addr add 192.168.0.0/24 dev test &&  ./pasta --config-net ip a"

unshare -rn  sh -c "ip link add test type bridge && ip link set test up 
&& ip addr add 2620::1/64 dev test &&  ./pasta --config-net ip a"

And then the variations with  adding -4/-6.

-- 
Paul Holzinger