public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
85683fa0212926d131ee3bf7ae2cd8373bb59876 blob 10733 bytes (raw)

  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
 
// SPDX-License-Identifier: GPL-2.0-or-later

/* PESTO - Programmable Extensible Socket Translation Orchestrator
 *  front-end for passt(1) and pasta(1) forwarding configuration
 *
 * pesto.c - Main program (it's not actually extensible)
 *
 * Copyright (c) 2026 Red Hat GmbH
 * Author: Stefano Brivio <sbrivio@redhat.com>
 */

#include <arpa/inet.h>
#include <sys/prctl.h>
#include <sys/types.h>
#include <sys/socket.h>
#include <sys/un.h>
#include <errno.h>
#include <getopt.h>
#include <inttypes.h>
#include <stdbool.h>
#include <stddef.h>
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <limits.h>
#include <unistd.h>

#include <linux/audit.h>
#include <linux/capability.h>
#include <linux/filter.h>
#include <linux/seccomp.h>

#include "common.h"
#include "seccomp_pesto.h"
#include "serialise.h"
#include "ports.h"
#include "fwd_rule.h"
#include "pesto.h"
#include "log.h"
#include "pif.h"

int verbosity = 1;

/**
 * xmalloc() - Allocate memory, with fatal error on failure
 * @size:	Number of bytes to allocate
 */
static void *xmalloc(size_t size)
{
	void *p = malloc(size);

	if (!p)
		die("Memory allocation failure");
	return p;
}

/**
 * usage() - Print usage, exit with given status code
 * @name:	Executable name
 * @f:		Stream to print usage info to
 * @status:	Status code for exit(2)
 */
static void usage(const char *name, FILE *f, int status)
{
	FPRINTF(f, "Usage: %s [OPTION]... PATH\n", name);
	FPRINTF(f,
		"\n"
		"  -t, --tcp-ports SPEC	TCP inbound port forwarding\n"
		"    can be specified multiple times\n"
		"    SPEC can be:\n"
		"      'none': don't forward any ports\n"
		"      'auto': forward all ports currently bound in namespace\n"
		"      'all': forward all unbound, non-ephemeral ports\n"
		"      a comma-separated list, optionally ranged with '-'\n"
		"        and optional target ports after ':', with optional\n"
		"        address specification suffixed by '/' and optional\n"
		"        interface prefixed by '%%'. Examples:\n"
		"        -t 22	Forward local port 22 to port 22 in netns\n"
		"        -t 22:23	Forward local port 22 to port 23\n"
		"        -t 22,25	Forward ports 22, 25 to ports 22, 25\n"
		"        -t 22-80	Forward ports 22 to 80\n"
		"        -t 22-80:32-90	Forward ports 22 to 80 to\n"
		"			corresponding port numbers plus 10\n"
		"        -t 192.0.2.1/5	Bind port 5 of 192.0.2.1\n"
		"        -t 5-25,~10-20	Forward ports 5 to 9, and 21 to 25\n"
		"        -t ~25		Forward all bound ports except for 25\n"
		"    IPv6 bound ports are also forwarded for IPv4\n"
		"  -u, --udp-ports SPEC	UDP inbound port forwarding\n"
		"    SPEC is as described for TCP above\n"
		"    IPv6 bound ports are also forwarded for IPv4\n"
		"    unless specified, with '-t auto', UDP ports with numbers\n"
		"    corresponding to forwarded TCP port numbers are\n"
		"    forwarded too\n"
		"  -T, --tcp-ns SPEC	TCP port forwarding to init namespace\n"
		"    SPEC is as described above\n"
		"  -U, --udp-ns SPEC	UDP port forwarding to init namespace\n"
		"    SPEC is as described above\n"
		"  -v, --verbose		Be more verbose\n"
		"  -q, --quiet		Be less verbose\n"
		"  -h, --help		Display this help message and exit\n"
		"  --version		Show version and exit\n");
	exit(status);
}

/**
 * pesto_recv_str() - Receive a string from passt/pasta
 * @fd:		Control socket
 *
 * Return: pointer to malloc()ed string
 */
static const char *pesto_recv_str(int fd)
{
	uint32_t len;
	char *buf;

	if (seread_u32(fd, &len) < 0)
		die("Error reading from control socket");

	buf = xmalloc(len);
	if (seread_buf(fd, buf, len) < 0)
		die("Error reading from control socket");

	return buf;
}

struct pif_state {
	uint8_t pif;
	const char *name;
	uint32_t count;
	struct fwd_rule *rule;
};

struct conf_state {
	uint32_t npifs;
	struct pif_state pif[];
};

/**
 * pesto_read_pifs() - Read pif names and IDs from passt/pasta
 * @fd:		Control socket
 */
static struct conf_state *pesto_read_pifs(int fd)
{
	uint32_t num;
	struct conf_state *state;
	unsigned i;

	if (seread_u32(fd, &num) < 0)
		die("Error reading from control socket");

	debug("Receiving %"PRIu32" interface names", num);

	state = xmalloc(sizeof(*state) + num * sizeof(struct pif_state));
	state->npifs = num;

	for (i = 0; i < num; i++) {
		struct pif_state *ps = &state->pif[i];

		if (seread_u8(fd, &ps->pif) < 0)
			die("Error reading from control socket");
		ps->name = pesto_recv_str(fd);

		debug("%u: %s", ps->pif, ps->name);
	}

	return state;
}

/**
 * find_pif_state() - Find the pif state structure for a given pif id
 * @state:	Rule state information
 * @pif:	pif id
 *
 * Return: pointer to the pif_state for @pif, or NULL if not found
 */
static struct pif_state *find_pif_state(struct conf_state *state, uint8_t pif)
{
	unsigned i;

	for (i = 0; i < state->npifs; i++) {
		if (state->pif[i].pif == pif)
			return &state->pif[i];
	}

	return NULL;
}

/**
 * pesto_read_rules() - Read a set of rules for one pif
 * @fd:		Control socket
 * @state:	Rule state information to update
 *
 * Return: true if there may be more rules to read, false if finished
 */
static bool pesto_read_rules(int fd, struct conf_state *state)
{
	struct pif_state *ps;
	uint8_t pif;
	unsigned i;

	if (seread_u8(fd, &pif) < 0)
		die("Error reading from control socket");

	if (!pif)
		return false;

	ps = find_pif_state(state, pif);
	if (!ps)
		die("Received rules for an unknown pif");

	if (seread_u32(fd, &ps->count) < 0)
		die("Error reading from control socket");

	debug("Receiving rules %"PRIu32" rules for %s", ps->count, ps->name);

	ps->rule = xmalloc(sizeof(*ps->rule) * ps->count);

	for (i = 0; i < ps->count; i++) {
		if (fwd_rule_seread(fd, &ps->rule[i]) < 0)
			die("Error reading from control socket");
	}

	return true;
}

/**
 * show_state() - Show current rule state obtained from passt/pasta
 * @pifs:	PIF name information
 */
static void show_state(const struct conf_state *state)
{
	unsigned i, j;

	for (i = 0; i < state->npifs; i++) {
		const struct pif_state *ps = &state->pif[i];
		printf("Forwarding rules for %s interface\n", ps->name);
		for (j = 0; j < ps->count; j++) {
			const struct fwd_rule *rule = &ps->rule[j];
			char rulestr[FWD_RULE_STRLEN];

			printf("    %s\n", fwd_rule_ntop(rule, rulestr,
							 sizeof(rulestr)));
		}
	}
}

/**
 * main() - Entry point and whole program with loop
 * @argc:	Argument count
 * @argv:	Arguments: socket path, operation, port specifiers
 *
 * Return: 0 on success, won't return on failure
 *
 * #syscalls:pesto connect write close exit_group fstat brk getrandom openat
 * #syscalls:pesto socket s390x:socketcall i686:socketcall
 * #syscalls:pesto recvfrom recvmsg arm:recv ppc64le:recv
 * #syscalls:pesto sendto sendmsg arm:send ppc64le:send
 */
int main(int argc, char **argv)
{
	const struct option options[] = {
		{"quiet",	no_argument,		NULL,		'q' },
		{"verbose",	no_argument,		NULL,		'v' },
		{"help",	no_argument,		NULL,		'h' },
		{"version",	no_argument,		NULL,		1 },
		{"tcp-ports",	required_argument,	NULL,		't' },
		{"udp-ports",	required_argument,	NULL,		'u' },
		{"tcp-ns",	required_argument,	NULL,		'T' },
		{"udp-ns",	required_argument,	NULL,		'U' },
		{ 0 },
	};
	struct fwd_table fwd_in = { .count = 0 }, fwd_out = { .count = 0 };
	struct sockaddr_un a = { AF_UNIX, "" };
	const char *optstring = "vht:u:T:U:";
	enum fwd_mode fwd_default;
	struct pesto_hello hello;
	struct conf_state *state;
	struct sock_fprog prog;
	int optname, ret, s;
	uint32_t s_version;
	unsigned i;

	prog.len = (unsigned short)sizeof(filter_pesto) /
				   sizeof(filter_pesto[0]);
	prog.filter = filter_pesto;
	if (prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0) ||
	    prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog))
		die("Failed to apply seccomp filter");

	fwd_probe_ephemeral();

	do {
		optname = getopt_long(argc, argv, optstring, options, NULL);

		switch (optname) {
		case -1:
		case 0:
			break;
		case 'h':
			usage(argv[0], stdout, EXIT_SUCCESS);
			break;
		case 'q':
			verbosity--;
			break;
		case 'v':
			verbosity++;
			break;
		case 't':
		case 'u':
			fwd_default = FWD_MODE_UNSET;
			conf_ports(optname, optarg, &fwd_in, &fwd_default,
				   true, true, true);
			break;
		case 'T':
		case 'U':
			fwd_default = FWD_MODE_UNSET;
			conf_ports(optname, optarg, &fwd_out, &fwd_default,
				   true, true, true);
			break;
		case 1:
			FPRINTF(stdout, "pesto ");
			FPRINTF(stdout, VERSION_BLOB);
			exit(EXIT_SUCCESS);
		default:
			usage(argv[0], stderr, EXIT_FAILURE);
		}
	} while (optname != -1);

	if (argc - optind != 1)
		usage(argv[0], stderr, EXIT_FAILURE);

	if ((s = socket(AF_UNIX, SOCK_STREAM, 0)) < 0)
		die("Failed to create AF_UNIX socket: %s", strerror(errno));

	ret = snprintf(a.sun_path, sizeof(a.sun_path), "%s", argv[optind]);
	if (ret <= 0 || ret >= (int)sizeof(a.sun_path))
		die("Invalid socket path \"%s\"", argv[optind]);

	ret = connect(s, (struct sockaddr *)&a, sizeof(a));
	if (ret < 0) {
		die("Failed to connect to %s: %s",
		    a.sun_path, strerror(errno));
	}

	debug("Inbound rules from command line:");
	for (i = 0; i < fwd_in.count; i++) {
		const struct fwd_rule *rule = &fwd_in.rules[i].rule;
		char rulestr[FWD_RULE_STRLEN];

		debug("    %s", fwd_rule_ntop(rule, rulestr, sizeof(rulestr)));
	}

	debug("Outbound rules from command line:");
	for (i = 0; i < fwd_out.count; i++) {
		const struct fwd_rule *rule = &fwd_out.rules[i].rule;
		char rulestr[FWD_RULE_STRLEN];

		debug("    %s", fwd_rule_ntop(rule, rulestr, sizeof(rulestr)));
	}

	debug("Connected to passt/pasta control socket");
	
	ret = seread_var(s, &hello);
	if (ret < 0)
		die("Couldn't read server greeting: %s", strerror(errno));

	if (memcmp(hello.magic, PESTO_SERVER_MAGIC, sizeof(hello.magic)))
		die("Bad magic number from server");

	s_version = ntohl(hello.version);

	debug("Server protocol version: %"PRIu32, s_version);

	if (s_version > PESTO_PROTOCOL_VERSION) {
		die("Unknown server protocol version %"PRIu32" > %"PRIu32"\n",
		    s_version, PESTO_PROTOCOL_VERSION);
	}

	/* cppcheck-suppress knownConditionTrueFalse */
	if (!s_version) {
		if (PESTO_PROTOCOL_VERSION)
			die("Unsupported experimental server protocol");
		FPRINTF(stderr,
"Warning: Using experimental protocol version, client and server must match\n");
	}

	state = pesto_read_pifs(s);

	while (pesto_read_rules(s, state))
		;

	show_state(state);

	if (fwd_in.count) {
		sewrite_u8(s, PIF_HOST);
		sewrite_u32(s, fwd_in.count);
		for (i = 0; i < fwd_in.count; i++)
			fwd_rule_sewrite(s, &fwd_in.rules[i].rule);
	}

	if (fwd_out.count) {
		sewrite_u8(s, PIF_SPLICE);
		sewrite_u32(s, fwd_out.count);
		for (i = 0; i < fwd_out.count; i++)
			fwd_rule_sewrite(s, &fwd_out.rules[i].rule);
	}

	sewrite_u8(s, PIF_NONE);

	exit(0);
}
debug log:

solving 85683fa ...
found 85683fa in https://archives.passt.top/passt-dev/20260322141843.4095972-3-sbrivio@redhat.com/
found 42fa7f2 in https://archives.passt.top/passt-dev/20260322141843.4095972-2-sbrivio@redhat.com/
found f021cdb in https://archives.passt.top/passt-dev/20260319061157.1983818-16-david@gibson.dropbear.id.au/
found dbc27a58 in https://archives.passt.top/passt-dev/20260319061157.1983818-10-david@gibson.dropbear.id.au/
found a8c134f5 in https://archives.passt.top/passt-dev/20260319061157.1983818-9-david@gibson.dropbear.id.au/
found edc07e77 in https://archives.passt.top/passt-dev/20260319061157.1983818-8-david@gibson.dropbear.id.au/

applying [1/6] https://archives.passt.top/passt-dev/20260319061157.1983818-8-david@gibson.dropbear.id.au/
diff --git a/pesto.c b/pesto.c
new file mode 100644
index 00000000..edc07e77


applying [2/6] https://archives.passt.top/passt-dev/20260319061157.1983818-9-david@gibson.dropbear.id.au/
diff --git a/pesto.c b/pesto.c
index edc07e77..a8c134f5 100644


applying [3/6] https://archives.passt.top/passt-dev/20260319061157.1983818-10-david@gibson.dropbear.id.au/
diff --git a/pesto.c b/pesto.c
index a8c134f5..dbc27a58 100644


applying [4/6] https://archives.passt.top/passt-dev/20260319061157.1983818-16-david@gibson.dropbear.id.au/
diff --git a/pesto.c b/pesto.c
index dbc27a58..f021cdb6 100644


applying [5/6] https://archives.passt.top/passt-dev/20260322141843.4095972-2-sbrivio@redhat.com/
diff --git a/pesto.c b/pesto.c
index f021cdb..42fa7f2 100644


applying [6/6] https://archives.passt.top/passt-dev/20260322141843.4095972-3-sbrivio@redhat.com/
diff --git a/pesto.c b/pesto.c
index 42fa7f2..85683fa 100644

Checking patch pesto.c...
Applied patch pesto.c cleanly.
5:239: trailing whitespace.
	
Checking patch pesto.c...
Applied patch pesto.c cleanly.
Checking patch pesto.c...
Applied patch pesto.c cleanly.
Checking patch pesto.c...
Applied patch pesto.c cleanly.
Checking patch pesto.c...
Applied patch pesto.c cleanly.
Checking patch pesto.c...
Applied patch pesto.c cleanly.
warning: 1 line adds whitespace errors.

index at:
100644 85683fa0212926d131ee3bf7ae2cd8373bb59876	pesto.c

Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).