From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TI9MpE0Q; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 847135A0625 for ; Thu, 11 Dec 2025 09:48:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765442926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5xWZiiJahux2225XgtqeCSVnVa/NX3kfuT5QMRhoHRo=; b=TI9MpE0QY+3pChcpGdNWynu17+/gMUx6zd/p2UlI7K3HXEOVU6MG3v33gBv+QUy+U8BmzF hAycsVGGCiTLMIjLOhdQVIpFDv1M5HxZ4giwayI6XCPhu0hbMFXD28+3UrZf+8LtFLjk40 zxBzKnbcSDGdzYWwJc4ivkPrzR+ppXM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-0hYbZ6jVO8OziLTxlTV6QA-1; Thu, 11 Dec 2025 03:48:45 -0500 X-MC-Unique: 0hYbZ6jVO8OziLTxlTV6QA-1 X-Mimecast-MFC-AGG-ID: 0hYbZ6jVO8OziLTxlTV6QA_1765442924 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-477cf2230c8so5322805e9.0 for ; Thu, 11 Dec 2025 00:48:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765442924; x=1766047724; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5xWZiiJahux2225XgtqeCSVnVa/NX3kfuT5QMRhoHRo=; b=XO4pWUl2upUHpm+CxWbZHGc+30PIQ4lkGrmzfQzayzdHtShiBTKUkJXpHwBTyzecQy Uwv29ubG7vS6aN134vRcERbD6utnwne9w99kG1EhGczTY5Zinw6KeuGbI9WSAwqOOEHr 7zjBHZqZVyoInABTWNXzvp7y/8rhOpykI682r8C84RUD4UgBAUeEAeuPeJ5z/9U8IS8j CZiuYE/hxUYIx264hr27iAmDU2YalFWuoD/l4R8A1CLAlWHWiklGsicx4Q0JZAl1PZ7I Gjb91bCzfH4gdVGVJ4TrSJQNzrGgPrXHx1sK2mJa+dWwXmozNJxFyRnS+Mt/1XmB0SDg SleA== X-Gm-Message-State: AOJu0YxajnNKbt6o3BZfJ+ZC3WhhxemjJxD6Nc7wFPH75Gtusg+cVIFu QWT1i1ZSQwxl8jUZ3pnacPS/4At30WczsEHCYP1DS4lUjq5yKNMxuvkCa1WRzyTseI3U2xbCxDL szRXJ8nntvCmxkdVCu2ecyb7hf8bWYoEiiUehPiNNP7QwjWsJmkPZSg== X-Gm-Gg: AY/fxX7nnaegFMmz6G5HbJ5xb9292QKFsaVNuQ7w4oAIjKVKN/zvgI15/JHjCYF2ZMU x3F/HgZR/W7/Hh9SEaibolW+VQuWLizYE5y/TI73349bGhH2Iv207L+WRKcnTFwTtBf6U8JLGWw ke5y96q27YaQxC9TwT5NWtpGgNzvysRvYZRLdC2OP0D2Vky9XLZw9YZtJrnqYKzglVmbW8Jd/4l letz7a02+gJCNXeNEpgIR35weAHFSHLh5ZgmfOKNG/KxYwhV2Cpg4kuxRRn3iM+y4eJ5HNNIYbv wAzSfEqcxsMttOrcDWT3g+DvyT+CD/hjYyjJiYo7Ld9KCEGypMTYHEUrVuZgIaNqxKhk4xSpLm3 aPC2A9+0d9OI63VgxIvpO4bS8ESeoYYp0rP5I1TuLhqJ4DeyX X-Received: by 2002:a05:600c:1389:b0:477:54cd:2030 with SMTP id 5b1f17b1804b1-47a8384375fmr47970855e9.21.1765442923723; Thu, 11 Dec 2025 00:48:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IH0hmwGHrdaW/TeJ6W9L2x9AKEg/DJpgLMOBCOKhcOhCTR2MlmWujBqajPYb+pLNSwBy75YJQ== X-Received: by 2002:a05:600c:1389:b0:477:54cd:2030 with SMTP id 5b1f17b1804b1-47a8384375fmr47970515e9.21.1765442923161; Thu, 11 Dec 2025 00:48:43 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a89ec10c0sm8530945e9.4.2025.12.11.00.48.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Dec 2025 00:48:42 -0800 (PST) Message-ID: <85c1c222-dbd6-410d-96e3-9b000795919f@redhat.com> Date: Thu, 11 Dec 2025 09:48:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/6] vhost-user: Add queue pair parameter throughout the network stack To: Stefano Brivio References: <20251203185435.582096-1-lvivier@redhat.com> <20251203185435.582096-5-lvivier@redhat.com> <20251211080144.72d9577f@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20251211080144.72d9577f@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hDTdhdqsG8gY8piraHqyERw86wh07SioGMk5ouXfRcE_1765442924 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: S6IABRYCY3GXMHSGF2NEGIBDN7UY4AAD X-Message-ID-Hash: S6IABRYCY3GXMHSGF2NEGIBDN7UY4AAD X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 12/11/25 08:01, Stefano Brivio wrote: > On Wed, 3 Dec 2025 19:54:32 +0100 > Laurent Vivier wrote: > >> diff --git a/vu_common.c b/vu_common.c >> index b13b7c308fd8..80d9a30f6f71 100644 >> --- a/vu_common.c >> +++ b/vu_common.c >> @@ -196,11 +196,11 @@ static void vu_handle_tx(struct vu_dev *vdev, int index, >> >> data = IOV_TAIL(elem[count].out_sg, elem[count].out_num, 0); >> if (IOV_DROP_HEADER(&data, struct virtio_net_hdr_mrg_rxbuf)) >> - tap_add_packet(vdev->context, &data, now); >> + tap_add_packet(vdev->context, 0, &data, now); >> >> count++; >> } >> - tap_handler(vdev->context, now); >> + tap_handler(vdev->context, 0, now); >> >> if (count) { >> int i; >> @@ -235,23 +235,26 @@ void vu_kick_cb(struct vu_dev *vdev, union epoll_ref ref, >> } >> >> /** >> - * vu_send_single() - Send a buffer to the front-end using the RX virtqueue >> + * vu_send_single() - Send a buffer to the front-end using a specified virtqueue >> * @c: execution context >> + * @qpair: Queue pair on which to send the buffer >> * @buf: address of the buffer >> * @size: size of the buffer >> * >> * Return: number of bytes sent, -1 if there is an error >> */ >> -int vu_send_single(const struct ctx *c, const void *buf, size_t size) >> +int vu_send_single(const struct ctx *c, unsigned int qpair, const void *buf, size_t size) >> { >> struct vu_dev *vdev = c->vdev; >> - struct vu_virtq *vq = &vdev->vq[VHOST_USER_RX_QUEUE]; >> struct vu_virtq_element elem[VIRTQUEUE_MAX_SIZE]; >> struct iovec in_sg[VIRTQUEUE_MAX_SIZE]; >> + struct vu_virtq *vq; >> size_t total; >> int elem_cnt; >> int i; >> >> + vq = &vdev->vq[qpair << 1]; > > << 1 instead of * 2 is a bit surprising here, for a few seconds I > thought you swapped qpair and 1. > > Then I started thinking that somebody is likely to mix up (probably not > you) indices of RX and TX queues at some point. So... what about some > macros, say (let's see if I got it right this time): > > #define VHOST_SEND_QUEUE(pair) ((pair) * 2) > #define VHOST_RECV_QUEUE(pair) (pair) I will. David had the same comment. TX and RX are from the point of view of guest, it's not obvious when we read passt code. I would prefer as David proposed to use, i.e. FROMGUEST and TOGUEST: #define VHOST_FROM_GUEST(qpair) ((qpair) * 2 + 1) #define VHOST_TO_GUEST(qpair) ((qpair) * 2)> > and: > > #define VHOST_QUEUE_PAIR(q) ((q) % 2) ? (q) : (q) / 2) I don't undestand the purpose of this one. > > ...are they correct? A short description or "Theory of operation" > section somewhere with a recap of how queue indices are used would be > nice to have. > > And maybe also something explaining that 0 that's now appearing in > argument lists: > > #define VHOST_NO_QUEUE 0 It's not really NO_QUEUE, it's default queue pair, the queue pair 0 Thanks, Laurent