From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GMt02kcZ; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 579D75A0262 for ; Thu, 16 Jul 2026 09:25:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784186755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oHJpgA8LBFsWeDRSKF6LZVLTydux+JP1j2ZnAcwULNc=; b=GMt02kcZvMEaYSmLDd+yuq7yMC+AJhnT/hNCKgYAWuNlKUso5YV34rON7fVF8WPayMsBxg sPCyYtMI8NAZQXKW5yYrCdZ69O2bwPvPXiGehhkubunri1YWGXfgGUwUOu7uCXnSSWtK9B pXVqTFPuWK80o78xs4EyOe8h01e9kUM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-Tl1i61g1MQGS0WIgBx7NyQ-1; Thu, 16 Jul 2026 03:25:53 -0400 X-MC-Unique: Tl1i61g1MQGS0WIgBx7NyQ-1 X-Mimecast-MFC-AGG-ID: Tl1i61g1MQGS0WIgBx7NyQ_1784186752 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-476d52b13d7so2713729f8f.0 for ; Thu, 16 Jul 2026 00:25:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784186752; x=1784791552; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oHJpgA8LBFsWeDRSKF6LZVLTydux+JP1j2ZnAcwULNc=; b=OFnIZOereGjKQpEp+DcGMTqvqeim0tDypubK4M3C1+fntgRsFhayPzi+oSwe6iUZqm AH1DDAYMZ48LcUl/emSt7xWj7KzdJ5wMQ8HNtwe8y1TX7i7BbF63lsSQx0wVqU5AFDY6 gxheOupUBV7HCmIbg9SIY0kHmDLaQH6EhEj5b36rqRdKsl8Uo1DcX6GsfXO5ampImM83 YyXlyCmb8DzGO6WxdPs/8c1d+eIx4NZCwyGkIcJSwvXiEka9hKVwPATaOxp8sLxdXFOG hisPB6ePhoI2fg6nYmsLKKwV7dl2IrVwrD5yvsAnlhcogZ1BhY3R68uGR08IGQz2SpAr xstQ== X-Gm-Message-State: AOJu0YygB3PyEp2axghrm1tNaQMOQd268uRDUMTSl9OPbbCwbYGqWuuv 1picTDI8h2XMJNMGtY/uuwr+Yzm4J6lP/h0YGIhRGb/BDvhAPX4Fch6dgoe/GRWgFt7tGHwLmQ0 7aHm/JoN+Cslm4JP7pA89PJod4ceATvZbM5r5iEhK6mrAEtxTKVZHkUR3TfyYudRPxQsZ3RCLMJ mmsSPRnTkFeen0ROzgKYouilbqTZzcZqyVbKVWmZI= X-Gm-Gg: AfdE7cmcdBGfqZ5ErbiZxd97+1SoCWWLcZa04sYvUtE0noVrTNN+8aGHrF1BAkqGEMs n3lcuKH0HmVpiP+f7vZBfXFWIMXSDAU+JBZTBLIzJPA2V6tOoMZDvZpW/qO3rEwtwG6Bcp9PFQ2 fyOXHd+groKi63Ivpk9vOSkVRJ9HjNuUCGZSuwdDsdcsMbpHwfNE3UfI/C4yQbdA0RfIAXEZqQa X8wwFf1ZUloDAMFzkUGKdfrU4r3RVFoNM94Q5zUT7dCm0H1P5G8DFzR+tYG7oas/jQQ55jAv9qS 8KhOPBCo/u706hJyP3iKoSIPCkEu/DLQ2sRCorEO4VZRLXL7zYdVSq8EW1jAUJFU1f5RraOyB0w qqoLhfqIXAYR640VgZx6MkAuOoe2/ZFhOUUD6UvE= X-Received: by 2002:a05:6000:460f:b0:473:cf28:a23e with SMTP id ffacd0b85a97d-47f2dcc32d5mr25068950f8f.19.1784186752398; Thu, 16 Jul 2026 00:25:52 -0700 (PDT) X-Received: by 2002:a05:6000:460f:b0:473:cf28:a23e with SMTP id ffacd0b85a97d-47f2dcc32d5mr25068889f8f.19.1784186751719; Thu, 16 Jul 2026 00:25:51 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464b7f84sm21257859f8f.27.2026.07.16.00.25.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 00:25:50 -0700 (PDT) Message-ID: <85d9af6d-e875-4e2b-b003-0724a3ed09da@redhat.com> Date: Thu, 16 Jul 2026 09:25:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] udp, icmp: Remove unused timer_run fields from protocol contexts To: passt-dev@passt.top References: <20260619103006.1669522-1-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260619103006.1669522-1-lvivier@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WGqMMQgyYSOI29oc1XlazYClR9jvWZrbUaExUdeKLl8_1784186752 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: QZN7OSON5VLRGYCL32Z4EKVNIIULEPVG X-Message-ID-Hash: QZN7OSON5VLRGYCL32Z4EKVNIIULEPVG X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Ping? On 6/19/26 12:30, Laurent Vivier wrote: > Since 260075bde769 ("tcp, udp, fwd: Run all port scanning from a > single timer"), CALL_PROTO_HANDLER() is only used for TCP. UDP and > ICMP timers now run from flow_defer_handler(), making the timer_run > fields in struct udp_ctx and struct icmp_ctx dead stores. > > Remove the unused fields, drop struct icmp_ctx entirely (it has no > remaining members), and stop initialising them in timer_init(). > > Signed-off-by: Laurent Vivier > --- > icmp.h | 7 ------- > passt.c | 2 +- > passt.h | 2 -- > udp.h | 2 -- > 4 files changed, 1 insertion(+), 12 deletions(-) > > diff --git a/icmp.h b/icmp.h > index e8b928b61370..556260461995 100644 > --- a/icmp.h > +++ b/icmp.h > @@ -19,12 +19,5 @@ int icmp_tap_handler(const struct ctx *c, uint8_t pif, sa_family_t af, > struct iov_tail *data, const struct timespec *now); > void icmp_init(void); > > -/** > - * struct icmp_ctx - Execution context for ICMP routines > - * @timer_run: Timestamp of most recent timer run > - */ > -struct icmp_ctx { > - struct timespec timer_run; > -}; > > #endif /* ICMP_H */ > diff --git a/passt.c b/passt.c > index b1d35d5bf988..677c8471a105 100644 > --- a/passt.c > +++ b/passt.c > @@ -141,7 +141,7 @@ static void random_init(struct ctx *c) > */ > static void timer_init(struct ctx *c, const struct timespec *now) > { > - c->tcp.timer_run = c->udp.timer_run = c->icmp.timer_run = *now; > + c->tcp.timer_run = *now; > } > > /** > diff --git a/passt.h b/passt.h > index 3a072945c382..205d7eecede7 100644 > --- a/passt.h > +++ b/passt.h > @@ -194,7 +194,6 @@ struct ip6_ctx { > * @no_udp: Disable UDP operation > * @udp: Context for UDP protocol handler > * @no_icmp: Disable ICMP operation > - * @icmp: Context for ICMP protocol handler > * @mtu: MTU passed via DHCP/NDP > * @no_dns: Do not source/use DNS servers for any purpose > * @no_dns_search: Do not source/use domain search lists for any purpose > @@ -279,7 +278,6 @@ struct ctx { > int no_udp; > struct udp_ctx udp; > int no_icmp; > - struct icmp_ctx icmp; > > int no_dns; > int no_dns_search; > diff --git a/udp.h b/udp.h > index 9ea7de682caf..b50283eab198 100644 > --- a/udp.h > +++ b/udp.h > @@ -26,14 +26,12 @@ void udp_update_l2_buf(const unsigned char *eth_d); > * struct udp_ctx - Execution context for UDP > * @scan_in: Port scanning state for inbound packets > * @scan_out: Port scanning state for outbound packets > - * @timer_run: Timestamp of most recent timer run > * @timeout: Timeout for unidirectional flows (in s) > * @stream_timeout: Timeout for stream-like flows (in s) > */ > struct udp_ctx { > struct fwd_scan scan_in; > struct fwd_scan scan_out; > - struct timespec timer_run; > int timeout; > int stream_timeout; > };